Re: [PATCH 14/14] env: Use static_assert() to check if default_environment is too large

Simon Glass
2021-10-31T12:57:30Z

On Fri, 22 Oct 2021 at 07:48, Marek Behún <kabel@kernel.org> wrote:
>
> From: Marek Behún <marek.behun@nic.cz>
>
> Check sizeof(default_environment) against ENV_SIZE in a static_assert()
> instead of runtime.
> Only check if !USE_HOSTCC (for in fw_env tool ENV_SIZE expands to a
> variable, and cannot be checked statically) nad
> !DEFAULT_ENV_INSTANCE_EMBEDDED, for in that case the default_environment
> variable is not set.
>
> Signed-off-by: Marek Behún <marek.behun@nic.cz>
> ---
> env/common.c | 5 -----
> include/env_default.h | 6 ++++++
> 2 files changed, 6 insertions(+), 5 deletions(-)

Reviewed-by: Simon Glass <sjg@chromium.org>

Applied to u-boot-dm, thanks!