Re: [PATCH 6/8] pci: pci_mvebu: Do not automatically enable bus mastering on PCI Bridge

Stefan Roese
2021-11-02T10:50:31Z

> Now that PCI Bridge is working, U-Boot's CONFIG_PCI_PNP code automatically
> enables memory access and bus mastering when it is needed. So do not
> prematurely enable memory access and bus mastering.
>
> Signed-off-by: Pali Rohár <pali@kernel.org>
> Reviewed-by: Marek Behún <marek.behun@nic.cz>

Reviewed-by: Stefan Roese <sr@denx.de>

Thanks,
Stefan

> ---
> drivers/pci/pci_mvebu.c | 8 --------
> 1 file changed, 8 deletions(-)
>
> diff --git a/drivers/pci/pci_mvebu.c b/drivers/pci/pci_mvebu.c
> index 40b8a57bbe1e..e43fa12d3819 100644
> --- a/drivers/pci/pci_mvebu.c
> +++ b/drivers/pci/pci_mvebu.c
> @@ -451,14 +451,6 @@ static int mvebu_pcie_probe(struct udevice *dev)
> /* Setup windows and configure host bridge */
> mvebu_pcie_setup_wins(pcie);
>
> - /* Master + slave enable. */
> - reg = readl(pcie->base + PCIE_CMD_OFF);
> - reg |= PCI_COMMAND_MEMORY;
> - reg |= PCI_COMMAND_IO;
> - reg |= PCI_COMMAND_MASTER;
> - reg |= BIT(10); /* disable interrupts */
> - writel(reg, pcie->base + PCIE_CMD_OFF);
> -
> /* PCI memory space */
> pci_set_region(hose->regions + 0, pcie->mem.start,
> pcie->mem.start, PCIE_MEM_SIZE, PCI_REGION_MEM);
>

Viele Grüße,
Stefan

--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr@denx.de