From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A18DC433EF for ; Fri, 22 Oct 2021 14:04:46 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 99C3A61052 for ; Fri, 22 Oct 2021 14:04:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 99C3A61052 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nic.cz Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 1E6F283459; Fri, 22 Oct 2021 16:04:43 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=nic.cz Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; secure) header.d=nic.cz header.i=@nic.cz header.b="iaG89TMP"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 3FA5483458; Fri, 22 Oct 2021 16:04:41 +0200 (CEST) Received: from mail.nic.cz (mail.nic.cz [IPv6:2001:1488:800:400::400]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 0FCCF83459 for ; Fri, 22 Oct 2021 16:04:38 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=nic.cz Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=marek.behun@nic.cz Received: from thinkpad (unknown [172.20.6.87]) by mail.nic.cz (Postfix) with ESMTPSA id A48221409DB; Fri, 22 Oct 2021 16:04:37 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=nic.cz; s=default; t=1634911477; bh=HaV8vwSMA2JXNhq4rUJiZXrwoeQ+sG105i7VEd2Ndd8=; h=Date:From:To; b=iaG89TMPTCvDsAKxbAaxmsrtoMWsfXOidrf9cMPeL7qB/bFMYGfTPwwZTekM6AonF fOEbWi7TAm2rzcdths/gQ7Tfq0IVrJ3HT7gLWRugsfsIZrQOv4mX6oiDkFJt665dzU HaLQ/GEWTuzUUTsGRZ+yTkLnjGYwCELjQhuu5TFY= Date: Fri, 22 Oct 2021 16:04:36 +0200 From: Marek =?UTF-8?B?QmVow7pu?= To: Wolfgang Denk Cc: Simon Glass , Tom Rini , U-Boot Mailing List , Rasmus Villemoes , Heinrich Schuchardt , Joe Hershberger Subject: Re: [PATCH v9 3/7] env: Allow U-Boot scripts to be placed in a .env file Message-ID: <20211022160436.457e8365@thinkpad> In-Reply-To: <3763165.1634890015@gemini.denx.de> References: <20211019224422.1447059-1-sjg@chromium.org> <20211019164418.v9.3.Ie78bfbfca0d01d9cba501e127f446ec48e1f7afe@changeid> <3682215.1634809802@gemini.denx.de> <20211021122325.GX7964@bill-the-cat> <3695947.1634821611@gemini.denx.de> <20211021152537.441c37b9@thinkpad> <20211021152831.15524883@thinkpad> <3763165.1634890015@gemini.denx.de> X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Hello Wolfgang, On Fri, 22 Oct 2021 10:06:55 +0200 Wolfgang Denk wrote: > For the '+=' case, there is no way to escape the '+', as all > commonly used escapes are valid characters in the variable name, > too. We can define that backslash is to be also escaped if it is to be used as variable name: weird_var\\\+=abcd I still think it is far more intuitive than =+. Anyway, IMO '+' as the last character in varname is a extreme corner case; I think that no one sane actually uses it. But even if they did, Simon's patches do not break it. Simon's patches only disallow it in board environment definition during compilation. I think it is a completely reasonable thing to diallow board maintainers (i.e. only U-Boot developers, not users) from using such construction. Marek