From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34D03C433F5 for ; Mon, 25 Oct 2021 06:30:22 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 244F660EE3 for ; Mon, 25 Oct 2021 06:30:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 244F660EE3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 416E382ECC; Mon, 25 Oct 2021 08:30:19 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1635143419; bh=1eTTyRKDN1cBQnb5rcBieBAkhcxBrDObX60QGG3Oue8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=a7KpkCCa1rnQ+bwE7KXfhrRB7PaO3DlDIz1pJmEiExhgPBNlbg8jps0mVue4G6wLy yAwEG5uO4Kld3lPWUkqCxhAi3c2TfgGq+4E2N4daWbI8pYKCACZtkRoReMlO12JGd2 kYqbifZM/d9cmfp/aQSHCXtLl/fWiff6wemvV7mdMQRwzNidyan1jHdQeE67B8W8Sw xZRIy4PWakPiklmX1D6hpEyGwll1sfo5M9ONWt2R8E4VBOE60kcaDK/wyjN3eACPQd hZOv2f5MUllYFZ2cta8GB+lLqJJL44zCLM3oX5vh815MgDMZRnMSO8M4aYd0PhwigN V2TknGMd0SYtw== Received: from ktm (85-222-111-42.dynamic.chello.pl [85.222.111.42]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: lukma@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id 7C42B8128D; Mon, 25 Oct 2021 08:30:16 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1635143416; bh=1eTTyRKDN1cBQnb5rcBieBAkhcxBrDObX60QGG3Oue8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=D+LHcxAu2v7aTCsa3KZdrKNSRFKNr3FxEaR+TFXWM9Tq5sULSAc6px1FyDxvQx9m2 BJrewdieRXI2NTiPRiQfyYCKrnfunNNvXDKmCPJJ+1b95ug7Z7VoKuz2gVXsfPXn58 mzRtdS7jbjUroBlLALQd3K8eiLVSRkbCalz7zF3gasiIZY/a9ilvSOX7VSbFt6IZ4j GC9Cbx1OI3M7T9cyZYSFjKwdnxInRJLa5LtXucFgmUUPVrTTCbo1nhuTrDbmTMymFn Op/rtPJPRUNp9gnBBpXvPjjpGXjHlK8hmdIvFJTOgK3odejXa34V3NvvtHJfe3igad DwSSd48kdtRMg== Date: Mon, 25 Oct 2021 08:30:10 +0200 From: Lukasz Majewski To: Marek Vasut , Tom Rini Cc: u-boot@lists.denx.de Subject: Re: [PATCH] dfu: dfu_sf: Read the SPI flash in 16 MiB chunks Message-ID: <20211025083010.3db13d6f@ktm> In-Reply-To: <21dea22a-3296-6cb1-5b07-a9ceed2f65ff@denx.de> References: <20210914032651.273567-1-marex@denx.de> <20210914113118.2253842c@ktm> <21dea22a-3296-6cb1-5b07-a9ceed2f65ff@denx.de> Organization: denx.de X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; boundary="Sig_/MUs5QGiKO9=k9gKAXuzUgzu"; protocol="application/pgp-signature" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --Sig_/MUs5QGiKO9=k9gKAXuzUgzu Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Hi Marek, > On 9/14/21 11:31 AM, Lukasz Majewski wrote: > > On Tue, 14 Sep 2021 05:26:51 +0200 > > Marek Vasut wrote: > > =20 > >> Not all SPI flashes and controllers can do continuous transfer > >> longer than 16 MiB, so perform the DFU read in 16 MiB chunks. > >> > >> Signed-off-by: Marek Vasut > >> Cc: Lukasz Majewski > >> --- > >> drivers/dfu/dfu_sf.c | 14 ++++++++++++-- > >> 1 file changed, 12 insertions(+), 2 deletions(-) > >> > >> diff --git a/drivers/dfu/dfu_sf.c b/drivers/dfu/dfu_sf.c > >> index 7e64ab772f0..b72493ced86 100644 > >> --- a/drivers/dfu/dfu_sf.c > >> +++ b/drivers/dfu/dfu_sf.c > >> @@ -24,8 +24,18 @@ static int dfu_get_medium_size_sf(struct > >> dfu_entity *dfu, u64 *size) static int dfu_read_medium_sf(struct > >> dfu_entity *dfu, u64 offset, void *buf, long *len) > >> { > >> - return spi_flash_read(dfu->data.sf.dev, > >> dfu->data.sf.start + offset, > >> - *len, buf); > >> + long seglen =3D *len; > >> + int ret; > >> + > >> + if (seglen > (16 << 20)) > >> + seglen =3D (16 << 20); > >> + > >> + ret =3D spi_flash_read(dfu->data.sf.dev, dfu->data.sf.start > >> + offset, > >> + seglen, buf); > >> + if (!ret) > >> + *len =3D seglen; > >> + > >> + return ret; > >> } > >> =20 > >> static u64 find_sector(struct dfu_entity *dfu, u64 start, u64 > >> offset) =20 > >=20 > > Reviewed-by: Lukasz Majewski =20 >=20 > Is there going to be a PR with this or shall Tom pick it directly, > since it is just one patch ? Please, Tom pick it up... Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de --Sig_/MUs5QGiKO9=k9gKAXuzUgzu Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEgAyFJ+N6uu6+XupJAR8vZIA0zr0FAmF2TvIACgkQAR8vZIA0 zr1ZeQgAtl2LzEZYOiJikjoB3VOqqhJYOKXA6BW1qs7TJMLvwoaIKJZk649jWepS BXDZ3JasBjMljftpwfQ4AQNo1bjH8aia24hEo9uvzuQ1qC9WHFbodSc3Ol08FO42 Ual4pKPAmY6SBw3XHGuM5G6M9iXFUoTw3YMxXVULg6GrWLoRZyUxvp1XQQu2PSaL R+70HJoiJyMo8CUP4dYBd07RdqMqZES2HQS+iUw3UK1diymZICbK4VS1o76tIL5t RHsLoJrWJVVuR4SH9DAXGEvVfKfjrWxtvFuU9qctPyJgp/HbWTPzQYMY0sWfwcEh CytXypJDLF5/2UAlHufVUEukIAUdIA== =3H49 -----END PGP SIGNATURE----- --Sig_/MUs5QGiKO9=k9gKAXuzUgzu--