Re: [PATCH u-boot-marvell 02/13] tools: kwboot: Fix initialization of tty device

Stefan Roese
2021-10-26T05:42:09Z

On 25.10.21 15:12, Marek Behún wrote:
> From: Pali Rohár <pali@kernel.org>
>
> Explicitly disable 2 stop bits by clearing CSTOPB flag, disable modem
> control flow by clearing CRTSCTS flag and do not send hangup after closing
> device by clearing HUPCL flag.
>
> Signed-off-by: Pali Rohár <pali@kernel.org>
> Reviewed-by: Marek Behún <marek.behun@nic.cz>

Reviewed-by: Stefan Roese <sr@denx.de>

Thanks,
Stefan

> ---
> tools/kwboot.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tools/kwboot.c b/tools/kwboot.c
> index 695d433b96..c55b41025b 100644
> --- a/tools/kwboot.c
> +++ b/tools/kwboot.c
> @@ -657,6 +657,7 @@ kwboot_open_tty(const char *path, int baudrate)
>
> cfmakeraw(&tio);
> tio.c_cflag |= CREAD | CLOCAL;
> + tio.c_cflag &= ~(CSTOPB | HUPCL | CRTSCTS);
> tio.c_cc[VMIN] = 1;
> tio.c_cc[VTIME] = 0;
>
>

Viele Grüße,
Stefan

--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr@denx.de