From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CCC47C433EF for ; Mon, 25 Oct 2021 14:07:25 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3343D60F9B for ; Mon, 25 Oct 2021 14:07:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 3343D60F9B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 4E59E8353B; Mon, 25 Oct 2021 16:07:23 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id E57A88353C; Mon, 25 Oct 2021 16:07:18 +0200 (CEST) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by phobos.denx.de (Postfix) with ESMTP id 08E778352D for ; Mon, 25 Oct 2021 16:07:11 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=andre.przywara@arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6B7AD1FB; Mon, 25 Oct 2021 07:07:10 -0700 (PDT) Received: from slackpad.fritz.box (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 9B9D33F5A1; Mon, 25 Oct 2021 07:07:09 -0700 (PDT) Date: Mon, 25 Oct 2021 15:07:05 +0100 From: Andre Przywara To: Samuel Holland Cc: u-boot@lists.denx.de, Jagan Teki , Joe Hershberger Subject: Re: [PATCH 1/3] phy: sun4i-usb: Remove a couple of debug messages Message-ID: <20211025150705.24bca1de@slackpad.fritz.box> In-Reply-To: <20210912142243.9912-2-samuel@sholland.org> References: <20210912142243.9912-1-samuel@sholland.org> <20210912142243.9912-2-samuel@sholland.org> Organization: Arm Ltd. X-Mailer: Claws Mail 3.17.1 (GTK+ 2.24.31; x86_64-slackware-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On Sun, 12 Sep 2021 09:22:40 -0500 Samuel Holland wrote: > Both of these messages log the GPIO number of the ID detection GPIO, > which is not terribly useful, especially in the VBUS detection function. > > Signed-off-by: Samuel Holland Reviewed-by: Andre Przywara Cheers, Andre > --- > > drivers/phy/allwinner/phy-sun4i-usb.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/drivers/phy/allwinner/phy-sun4i-usb.c b/drivers/phy/allwinner/phy-sun4i-usb.c > index 82713b83815..5302b809ee6 100644 > --- a/drivers/phy/allwinner/phy-sun4i-usb.c > +++ b/drivers/phy/allwinner/phy-sun4i-usb.c > @@ -393,8 +393,6 @@ int sun4i_usb_phy_vbus_detect(struct phy *phy) > struct sun4i_usb_phy_plat *usb_phy = &data->usb_phy[phy->id]; > int err, retries = 3; > > - debug("%s: id_det = %d\n", __func__, usb_phy->gpio_id_det); > - > if (usb_phy->gpio_vbus_det < 0) > return usb_phy->gpio_vbus_det; > > @@ -417,8 +415,6 @@ int sun4i_usb_phy_id_detect(struct phy *phy) > struct sun4i_usb_phy_data *data = dev_get_priv(phy->dev); > struct sun4i_usb_phy_plat *usb_phy = &data->usb_phy[phy->id]; > > - debug("%s: id_det = %d\n", __func__, usb_phy->gpio_id_det); > - > if (usb_phy->gpio_id_det < 0) > return usb_phy->gpio_id_det; >