From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 257A0C433F5 for ; Mon, 25 Oct 2021 14:08:58 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4105960F70 for ; Mon, 25 Oct 2021 14:08:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 4105960F70 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 79DC083535; Mon, 25 Oct 2021 16:08:55 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id 4283B8353B; Mon, 25 Oct 2021 16:08:53 +0200 (CEST) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by phobos.denx.de (Postfix) with ESMTP id 9110E8352E for ; Mon, 25 Oct 2021 16:08:47 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=andre.przywara@arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id DC8821FB; Mon, 25 Oct 2021 07:08:46 -0700 (PDT) Received: from slackpad.fritz.box (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 37F593F5A1; Mon, 25 Oct 2021 07:08:46 -0700 (PDT) Date: Mon, 25 Oct 2021 15:08:41 +0100 From: Andre Przywara To: Samuel Holland Cc: u-boot@lists.denx.de, Jagan Teki , Joe Hershberger Subject: Re: [PATCH 3/3] phy: sun4i-usb: Support VBUS detection via power supply Message-ID: <20211025150841.71e7e5e3@slackpad.fritz.box> In-Reply-To: <20210912142243.9912-4-samuel@sholland.org> References: <20210912142243.9912-1-samuel@sholland.org> <20210912142243.9912-4-samuel@sholland.org> Organization: Arm Ltd. X-Mailer: Claws Mail 3.17.1 (GTK+ 2.24.31; x86_64-slackware-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On Sun, 12 Sep 2021 09:22:42 -0500 Samuel Holland wrote: > The device tree binding provides for getting VBUS state from a device > referenced by phandle, as an optional alternative to using a GPIO. In > U-Boot, where there is no power supply class, this VBUS detection will > be implemented using a regulator device and its get_enable method. > Let's hook this up to the PHY driver. > > Signed-off-by: Samuel Holland Looks good, but curious if that works on all those boards ... Acked-by: Andre Przywara Cheers, Andre > --- > > drivers/phy/allwinner/Kconfig | 1 + > drivers/phy/allwinner/phy-sun4i-usb.c | 7 +++++++ > 2 files changed, 8 insertions(+) > > diff --git a/drivers/phy/allwinner/Kconfig b/drivers/phy/allwinner/Kconfig > index dba3bae61c4..aa9d0e7e6a5 100644 > --- a/drivers/phy/allwinner/Kconfig > +++ b/drivers/phy/allwinner/Kconfig > @@ -4,6 +4,7 @@ > config PHY_SUN4I_USB > bool "Allwinner Sun4I USB PHY driver" > depends on ARCH_SUNXI > + select DM_REGULATOR > select PHY > help > Enable this to support the transceiver that is part of Allwinner > diff --git a/drivers/phy/allwinner/phy-sun4i-usb.c b/drivers/phy/allwinner/phy-sun4i-usb.c > index 827ecd70f27..ab2a5d17fcf 100644 > --- a/drivers/phy/allwinner/phy-sun4i-usb.c > +++ b/drivers/phy/allwinner/phy-sun4i-usb.c > @@ -26,6 +26,7 @@ > #include > #include > #include > +#include > > #define REG_ISCR 0x00 > #define REG_PHYCTL_A10 0x04 > @@ -137,6 +138,7 @@ struct sun4i_usb_phy_data { > void __iomem *base; > const struct sun4i_usb_phy_cfg *cfg; > struct sun4i_usb_phy_plat *usb_phy; > + struct udevice *vbus_power_supply; > }; > > static int initial_usb_scan_delay = CONFIG_INITIAL_USB_SCAN_DELAY; > @@ -404,6 +406,8 @@ int sun4i_usb_phy_vbus_detect(struct phy *phy) > mdelay(100); > err = gpio_get_value(usb_phy->gpio_vbus_det); > } > + } else if (data->vbus_power_supply) { > + err = regulator_get_enable(data->vbus_power_supply); > } > > return err; > @@ -447,6 +451,9 @@ static int sun4i_usb_phy_probe(struct udevice *dev) > if (IS_ERR(data->base)) > return PTR_ERR(data->base); > > + device_get_supply_regulator(dev, "usb0_vbus_power-supply", > + &data->vbus_power_supply); > + > data->usb_phy = plat; > for (i = 0; i < data->cfg->num_phys; i++) { > struct sun4i_usb_phy_plat *phy = &plat[i];