* [PATCH] sunxi: A23/A33/H3: Actually move the secure monitor
@ 2021-10-12 23:54 Samuel Holland
2021-10-25 14:08 ` Andre Przywara
0 siblings, 1 reply; 2+ messages in thread
From: Samuel Holland @ 2021-10-12 23:54 UTC (permalink / raw)
To: u-boot, Jagan Teki, Andre Przywara; +Cc: Samuel Holland
commit 1ebfc0c631e3 ("sunxi: A23/A33/H3: Move sun8i secure monitor to
SRAM A2") attempted to move the secure monitor to SRAM A2. But not all
sun8i SoCs have SRAM A2, so a check was put in for SUNXI_SRAM_A2_SIZE to
avoid breaking the other SoCs.
However, because the header providing SUNXI_SRAM_A2_SIZE was not
included, this unintentionally skipped the new definitions on all SoCs.
Fix this by including the right header.
Fixes: 1ebfc0c631e3 ("sunxi: A23/A33/H3: Move sun8i secure monitor to SRAM A2")
Signed-off-by: Samuel Holland <samuel@sholland.org>
---
include/configs/sun8i.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/include/configs/sun8i.h b/include/configs/sun8i.h
index 27c9808a49..5636356366 100644
--- a/include/configs/sun8i.h
+++ b/include/configs/sun8i.h
@@ -12,6 +12,8 @@
* A23 specific configuration
*/
+#include <asm/arch/cpu.h>
+
#ifdef SUNXI_SRAM_A2_SIZE
/*
* If the SoC has enough SRAM A2, use that for the secure monitor.
--
2.32.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] sunxi: A23/A33/H3: Actually move the secure monitor
2021-10-12 23:54 [PATCH] sunxi: A23/A33/H3: Actually move the secure monitor Samuel Holland
@ 2021-10-25 14:08 ` Andre Przywara
0 siblings, 0 replies; 2+ messages in thread
From: Andre Przywara @ 2021-10-25 14:08 UTC (permalink / raw)
To: Samuel Holland; +Cc: u-boot, Jagan Teki
On Tue, 12 Oct 2021 18:54:56 -0500
Samuel Holland <samuel@sholland.org> wrote:
> commit 1ebfc0c631e3 ("sunxi: A23/A33/H3: Move sun8i secure monitor to
> SRAM A2") attempted to move the secure monitor to SRAM A2. But not all
> sun8i SoCs have SRAM A2, so a check was put in for SUNXI_SRAM_A2_SIZE to
> avoid breaking the other SoCs.
>
> However, because the header providing SUNXI_SRAM_A2_SIZE was not
> included, this unintentionally skipped the new definitions on all SoCs.
> Fix this by including the right header.
>
> Fixes: 1ebfc0c631e3 ("sunxi: A23/A33/H3: Move sun8i secure monitor to SRAM A2")
> Signed-off-by: Samuel Holland <samuel@sholland.org>
Indeed. Weird, I thought I checked the readelf output.
Reviewed-by: Andre Przywara <andre.przywara@arm.com>
Cheers,
Andre
> ---
>
> include/configs/sun8i.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/include/configs/sun8i.h b/include/configs/sun8i.h
> index 27c9808a49..5636356366 100644
> --- a/include/configs/sun8i.h
> +++ b/include/configs/sun8i.h
> @@ -12,6 +12,8 @@
> * A23 specific configuration
> */
>
> +#include <asm/arch/cpu.h>
> +
> #ifdef SUNXI_SRAM_A2_SIZE
> /*
> * If the SoC has enough SRAM A2, use that for the secure monitor.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-10-25 14:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-10-12 23:54 [PATCH] sunxi: A23/A33/H3: Actually move the secure monitor Samuel Holland
2021-10-25 14:08 ` Andre Przywara
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox