From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60ED5C433F5 for ; Mon, 25 Oct 2021 14:09:25 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CECC260F9D for ; Mon, 25 Oct 2021 14:09:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org CECC260F9D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 26E47834CD; Mon, 25 Oct 2021 16:09:23 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id D56B083569; Mon, 25 Oct 2021 16:09:15 +0200 (CEST) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by phobos.denx.de (Postfix) with ESMTP id 47B7E8355F for ; Mon, 25 Oct 2021 16:09:02 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=andre.przywara@arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6F53A1FB; Mon, 25 Oct 2021 07:09:01 -0700 (PDT) Received: from slackpad.fritz.box (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id BF4C03F5A1; Mon, 25 Oct 2021 07:09:00 -0700 (PDT) Date: Mon, 25 Oct 2021 15:08:56 +0100 From: Andre Przywara To: Samuel Holland Cc: u-boot@lists.denx.de, Jagan Teki Subject: Re: [PATCH] sunxi: A23/A33/H3: Actually move the secure monitor Message-ID: <20211025150856.2f496330@slackpad.fritz.box> In-Reply-To: <20211012235457.24615-1-samuel@sholland.org> References: <20211012235457.24615-1-samuel@sholland.org> Organization: Arm Ltd. X-Mailer: Claws Mail 3.17.1 (GTK+ 2.24.31; x86_64-slackware-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On Tue, 12 Oct 2021 18:54:56 -0500 Samuel Holland wrote: > commit 1ebfc0c631e3 ("sunxi: A23/A33/H3: Move sun8i secure monitor to > SRAM A2") attempted to move the secure monitor to SRAM A2. But not all > sun8i SoCs have SRAM A2, so a check was put in for SUNXI_SRAM_A2_SIZE to > avoid breaking the other SoCs. > > However, because the header providing SUNXI_SRAM_A2_SIZE was not > included, this unintentionally skipped the new definitions on all SoCs. > Fix this by including the right header. > > Fixes: 1ebfc0c631e3 ("sunxi: A23/A33/H3: Move sun8i secure monitor to SRAM A2") > Signed-off-by: Samuel Holland Indeed. Weird, I thought I checked the readelf output. Reviewed-by: Andre Przywara Cheers, Andre > --- > > include/configs/sun8i.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/include/configs/sun8i.h b/include/configs/sun8i.h > index 27c9808a49..5636356366 100644 > --- a/include/configs/sun8i.h > +++ b/include/configs/sun8i.h > @@ -12,6 +12,8 @@ > * A23 specific configuration > */ > > +#include > + > #ifdef SUNXI_SRAM_A2_SIZE > /* > * If the SoC has enough SRAM A2, use that for the secure monitor.