From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94253C433F5 for ; Mon, 25 Oct 2021 14:01:40 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B22A860F9B for ; Mon, 25 Oct 2021 14:01:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org B22A860F9B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 4E5C683461; Mon, 25 Oct 2021 16:01:37 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="gs7DhqQv"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 18518834F4; Mon, 25 Oct 2021 16:01:35 +0200 (CEST) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id BE03283458 for ; Mon, 25 Oct 2021 16:01:31 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=kabel@kernel.org Received: by mail.kernel.org (Postfix) with ESMTPSA id B9A6D60E0B; Mon, 25 Oct 2021 14:01:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1635170490; bh=C+RF0hdlt0mV12dHZubrqEGBN7purFIp51KuKVh7Ec8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=gs7DhqQvuETPD3tW9xkhW/WRih6RdBwqnjcXHFx8Rz/OZV7+spQwgQDzJVlZiYvN/ nqlEXw0FPgrlbhZaoypMyvd3BEROH6eU66B5fE01KzVW0zC8SHHy9RGZkhX7lOm4qm J6K2owuVj1alsfyfFnYM+qkMTXEfquKnvGclykZFFB359CvfKdb6XDE97wXA9snYrX mw5CECMGz0DIBNkfE9LHW8nbhnwPREkm6VrgbyoSRZccyvmI3PpUYXC0dmWnoLEoDn hN8zasSrfOggkfcBLj3NTUaBnPUwjGxXaP4U6oUIcHO0Q5grEQDiPUxNOkZRafByGU p6tDvGTOREVgA== Date: Mon, 25 Oct 2021 16:01:24 +0200 From: Marek =?UTF-8?B?QmVow7pu?= To: Roman Bacik Cc: U-Boot Mailing List , Bharat Gooty , Bin Meng , Franck LENORMAND , Heinrich Schuchardt , Kory Maincent , Michal Simek , Patrick Delaunay , Peng Fan , Priyanka Jain , Rayagonda Kokatanur , Sean Anderson , Simon Glass Subject: Re: [PATCH v2 2/2] cmd: brcm: netXtreme commands Message-ID: <20211025160124.3c423233@thinkpad> In-Reply-To: <20211022162222.v2.2.I1edaad77041c1300213c307eef6741499504047@changeid> References: <20211022162222.v2.1.I1edaad77041c1300213c307eef6741499504047@changeid> <20211022162222.v2.2.I1edaad77041c1300213c307eef6741499504047@changeid> X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On Fri, 22 Oct 2021 16:23:33 -0700 Roman Bacik wrote: > From: Bharat Gooty > > Following netXtreme commands are supported:- > Device probe, remove, supported speeds, get/set speeds and > get/set MAC address. NAK. - "bnxt get mac U-Boot uses the ethaddr and ethNaddr environment variables for MAC addresses. You don't need a new custom command for that when there is a generic mechanism for this. - " probe" / " remove" You also shouldn't need a command for driver probe / remove. DM should probe your driver automatically. And if you need it for debugging, please add such subcommand to the dm command. - "bnxt get supported_speed" "bnxt get link_speed" These should be available via the mdio command when you register your PHY driver via appropriate API. Marek