From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F518C433F5 for ; Tue, 26 Oct 2021 13:34:59 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CA74A60EC0 for ; Tue, 26 Oct 2021 13:34:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org CA74A60EC0 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 0D01981F0B; Tue, 26 Oct 2021 15:34:57 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="rLcY5I1s"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 9DC8C83453; Tue, 26 Oct 2021 15:34:46 +0200 (CEST) Received: from mail-qk1-x72b.google.com (mail-qk1-x72b.google.com [IPv6:2607:f8b0:4864:20::72b]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id A378580F1A for ; Tue, 26 Oct 2021 15:34:39 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qk1-x72b.google.com with SMTP id d15so15032049qkj.10 for ; Tue, 26 Oct 2021 06:34:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=uoL3OeUOqfO1lUmaUCq43E0amJLr1k7ntE37JsfSQGA=; b=rLcY5I1s6teyf1PEsvKkY7nqhvqPqbKLlvX7VKLOx7V+PLXYjH9eVLMv2A9bqibm8S OCypFLffFsLF99nxnG59D48tR0MQ/D6IsU/xYHD7DDx3J65XCWQmIDYft+hiSsa1moXZ NIZxbV+bdfzYz6319IIE9XXRLNsloV0QQeYvM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=uoL3OeUOqfO1lUmaUCq43E0amJLr1k7ntE37JsfSQGA=; b=ViGlBGcA6Y09iUYaVHA359piPdaqobMOB4sovv45pP3+iFzPTvR7xeUn05lm4LbK61 dUHeAORQTcxqI/OH7sSpxWmZ3JjR4Re3NrdwRWQS6TCBSPi9qd0nhQ6jNjWw2JW2vxUR EhIC5xwECqGUjqxW1CNETsN3jtu2W0JhptHAVzqL8TH1V1XtNXVIo2a+7CHTYw5TELF8 5bhKVxn8brdbN+//eNs0wA4Ohq8iR4l9GmdSReMiNXjZn0rcOV41Cy1ViOO1YutaByU3 vXzOkRNSasZKrB2pFiG8feEu/n2ZLvpuXqaDsh1+nApjkY6B3fxm1I3Hicvhgpw/lneJ r7GA== X-Gm-Message-State: AOAM530KEB/gPmeRKuBC2yAvNkx8r54iO3sxrTs2511nsXGC/QKBz2mO +Oh5aBtHZv3BHJ4MGEPR7PwrfQ== X-Google-Smtp-Source: ABdhPJxBGVbggHqigJonb7ZgvJ2wOA1OLv57x7HiDqSm2rJZSUb7c9jBViXrk8aC2Hktyebj+bfNgQ== X-Received: by 2002:a37:a050:: with SMTP id j77mr19359225qke.337.1635255278484; Tue, 26 Oct 2021 06:34:38 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-9d55-b872-362e-0c9f.res6.spectrum.com. [2603:6081:7b01:cbda:9d55:b872:362e:c9f]) by smtp.gmail.com with ESMTPSA id s3sm10343082qkj.118.2021.10.26.06.34.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Oct 2021 06:34:37 -0700 (PDT) Date: Tue, 26 Oct 2021 09:34:35 -0400 From: Tom Rini To: Marek Vasut Cc: u-boot@lists.denx.de, Fabio Estevam , Jaehoon Chung , Peng Fan , Stefano Babic Subject: Re: [PATCH 1/2] env: mmc: Add missing eMMC bootpart restoration to env erase Message-ID: <20211026133435.GF8284@bill-the-cat> References: <20211006162954.63596-1-marex@denx.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="lteA1dqeVaWQ9QQl" Content-Disposition: inline In-Reply-To: <20211006162954.63596-1-marex@denx.de> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --lteA1dqeVaWQ9QQl Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Oct 06, 2021 at 06:29:53PM +0200, Marek Vasut wrote: > If the environment is stored in eMMC hardware boot partition, the environ= ment > driver first stores the currently selected eMMC boot partition, then does= the > requested operation, and then restores the original boot partition settin= gs. > In case the environment operation fails, the boot partition settings are = also > restored. >=20 > The 'env erase' implementation in the MMC environment driver lacks the pa= th > which restores the boot partition. This could lead to various failure mod= es, > like the system boots the wrong copy of bootloader etc. Fix this by filli= ng > in the missing restoration path. >=20 > Signed-off-by: Marek Vasut > Cc: Fabio Estevam > Cc: Jaehoon Chung > Cc: Peng Fan > Cc: Stefano Babic Applied to u-boot/master, thanks! --=20 Tom --lteA1dqeVaWQ9QQl Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmF4A+sACgkQFHw5/5Y0 tyx7/AwApwKJf616n5qCGWmzx8ISgp03NofdkkeBOBV1e3eypL0f3VKIRBQFYCfh bYkoW1Can12VHVZTz0UvtJmuKo7R6peQi72JwY9sZflyXzQQrF6GcUPg9k0mi/25 qjJRo8D+Bmww+cfM6w7zytCGCYcx5fzgMOAHqde1mUqLWk8t4o1/VFnjq0dyoWKc +YlAS6n1Sr7wXhvAz9ufmP3x+2qGDZE6HYheUBo/hTC14E3/YFvSXtkz4wUPokPN D8fnE06lI2xpHL5oX0+PS/+jd8luNTfR2oLg53AI35N9FHerF8hODezttn0hUY2k 2hkkw8gRQuljiLE6bKCPV3DOFG00vx5U7S+/3rN4MT9vZrpzYWRMWMMhO4Ofzcqa hybkNnM/xzB2QRCLKadTfa+bDorIhR9xsB6zP1jDSb9xCKyiY0p0dGTAsjsIP4Z9 NMUEisKVxCBaa3jVahsj52WxZOl6wdNhb5x2TXwC7TGcpNtEKKdzH/jnQDVhRZDc ym0hb2wi =4vA3 -----END PGP SIGNATURE----- --lteA1dqeVaWQ9QQl--