From: "Marek Behún" <kabel@kernel.org>
To: Roman Bacik <roman.bacik@broadcom.com>
Cc: U-Boot Mailing List <u-boot@lists.denx.de>,
Bharat Gooty <bharat.gooty@broadcom.com>,
Aswath Govindraju <a-govindraju@ti.com>,
Bin Meng <bmeng.cn@gmail.com>,
Franck LENORMAND <franck.lenormand@nxp.com>,
Heinrich Schuchardt <xypron.glpk@gmx.de>,
Kory Maincent <kory.maincent@bootlin.com>,
Michal Simek <michal.simek@xilinx.com>,
Patrick Delaunay <patrick.delaunay@foss.st.com>,
Peng Fan <peng.fan@nxp.com>,
Priyanka Jain <priyanka.jain@nxp.com>,
Rayagonda Kokatanur <rayagonda.kokatanur@broadcom.com>,
Sean Anderson <sean.anderson@seco.com>,
Simon Glass <sjg@chromium.org>
Subject: Re: [PATCH v3 2/2] cmd: brcm: netXtreme commands
Date: Tue, 26 Oct 2021 15:17:42 +0200 [thread overview]
Message-ID: <20211026151742.42b0fcfa@thinkpad> (raw)
In-Reply-To: <20211025164424.v3.2.I1edaad77041c1300213c307eef6741499504047@changeid>
On Mon, 25 Oct 2021 16:44:44 -0700
Roman Bacik <roman.bacik@broadcom.com> wrote:
> From: Bharat Gooty <bharat.gooty@broadcom.com>
>
> Following netXtreme commands are supported:
> probe, remove.
>
> Signed-off-by: Bharat Gooty <bharat.gooty@broadcom.com>
>
> Signed-off-by: Roman Bacik <roman.bacik@broadcom.com>
Hi Roman,
why do you need to have custom command for probing / removing the
driver?
U-Boot PCI code should probe the driver automatically upon recognizing
PCI vendor / device ID.
Even if not, adding custom command for such a thing isn't nice, when we
have the `dm` command for communicating with driver model.
Marek
next prev parent reply other threads:[~2021-10-26 13:17 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-25 23:44 [PATCH v3 1/2] net: brcm: netXtreme driver Roman Bacik
2021-10-25 23:44 ` [PATCH v3 2/2] cmd: brcm: netXtreme commands Roman Bacik
2021-10-26 13:17 ` Marek Behún [this message]
2021-10-26 15:14 ` Roman Bacik
2021-10-26 15:55 ` Marek Behún
2021-10-26 16:02 ` Roman Bacik
2021-10-26 16:40 ` Roman Bacik
2021-10-26 16:52 ` Marek Behún
2021-10-26 16:59 ` Roman Bacik
2021-10-26 16:49 ` Marek Behún
2021-10-27 15:05 ` Roman Bacik
2021-10-27 15:41 ` Simon Glass
2021-10-27 16:05 ` Roman Bacik
2021-10-27 16:35 ` Marek Behún
2021-10-27 16:47 ` Roman Bacik
2021-10-27 17:02 ` Roman Bacik
2021-10-27 17:39 ` Marek Behún
2021-10-27 17:58 ` Roman Bacik
2021-10-27 18:02 ` Marek Behún
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211026151742.42b0fcfa@thinkpad \
--to=kabel@kernel.org \
--cc=a-govindraju@ti.com \
--cc=bharat.gooty@broadcom.com \
--cc=bmeng.cn@gmail.com \
--cc=franck.lenormand@nxp.com \
--cc=kory.maincent@bootlin.com \
--cc=michal.simek@xilinx.com \
--cc=patrick.delaunay@foss.st.com \
--cc=peng.fan@nxp.com \
--cc=priyanka.jain@nxp.com \
--cc=rayagonda.kokatanur@broadcom.com \
--cc=roman.bacik@broadcom.com \
--cc=sean.anderson@seco.com \
--cc=sjg@chromium.org \
--cc=u-boot@lists.denx.de \
--cc=xypron.glpk@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox