From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6BB0BC433F5 for ; Tue, 26 Oct 2021 13:17:57 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8982560E96 for ; Tue, 26 Oct 2021 13:17:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 8982560E96 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 81D0280F5F; Tue, 26 Oct 2021 15:17:54 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="NHnzhPOI"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 86F1781F0B; Tue, 26 Oct 2021 15:17:52 +0200 (CEST) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 5FD3580F1A for ; Tue, 26 Oct 2021 15:17:49 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=kabel@kernel.org Received: by mail.kernel.org (Postfix) with ESMTPSA id 4BCE860E96; Tue, 26 Oct 2021 13:17:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1635254267; bh=1vQVVGg2nwM4M6f3Kk3fe4byjlnALv4XCiRHLmLaRkQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=NHnzhPOI/nTYQALHOLDFiW4Gni//P4mNPV5M+r4mIa1+4bFnVzAoRHiigEcffk38c TJ5xAg11MboSORyEOtWoI8md7dAgbnc25yjGPaY6atgQIbvLddOuaRWCvxO8yVixlB tHxEUpNwZcYY1GYWIcsZm/u5yAgwHbJZLAknKgMzCRy8/Te3jQ+zri0rkcf9yi8iqZ AM/zAHa2qSuvOZ0NdT/EEnGzFrTU5h2VxCEnD5IPtEAdwD8x2Ksu6Bg1TWm57R9Aru btaPSnbVKsDTAME/Zdj6lGVdN/261JQ2H4krgOd3UmXWEeud/jlrb8flCTbTAt4q4P 5BDO2BMROPXUw== Date: Tue, 26 Oct 2021 15:17:42 +0200 From: Marek =?UTF-8?B?QmVow7pu?= To: Roman Bacik Cc: U-Boot Mailing List , Bharat Gooty , Aswath Govindraju , Bin Meng , Franck LENORMAND , Heinrich Schuchardt , Kory Maincent , Michal Simek , Patrick Delaunay , Peng Fan , Priyanka Jain , Rayagonda Kokatanur , Sean Anderson , Simon Glass Subject: Re: [PATCH v3 2/2] cmd: brcm: netXtreme commands Message-ID: <20211026151742.42b0fcfa@thinkpad> In-Reply-To: <20211025164424.v3.2.I1edaad77041c1300213c307eef6741499504047@changeid> References: <20211025234444.1237-1-roman.bacik@broadcom.com> <20211025164424.v3.2.I1edaad77041c1300213c307eef6741499504047@changeid> X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On Mon, 25 Oct 2021 16:44:44 -0700 Roman Bacik wrote: > From: Bharat Gooty > > Following netXtreme commands are supported: > probe, remove. > > Signed-off-by: Bharat Gooty > > Signed-off-by: Roman Bacik Hi Roman, why do you need to have custom command for probing / removing the driver? U-Boot PCI code should probe the driver automatically upon recognizing PCI vendor / device ID. Even if not, adding custom command for such a thing isn't nice, when we have the `dm` command for communicating with driver model. Marek