From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4FE1FC433EF for ; Tue, 26 Oct 2021 22:42:11 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BF27060D42 for ; Tue, 26 Oct 2021 22:42:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org BF27060D42 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 3969783544; Wed, 27 Oct 2021 00:42:04 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="RwEQAI93"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 2B3D583458; Wed, 27 Oct 2021 00:41:55 +0200 (CEST) Received: from mail-qv1-xf30.google.com (mail-qv1-xf30.google.com [IPv6:2607:f8b0:4864:20::f30]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id E846F82EA5 for ; Wed, 27 Oct 2021 00:41:48 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qv1-xf30.google.com with SMTP id h11so499753qvk.4 for ; Tue, 26 Oct 2021 15:41:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=GvdcaIaQiOhQStQwgQ2Gr14Ysk14MI4dNd0VQuTKKxM=; b=RwEQAI93cOqKVHkcZSW6mHgPG35OYGcGc65CkiMcXZDqYqiyiLl1DjWqg4KqITHHlV FLca6TR5RbrU2gkk/OhTinGwg5uXBCwQ8GubYPVngCAym7P7wBYdzagH0rXorGet0gYw FOEVnoqyBsWBnuHfe+FXKXbteqr4sF9DEAQeI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=GvdcaIaQiOhQStQwgQ2Gr14Ysk14MI4dNd0VQuTKKxM=; b=vvat/6GvscYe/Wvd46/rH2ZzdrU0CePxiIEc7/om/iwUOd2Oe1/5VA9tw1NKcpgkWe 8Lj40lO000jnLVnb+BIFOSPt81Q4CzDjfjB9du+y+7zhWjUDWzZwZSQgBHT5aQ9a7U0r EM99lP46W22Wi2FnfVcWXQdWtj0tvQNMb/hQiwhLJlm+JIkjRAWH0rbsA9nPUp9FzkRS evaPaR0YbqMwFIYp7v18ruFih248B1Ttw1QSGWw7KKFdRSViYl1tMHAIRBm8nod6u3jW genqCsPzpQTgYKUDvLODUqDIZEYdHcodbvXvd25oDTJmQvyg323LDqscjjM7Zzn2fyeR fPSQ== X-Gm-Message-State: AOAM530u+810jd8oQbHanWnw3HKGN4liYXllh1b+iR8ikBeVuSxonDfA WHmqjRsz5E8RMUWUPl9P3h5+uN7Xrh4BSg== X-Google-Smtp-Source: ABdhPJwniMG5aGdcu9kT/hhACR83/D2B8AYqXcTd0g4ts+ZmuDE9/inY/wluNrvgkik3CEOEWshiwA== X-Received: by 2002:ad4:5c4f:: with SMTP id a15mr26089853qva.26.1635288107905; Tue, 26 Oct 2021 15:41:47 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-0044-6cb5-81ac-bb0c.res6.spectrum.com. [2603:6081:7b01:cbda:44:6cb5:81ac:bb0c]) by smtp.gmail.com with ESMTPSA id j14sm2677283qkp.25.2021.10.26.15.41.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Oct 2021 15:41:47 -0700 (PDT) Date: Tue, 26 Oct 2021 18:41:45 -0400 From: Tom Rini To: Philippe Reynes Cc: mr.nuke.me@gmail.com, sjg@chromium.org, u-boot@lists.denx.de Subject: Re: [PATCH] lib: rsa: rsa-verify: also check that padding is not NULL Message-ID: <20211026224145.GL8284@bill-the-cat> References: <20211015092847.18335-1-philippe.reynes@softathome.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="fUvfsPTz/SzOZDdw" Content-Disposition: inline In-Reply-To: <20211015092847.18335-1-philippe.reynes@softathome.com> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --fUvfsPTz/SzOZDdw Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Oct 15, 2021 at 11:28:47AM +0200, Philippe Reynes wrote: > This commit adds a check on the padding in the function rsa_verify_key > to avoid using a NULL pointer. >=20 > Signed-off-by: Philippe Reynes > Reviewed-by: Simon Glass Applied to u-boot/master, thanks! --=20 Tom --fUvfsPTz/SzOZDdw Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmF4hCkACgkQFHw5/5Y0 tywBcQv/cI1r5Oqul82hpgQhRvGvpmKhjpYvlxfdAI8NxHKW4QBmOUUioCOw/ZF2 xc2P9NXkm1QKeFohbsa2e3LDA/32yHwKtJLSzliBjdqz17HzOxgFTQOrEWL0q4IL L0QUaLDdELWiN53sMxMRhD86raayyqW1dWmv1EmtDYmlXKT8t/hJ0ZVteKkJkMuX rEudq/nSKinewV9/TMrkzVKuF3lHd16xAoU0hgqiOKkxStU+2p+cDydIU2quDUmh UfsSbmP0j+PMr3ODElrwOgi151kjm4kd6twZWkiZXfFKuvy6sdTgxdwdXkhpopKM wDbbDe/H9uzc/zVZ8kA44pjv6hkD1JAjcPtK1Suawq4EhCbvdWWsqF7t++adzIsT sepC4g6TBTKYfaKcNWFKy1zmWc2Fqp/Q5jVXHK0eZITfDMOe2CXnNBjF5MdsgSUZ PuoIN3PvKzmMQcWxk/VbPbnsnTamw98g3y+NJZq6u9XuVJxtt1N8cntNOJkQ57Ub 7STcn+1m =7iPE -----END PGP SIGNATURE----- --fUvfsPTz/SzOZDdw--