From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE85DC433F5 for ; Tue, 26 Oct 2021 22:43:05 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 52AE260D42 for ; Tue, 26 Oct 2021 22:43:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 52AE260D42 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id EA93283389; Wed, 27 Oct 2021 00:42:42 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="AJ7AuCgH"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 3AC898352A; Wed, 27 Oct 2021 00:42:20 +0200 (CEST) Received: from mail-qt1-x836.google.com (mail-qt1-x836.google.com [IPv6:2607:f8b0:4864:20::836]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 1619A83571 for ; Wed, 27 Oct 2021 00:42:15 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x836.google.com with SMTP id v17so783980qtp.1 for ; Tue, 26 Oct 2021 15:42:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=zhHMUHZ83HX2MFFBRBAx+M6ZfivcPYXLOtMpDVf/ESc=; b=AJ7AuCgH8sDTySeiGgDXXBbqkY3m9YwrsalBiz0zAmNp+Sc9BBPFM5teGEl8AliCtO Nc/mSqlJluuv853CGF3T28vQa2vLMWvsuI2u42V6WlUVxpuC22SiI74Q/uS0oe0u4BAi 16wcwuhIiZYsDdF+UzrGWdsoM9oj34S2mQRi4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=zhHMUHZ83HX2MFFBRBAx+M6ZfivcPYXLOtMpDVf/ESc=; b=i/t/tTguT0mgdkpifBT4RTZxyPfPWdCZ9QgQ61YgVKsbtEsDjJwZhvectBVV2qVza+ cYL5KmNIEBwT7fqZvpgVkB5w10o2XvkIhv/mYVbSEAP5orHIFiaMjQrBqeRBVfttu8RS 1eUn5jR0sIEX1JmDeoMJp+wvI3nYMvssCAgEZJxGbKwN2ZfDIa9tXgryOrAW1UsVu4q+ b7bQLgKaW/BlNOjUwz1+lZbSln3KIG/FnMUG0k26X9sL7+vnq4nSNKKDBBnO2mPsyXPJ 0U4LmkqFF0rXAlLkrQxQyLb8woMLS6/8vKHHK7dJnQJK5K9gPLuVvTbb3uzu68q0EgVx QCYQ== X-Gm-Message-State: AOAM533njnDUep/hmVn8rJrYo0zdkIrYONzPG50AK15yx2y0Gv8ZNLjw JgOAOqnBAWShFMYKlRx3ByLuJA== X-Google-Smtp-Source: ABdhPJwM7iK6/1F3wJCVEwHrXM5EY7yFEXNTq9+rYVmLYkrH92NPE2WM2GV8Ko1jMsiA6JIgJpsObQ== X-Received: by 2002:a05:622a:4d2:: with SMTP id q18mr28192174qtx.84.1635288133996; Tue, 26 Oct 2021 15:42:13 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-0044-6cb5-81ac-bb0c.res6.spectrum.com. [2603:6081:7b01:cbda:44:6cb5:81ac:bb0c]) by smtp.gmail.com with ESMTPSA id v22sm11004924qkf.79.2021.10.26.15.42.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Oct 2021 15:42:13 -0700 (PDT) Date: Tue, 26 Oct 2021 18:42:11 -0400 From: Tom Rini To: Heinrich Schuchardt Cc: Joe Hershberger , Wolfgang Denk , u-boot@lists.denx.de Subject: Re: [PATCH 1/1] env: superfluous check before free() Message-ID: <20211026224211.GP8284@bill-the-cat> References: <20211025224159.71282-1-heinrich.schuchardt@canonical.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="aTCJOP0qgkSGqHWA" Content-Disposition: inline In-Reply-To: <20211025224159.71282-1-heinrich.schuchardt@canonical.com> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --aTCJOP0qgkSGqHWA Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Oct 26, 2021 at 12:41:59AM +0200, Heinrich Schuchardt wrote: > Free() checks if its argument in NULL. There is no need for the caller to > do the same. >=20 > Signed-off-by: Heinrich Schuchardt Applied to u-boot/master, thanks! --=20 Tom --aTCJOP0qgkSGqHWA Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmF4hEMACgkQFHw5/5Y0 tywmlQwAththLBXagsmqzc09Db+aQZuhDS/ZgsJAItEWJh1FluhuLEwDTYWCYFCk Hc/fEquchjL+whwEnFeHR0PAY40DwabW2yxwJR/6cx8whKZBrmk/m5BQllMO2OB2 LvctcFrPvYpoUtq4LI8XSIffnoFWWjLmM+TtX95GtH8zLpeFsGJHd1tpB3ziOpos i9YGZb9Ak0duE9+qHRR69UwMqxYHoJYluDEReYZzq8uHVVO+Bs6vPwmka52DzWQk BokwtjS9dxyj/MHINilzgl4VYXBLlCoA5Z4CRdCukZXzzKRPqAcrWU7V5deOauRQ JVyL0zgaxVz7iUu2l19ALrZBufWLYKWvYlb0lR0Bir6lVq5IJO0IAFKArXm/Etb7 08lSBiRe19kOTcb0VjKRdprenu+PCqWBC5CVmyWLsN2N02Izo3WwwqD2lnjWQDYA 43lqTSlmLPmhD++O89hUanBsvh1ELdo0/kyRFjeRl8BYAY6lplKWWtwT/jtqlOTX 2nvn0BfV =fnUA -----END PGP SIGNATURE----- --aTCJOP0qgkSGqHWA--