From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B450C433F5 for ; Wed, 27 Oct 2021 19:12:31 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 53FA760C4B for ; Wed, 27 Oct 2021 19:12:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 53FA760C4B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 7E16283152; Wed, 27 Oct 2021 21:12:27 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="BThkzJeR"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id CC6D183230; Wed, 27 Oct 2021 21:12:24 +0200 (CEST) Received: from mail-qv1-xf2c.google.com (mail-qv1-xf2c.google.com [IPv6:2607:f8b0:4864:20::f2c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 3E78E82D6F for ; Wed, 27 Oct 2021 21:12:21 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qv1-xf2c.google.com with SMTP id gh1so2469014qvb.8 for ; Wed, 27 Oct 2021 12:12:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=8JDnDCgWnxsuksW5hyFuOUChrZjQPyNOPCUTeZ9lMUs=; b=BThkzJeRQbk8P+QNoWj2QakuuqcmkMLiThOEUrVW7xeEsxNAfc/GjvlQOTqBwMFI2P Cn6C84Of8nMiLskLBmRIgkWs0jp2OvUZs4HhZF8KvDve/ygTGiS/D1hubTRh9gQMxTbr rGNtJCMN4kuHcK7BkQsp6HfdkEVaaaGi7Y0Go= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=8JDnDCgWnxsuksW5hyFuOUChrZjQPyNOPCUTeZ9lMUs=; b=BifzmANURamL1T3zx4s64NTkxiREO4IN87Ht9zMR+JfqdfauCZnEFm0tXUeUKBW1JC yEvJm+F77rVznf+u+HziKVWntNz8cGzfWTZUHdJDSii01Z7UeLQJDLkfs57gniYjZY/A YRqpfNXghOUGz8oo5F2GsVB4DiBDrhaEptAI7VqkJajoeqLDusivn7gUDdir0o+0SdsL 3FPYWM6qXK5Wl6V8dw35wvOb73oHbRgGcpqK+iZdXzA7G+b2vAamnQBlpAebXsMAWvwo W6TjYkQmM6RdHX3bWONTMuDEYANGuiElPaWPgZTbuA7s0rT39FNz96qnbACSkDjfkSvf MQLQ== X-Gm-Message-State: AOAM533PMvJkCRG7M/hkO+MNoE+fs+Nnm61DkWYedIJh6jGVp4a6kwsq 6F2Cj0GR9XH1n6cbGpeM1IECHQ== X-Google-Smtp-Source: ABdhPJwe+yjrl/2C9BsFb2FnBTZAxlKZ9eC9wL6axFRI2nKXnaw5VPuzUB5vGKnU1XqLIVwLqh7B1A== X-Received: by 2002:a0c:8cc5:: with SMTP id q5mr30888197qvb.52.1635361940040; Wed, 27 Oct 2021 12:12:20 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-0044-6cb5-81ac-bb0c.res6.spectrum.com. [2603:6081:7b01:cbda:44:6cb5:81ac:bb0c]) by smtp.gmail.com with ESMTPSA id o6sm544360qta.2.2021.10.27.12.12.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Oct 2021 12:12:19 -0700 (PDT) Date: Wed, 27 Oct 2021 15:12:17 -0400 From: Tom Rini To: Ilias Apalodimas Cc: Simon Glass , U-Boot Mailing List , Mark Kettenis , Heinrich Schuchardt , Sean Anderson , Jerry Van Baren Subject: Re: [PATCH v5 26/26] fdt: Don't call board_fdt_blob_setup() without OF_BOARD Message-ID: <20211027191217.GJ8284@bill-the-cat> References: <20211026002344.405160-1-sjg@chromium.org> <20211026002344.405160-27-sjg@chromium.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="p14GW7TY4DvKqgVo" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --p14GW7TY4DvKqgVo Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Oct 27, 2021 at 10:17:05AM +0300, Ilias Apalodimas wrote: > Hi Simon, >=20 > On Tue, 26 Oct 2021 at 18:27, Simon Glass wrote: > > > > Hi Ilias, > > > > On Tue, 26 Oct 2021 at 07:56, Ilias Apalodimas > > wrote: > > > > > > Hi Simon, > > > > > > As I said here [1], this is moving on an entirely different direction= I had > > > in mind. I'd much prefer starting the discussions for a solution that > > > allows us to scale. > > > > I am missing the point here. Is there something in the plans that I > > don't know about? >=20 > I have some ideas, but haven't found time to code it and send patches yet. >=20 > > > > > FWIW I think the current code is still not clean for my taste. Commit > > > 3b595da441cf ("fdtdec: allow board to provide fdt for CONFIG_OF_SEPAR= ATE") > > > allowed this function to be used regardless of the config options. I= MHO we > > > should have 2 clear options: > > > - U-Boot provides the DTB > > > > Supported with: OF_SEPARATE > > > > > - It's somehow passed over to U-Boot > > > > Supported with: OF_SEPARATE + OF_BOARD >=20 > That's exactly what I don't personally like. In your example OF_BOARD > means "U-Boot has a DTB and here's a way to override it". In my head In some ways this is just highlighting a long standing problem of working with DTB. There's certainly been some places where splitting the data from the driver has helped. But in some other places, my goodness has it made the development cycle worse. Doing this on QEMU probably is on one of the most annoying cases too since yes, you start by dumping the dtb you would get, then iterating the dts outside of the rest of the scope of your build. In the kernel you can "make dtbs" at least and get things spit out. I'm just repeating over here that the development cycle of working on device trees is at times not great. --=20 Tom --p14GW7TY4DvKqgVo Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmF5pJEACgkQFHw5/5Y0 tyyyAgwAsJTN3Jiz17FVzqt+xfWib6Y+pFuQWrdGn3w8v3UCAF38f6UR+HFamX4P 6HkiK2xNUXJu0BueTyW3rtJhMh/da/lrojirbQQ2URNKWBrHlZCipzlSZA4wx168 xYhARP7ubA7troaNLPY/7UxEGjPsuYzsMn8JQ5dPrtZGCnE+o6eTWP2npnDNKMxJ UeBO8KBgD4hh7IcwqyzJyBqrleBsIaBb64YlZFZY04SVHH43EcVFVhcA3fCPq8MJ vmlcx3/WmA/0s0h8i2MFebIU/1BIvZZEoY2fj4IqRorm1iVUTN8HXwp0pLH/wIeq 9r4U7yFEt9SpzYnT8GRgK15Sz7Dj+SQ9r6GdntGnZAmwLp58CGNBSom097mmiwIR BpGrTxEysYDvdV+5IIYXFuebxDLoVKod570D9ZVsUAm4V3Cu/yVuRNPj7meizKwK ri4ZQJBXrWKDIBRG0SYCUySxGABdabJUNnM0Iy9wHYh++F8nMlkXD7QbfmlLHTSV KNGP2D4A =Dnw4 -----END PGP SIGNATURE----- --p14GW7TY4DvKqgVo--