From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7FD6CC433EF for ; Wed, 27 Oct 2021 17:39:51 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AAC0660E74 for ; Wed, 27 Oct 2021 17:39:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org AAC0660E74 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id AFA2282E48; Wed, 27 Oct 2021 19:39:48 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="ApTz1xOS"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id E91D082F03; Wed, 27 Oct 2021 19:39:46 +0200 (CEST) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 8440B82D6F for ; Wed, 27 Oct 2021 19:39:43 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=kabel@kernel.org Received: by mail.kernel.org (Postfix) with ESMTPSA id B417E60EFF; Wed, 27 Oct 2021 17:39:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1635356380; bh=Jtu3nhJOcbxKdr4qYVD3MgvrVDCg91G91xixOEpWNW4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=ApTz1xOSpA7jGtE1jJku2vpcy4iknDR82wKDa5OBptfQULOsnrki8c8NFC4j0F4FL iBa6iM3pW8LqZBEqyjFFC2VF9JsxUaIouwE1cT6L4PMtc9tZ0oM8hQk/3PRM3CwPTp RGk8wukeMFzEU+qycAUbRR1N0Ba1sae8D000YtIH/G2luH53UVDfGJ+2gZfQPoYMun R2tPCXm0jfJ1vyi9QfKK6t7glZRpyB7Hp4eVuVdSDJ5tONMe5aCGjQbwTQ6OEc6CAy q+f3B1qN+ukY0TO2KzhtBPX+jQ1at2mD3JG4W/7mXXS+osTbGZDC3dub8YkrRXuMUZ mu5PwsRAMltCA== Date: Wed, 27 Oct 2021 19:39:34 +0200 From: Marek =?UTF-8?B?QmVow7pu?= To: Roman Bacik Cc: Simon Glass , U-Boot Mailing List , Bharat Gooty , Aswath Govindraju , Bin Meng , Franck LENORMAND , Heinrich Schuchardt , Kory Maincent , Michal Simek , Patrick Delaunay , Peng Fan , Priyanka Jain , Rayagonda Kokatanur , Sean Anderson Subject: Re: [PATCH v3 2/2] cmd: brcm: netXtreme commands Message-ID: <20211027193934.4f537495@thinkpad> In-Reply-To: <1cd0979bebdbac34a2406f79a783a8fc@mail.gmail.com> References: <20211025234444.1237-1-roman.bacik@broadcom.com> <20211025164424.v3.2.I1edaad77041c1300213c307eef6741499504047@changeid> <20211026151742.42b0fcfa@thinkpad> <20211026175519.418d4864@thinkpad> <20211026184950.47bcd1af@thinkpad> <20211027183548.4ae716ed@thinkpad> <16973b36722d2787882203434568dd90@mail.gmail.com> <1cd0979bebdbac34a2406f79a783a8fc@mail.gmail.com> X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On Wed, 27 Oct 2021 10:02:41 -0700 Roman Bacik wrote: > Marek, Simon, > > Thank you very much for your comments. We will remove bnxt commands and will > probe bnxt driver each boot in the next version. > Thanks, Roman I think that the idea of not loading fw or initializing the controller during every boot, but only when needed, is quite reasonable. But it has to be done without the need to call custom commands, which the user may not know about. It has to be done in such a way that if the user calls for example the dhcp command, it will work. I think this could be achieved by creating a new DM driver flag, and wiring the DM and/or PCI code so that when this flag is set, the PCI subsystem won't probe the driver, only bind the driver. That way U-Boot will know that there is another ethernet controller which can be used by network commands when the `ethact` variable is set to point to that controller. Marek