From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC8B6C433EF for ; Wed, 27 Oct 2021 21:44:19 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CD188610A6 for ; Wed, 27 Oct 2021 21:44:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org CD188610A6 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id CA6C082D6F; Wed, 27 Oct 2021 23:44:16 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="hUBckIEG"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 3DA0F82FE7; Wed, 27 Oct 2021 23:44:15 +0200 (CEST) Received: from mail-qk1-x734.google.com (mail-qk1-x734.google.com [IPv6:2607:f8b0:4864:20::734]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id C2EE380D1C for ; Wed, 27 Oct 2021 23:44:10 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qk1-x734.google.com with SMTP id i9so3403101qki.3 for ; Wed, 27 Oct 2021 14:44:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=w+hi0NnniesxZK/QYhLv1XsYOVZImFcwECWloeb731M=; b=hUBckIEGcXZnSfB1o9qDXnY5jTywdzzFETLXrsdjpxOOjMweMG1lo8znWB4iE5+KQc PVACueyAVubJE5SjI4OZTn5wmk2pn+f6kTq4yClnIoyiMB+RwYXyXpHtQOU3LFt2+c9u QBo6rLVytGRxcOavO2S+DOPnz9e4BEGUH+5Vo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=w+hi0NnniesxZK/QYhLv1XsYOVZImFcwECWloeb731M=; b=t8VP4SErUnOGU8vGK7GZ+dNJgFqKqO+u/XyoOFLhC+IZb7yKq7hg4z6utBUp3jMo1v WnK1w++X3TK0LHIfSd/f9QF1dJlsKTMQ8eGwXTCnn7HbCJRgi2R8woWmAmsUWSRG4v15 i71E5HHCB8PnwCYyRDteh+JQ13m+5SOo8L3r4vbdtXqMJPczf0AI98a0DSYFJ9fdhk5q uLD9yAuzGKtf85Lg+5HoEQXhjsR6FKI0F1Dyv1BOuYcaoD0dO/E4KqdEbojlRKBhT9rt 19eF6D5msNmExM1oL/xMUmnk3nMfFMbKeSxCUrrWhpRNLvJPUrhCNkjzxFpSnEn7tCMw dxXw== X-Gm-Message-State: AOAM5306X5xvoglGsH200G+4kCtAVxiFtz2vjwreapCv4hkrbdxzWmRP KKo5FX0efg2w8kz5XkENj10S3Q== X-Google-Smtp-Source: ABdhPJxupSZnnNFmXhY/ebOpScQ1ELscGXYiuodKJaDKiU6/11qOrOyUZHJ41WIWZslEu8bVcFnFvA== X-Received: by 2002:a37:a87:: with SMTP id 129mr330013qkk.107.1635371049589; Wed, 27 Oct 2021 14:44:09 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-0044-6cb5-81ac-bb0c.res6.spectrum.com. [2603:6081:7b01:cbda:44:6cb5:81ac:bb0c]) by smtp.gmail.com with ESMTPSA id t64sm755390qkd.71.2021.10.27.14.44.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Oct 2021 14:44:08 -0700 (PDT) Date: Wed, 27 Oct 2021 17:44:06 -0400 From: Tom Rini To: =?iso-8859-1?Q?Fran=E7ois?= Ozog Cc: Heinrich Schuchardt , Ilias Apalodimas , Jerry Van Baren , Mark Kettenis , Sean Anderson , Simon Glass , U-Boot Mailing List Subject: Re: [PATCH v5 26/26] fdt: Don't call board_fdt_blob_setup() without OF_BOARD Message-ID: <20211027214406.GP8284@bill-the-cat> References: <20211026002344.405160-1-sjg@chromium.org> <20211026002344.405160-27-sjg@chromium.org> <20211027191217.GJ8284@bill-the-cat> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="/7YWha3R2g8GjXQ0" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --/7YWha3R2g8GjXQ0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Oct 27, 2021 at 11:33:53PM +0200, Fran=E7ois Ozog wrote: > Hi Tom >=20 > Le mer. 27 oct. 2021 =E0 21:12, Tom Rini a =E9crit : >=20 > > On Wed, Oct 27, 2021 at 10:17:05AM +0300, Ilias Apalodimas wrote: > > > Hi Simon, > > > > > > On Tue, 26 Oct 2021 at 18:27, Simon Glass wrote: > > > > > > > > Hi Ilias, > > > > > > > > On Tue, 26 Oct 2021 at 07:56, Ilias Apalodimas > > > > wrote: > > > > > > > > > > Hi Simon, > > > > > > > > > > As I said here [1], this is moving on an entirely different > > direction I had > > > > > in mind. I'd much prefer starting the discussions for a solution = that > > > > > allows us to scale. > > > > > > > > I am missing the point here. Is there something in the plans that I > > > > don't know about? > > > > > > I have some ideas, but haven't found time to code it and send patches > > yet. > > > > > > > > > > > > FWIW I think the current code is still not clean for my taste. > > Commit > > > > > 3b595da441cf ("fdtdec: allow board to provide fdt for > > CONFIG_OF_SEPARATE") > > > > > allowed this function to be used regardless of the config options. > > IMHO we > > > > > should have 2 clear options: > > > > > - U-Boot provides the DTB > > > > > > > > Supported with: OF_SEPARATE > > > > > > > > > - It's somehow passed over to U-Boot > > > > > > > > Supported with: OF_SEPARATE + OF_BOARD > > > > > > That's exactly what I don't personally like. In your example OF_BOARD > > > means "U-Boot has a DTB and here's a way to override it". In my head > > > > In some ways this is just highlighting a long standing problem of > > working with DTB. There's certainly been some places where splitting > > the data from the driver has helped. But in some other places, my > > goodness has it made the development cycle worse. Doing this on QEMU > > probably is on one of the most annoying cases too since yes, you start > > by dumping the dtb you would get, then iterating the dts outside of the > > rest of the scope of your build. In the kernel you can "make dtbs" at > > least and get things spit out. I'm just repeating over here that the > > development cycle of working on device trees is at times not great. >=20 > In general you do this only once, unless you use the virt machine and in > that case there is no documentation about DT generated for each device > added on the command line. > I had lots of difficulties getting all UART possibilities: virtio <1.0, > 1.0,1.1; mmio or pci. > But once you get the command line, the dTB is fixed. > Of course it would be better to get Qemu document DT generation of its > devices. In a lot of ways QEMU isn't even the real problem, unless it's applying rand() to some parts of where devices end up, etc. The cycle there isn't any worse than where the device tree resides in hardware. The device tree development cycle is a pain. QEMU is actually not so bad in this regard really since it's just dumpdtb and pass back the modified one, it takes care of then ensuring it's in the correct spot. The part where every blob must be in the right place is another part of that horror show that binman and fconf both try and address. --=20 Tom --/7YWha3R2g8GjXQ0 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmF5yCMACgkQFHw5/5Y0 tyxwPwv+KIEkJ1OO5RW0BCQUVon6FTLT4jm4dwGYm2y/hETsx7FY+mhGz3ZLKg/2 4bW5KgeKl5X/YeTlHHQpuocRUcUxR1zH0FZfH8IJkcqpxGGAk4c5nIom6ghla2vO dWDr0D/DAdrBOu2cC7AN3OIZJy/ziY/XKDgzrKHq6xfHudSQggtMSdDSygIplaW2 2yjb4GRKVZzm+9OwcbbZ67/bp6qgAFGUytxJZte8/PsLGMc6pNRN8r59Dd86t0Sh ZjmgZ8ol1cGcihu63F45Yl6dEmWcxEOwtxB4a/HC5jLu1NRCL2f2wUGDeVNThv1Q JFl0oYVQQ2x/6IJrn6K0rjsDTfT3D7+v+QyZ/THY5XnNT35MCYt2v9vwTV1s+HUi XffVrzLIq4u6Qr6PJUnMXHbyrhUscNL6/Db2RUPOyDL1sdgQOqJBNkS2lwRsKfF/ Pxy5hrY8uYOwaj0QW+VQLb3q5u1VzUswGJvFx6CEcfAY4rl15hNOZrMazpABLOQ1 8ev4nzw9 =EGjk -----END PGP SIGNATURE----- --/7YWha3R2g8GjXQ0--