public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: "Marek Behún" <marek.behun@nic.cz>
To: Stefan Roese <sr@denx.de>
Cc: u-boot@lists.denx.de
Subject: kirkwood stack size
Date: Thu, 28 Oct 2021 00:07:53 +0200	[thread overview]
Message-ID: <20211028000753.45cbb531@thinkpad> (raw)

Hello Stefan,

do you have some ARM Kirkwood board? I am working on some env patches,
because the code in the env/ directory is a pain in the ass of old
relics, and Kirkwood is the only platform using the eeprom environment
driver.

I would like to ask about Kirkwood stack size.

In arch/arm/mach-kirkwood/include/mach/config.h it says

/* Kirkwood has 2k of Security SRAM, use it for SP */
#define CONFIG_SYS_INIT_SP_ADDR		0xC8012000

So if I understand correctly, Kirkwood has only 2k of init stack.

But the env_eeprom_load() method in env/eeprom.c allocates a
CONFIG_ENV_SIZE bytes long array for environment, and CONFIG_ENV_SIZE
is 2k.

Is the init stack changed to another stack before environment is loaded?
I couldn't find code which would do that. As far as I am able to
determine, this 2k long init stack is used, and this means that the
code in env/eeprom.c is wrong, since it allocates below stack space.

Maybe no one used newer U-Boot on Kirkwood for a long time and this was
not noticed? Should we remove support for Kirkwood?

Marek

             reply	other threads:[~2021-10-27 22:08 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-27 22:07 Marek Behún [this message]
2021-10-28  6:35 ` kirkwood stack size Stefan Roese
  -- strict thread matches above, loose matches on Subject: below --
2021-10-27 23:06 Tony Dinh
2021-10-28  1:28 ` Marek Behún
2021-10-28  1:50   ` Tony Dinh
2021-10-28  6:39   ` Stefan Roese
2021-10-28  9:37     ` Holger Brunck
2021-10-28 14:10       ` Stefan Roese
2021-10-28 15:30         ` Marek Behún

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211028000753.45cbb531@thinkpad \
    --to=marek.behun@nic.cz \
    --cc=sr@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox