From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4BA5C433EF for ; Thu, 28 Oct 2021 03:28:42 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D558F60EC0 for ; Thu, 28 Oct 2021 03:28:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org D558F60EC0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id CF65D831BA; Thu, 28 Oct 2021 05:28:29 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="Ab2eGC+8"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 4665E83152; Thu, 28 Oct 2021 05:28:25 +0200 (CEST) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 41B3D83270 for ; Thu, 28 Oct 2021 05:28:18 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=kabel@kernel.org Received: by mail.kernel.org (Postfix) with ESMTPSA id B7A7561179; Thu, 28 Oct 2021 03:28:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1635391696; bh=UExyqMRT/aTOKPXKKIv35RpCrFNI338AjumH4jYf0cw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Ab2eGC+8lHytO9MMyqemMGG8KfIkvuWzm9ZAXeTG+jwedLa3kFCya6NV7N1/pZkr5 Z5LImWY0nctieuYtgt6afgSQaJFeneCef5oTCpQnxaWrT5ifNCOmDjyV6XKHI0DV6+ Q/USgvvf5hBtyuQfEMQArzcAWCrCTE/K6HGLFMfal1Ke/TXp1DT99TAKqaRTGG4DX/ fr4v0tRNh1nJpmamqWiCpdKw/THUcvaCQmxzJ1P+zXB4zb9mNIQlRc4lAX/vxpacR+ c1QNUmEdUDjR009tXazo7dmyDkMJJimGqMM9pihNM+kMi9aQ7H4Ak55vAjl3rTC7nY 4kRDZmmHOOKmg== From: =?UTF-8?q?Marek=20Beh=C3=BAn?= To: Simon Glass , Stefan Roese , =?UTF-8?q?Pali=20Roh=C3=A1r?= Cc: u-boot@lists.denx.de, =?UTF-8?q?Marek=20Beh=C3=BAn?= Subject: [PATCH 2/5] env: Fix env_get() when returning empty string using env_get_f() Date: Thu, 28 Oct 2021 05:28:07 +0200 Message-Id: <20211028032810.18146-3-kabel@kernel.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20211028032810.18146-1-kabel@kernel.org> References: <20211028032810.18146-1-kabel@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean From: Marek Behún The env_get_f() function returns -1 on failure. Returning 0 means that the variable exists, and is empty string. Signed-off-by: Marek Behún --- env/common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/env/common.c b/env/common.c index 2aa23545ba..757c5f9ecd 100644 --- a/env/common.c +++ b/env/common.c @@ -125,7 +125,7 @@ char *env_get(const char *name) } /* restricted capabilities before import */ - if (env_get_f(name, (char *)(gd->env_buf), sizeof(gd->env_buf)) > 0) + if (env_get_f(name, (char *)(gd->env_buf), sizeof(gd->env_buf)) >= 0) return (char *)(gd->env_buf); return NULL; -- 2.32.0