From: Tom Rini <trini@konsulko.com>
To: Marc Zyngier <maz@kernel.org>
Cc: Michael Walle <michael@walle.cc>,
u-boot@lists.denx.de, Vladimir Oltean <vladimir.oltean@nxp.com>,
Hou Zhiqiang <Zhiqiang.Hou@nxp.com>,
Bharat Gooty <bharat.gooty@broadcom.com>,
Rayagonda Kokatanur <rayagonda.kokatanur@broadcom.com>,
Simon Glass <sjg@chromium.org>,
Priyanka Jain <priyanka.jain@nxp.com>
Subject: Re: [PATCH 2/2] Revert "arch: arm: use dt and UCLASS_SYSCON to get gic lpi details"
Date: Thu, 28 Oct 2021 17:35:02 -0400 [thread overview]
Message-ID: <20211028213502.GL8284@bill-the-cat> (raw)
In-Reply-To: <87k0hwua9m.wl-maz@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 1450 bytes --]
On Thu, Oct 28, 2021 at 10:09:25PM +0100, Marc Zyngier wrote:
> On Wed, 27 Oct 2021 17:54:54 +0100,
> Michael Walle <michael@walle.cc> wrote:
> >
> > Stop using the device tree as a source for ad-hoc information.
> >
> > This reverts commit 2ae7adc659f7fca9ea65df4318e5bca2b8274310.
> >
> > Signed-off-by: Michael Walle <michael@walle.cc>
> > ---
> > arch/arm/Kconfig | 2 -
> > arch/arm/cpu/armv8/fsl-layerscape/soc.c | 27 +++++++++-
> > arch/arm/include/asm/gic-v3.h | 4 +-
> > arch/arm/lib/gic-v3-its.c | 66 +++----------------------
> > 4 files changed, 36 insertions(+), 63 deletions(-)
> >
> > diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> > index 02f8306f15..86c1ebde05 100644
> > --- a/arch/arm/Kconfig
> > +++ b/arch/arm/Kconfig
> > @@ -82,8 +82,6 @@ config GICV3
> >
> > config GIC_V3_ITS
> > bool "ARM GICV3 ITS"
> > - select REGMAP
> > - select SYSCON
> > select IRQ
> > help
> > ARM GICV3 Interrupt translation service (ITS).
> > diff --git a/arch/arm/cpu/armv8/fsl-layerscape/soc.c b/arch/arm/cpu/armv8/fsl-layerscape/soc.c
> > index c0e100d21c..a08ed3f544 100644
> > --- a/arch/arm/cpu/armv8/fsl-layerscape/soc.c
> > +++ b/arch/arm/cpu/armv8/fsl-layerscape/soc.c
>
> Why is this FSL specific?
Note that this is a fairly direct revert. Based on your comments a
follow-up patch to correct things is in order.
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
next prev parent reply other threads:[~2021-10-28 21:35 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-27 16:54 [PATCH 0/2] arch: arm: gic-v3-its: stop abusing the device tree Michael Walle
2021-10-27 16:54 ` [PATCH 1/2] Revert "arm64: Layerscape: Survive LPI one-way reset workaround" Michael Walle
2021-10-28 21:11 ` Marc Zyngier
2021-10-31 16:23 ` Tom Rini
2021-10-27 16:54 ` [PATCH 2/2] Revert "arch: arm: use dt and UCLASS_SYSCON to get gic lpi details" Michael Walle
2021-10-28 21:09 ` Marc Zyngier
2021-10-28 21:35 ` Tom Rini [this message]
2021-10-29 11:49 ` Michael Walle
2021-10-29 12:00 ` Marc Zyngier
2021-10-31 16:45 ` Z.Q. Hou
2021-10-31 16:58 ` Michael Walle
2021-11-01 9:38 ` Marc Zyngier
2021-10-31 16:24 ` Tom Rini
2021-10-28 9:01 ` [PATCH 0/2] arch: arm: gic-v3-its: stop abusing the device tree Marc Zyngier
2021-10-28 9:20 ` Bharat Gooty
2021-10-28 9:49 ` Marc Zyngier
2021-10-28 10:27 ` Bharat Gooty
2021-10-28 14:39 ` Marc Zyngier
2021-10-28 11:21 ` Michael Walle
2021-10-28 11:35 ` Bharat Gooty
2021-10-28 12:09 ` Michael Walle
2021-10-28 14:42 ` Marc Zyngier
2021-10-28 12:31 ` Tom Rini
2021-10-28 13:38 ` Marc Zyngier
2021-10-28 13:51 ` Tom Rini
2021-10-28 22:36 ` Simon Glass
2021-10-29 11:54 ` Michael Walle
2021-10-29 21:17 ` Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211028213502.GL8284@bill-the-cat \
--to=trini@konsulko.com \
--cc=Zhiqiang.Hou@nxp.com \
--cc=bharat.gooty@broadcom.com \
--cc=maz@kernel.org \
--cc=michael@walle.cc \
--cc=priyanka.jain@nxp.com \
--cc=rayagonda.kokatanur@broadcom.com \
--cc=sjg@chromium.org \
--cc=u-boot@lists.denx.de \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox