From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 276F6C433FE for ; Thu, 28 Oct 2021 21:35:16 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3C64660FF2 for ; Thu, 28 Oct 2021 21:35:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 3C64660FF2 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id C2E9E827C5; Thu, 28 Oct 2021 23:35:12 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="tbTcBWBG"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 4A6B082B45; Thu, 28 Oct 2021 23:35:10 +0200 (CEST) Received: from mail-qv1-xf2a.google.com (mail-qv1-xf2a.google.com [IPv6:2607:f8b0:4864:20::f2a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 982DF80234 for ; Thu, 28 Oct 2021 23:35:06 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qv1-xf2a.google.com with SMTP id t1so5059654qvb.1 for ; Thu, 28 Oct 2021 14:35:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=k12Afs2Edz9qB87SD0imFuXyQCMxbWI5mvK9CdjPmGU=; b=tbTcBWBGoqcmb5CEryLIW7UbMCDIc9v2uvOupHY+vl6NTJNltlwAMB7iP2BtL+adxS TL4poUcDvuvCT80tdKcAolh+uK4OChQRtGWyRVv4ayoMcXd6SPxlzyWOcPtLC3WjZalB eWrTJ9BJnyskRPQ/h0qt2H+nyZ7qK4ZDbag1E= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=k12Afs2Edz9qB87SD0imFuXyQCMxbWI5mvK9CdjPmGU=; b=g5+1sbLh6h8VOLSUUJjAgUc7tjvdbCfPLu2lPiue/ZgQnL2kbwC2U0E6pQjsPCnINz vJPnLfUhC1Eu8cki069ISNhFyNeEM8IYOV6Wnapeb8HWYOfAh6/SlMAuDYW/XTC7pfSs tV/x3t9EmlyeoBK9o4VX44j+lH/+IdHF0m25z4g+8oj3islyKp7EfPfbRAAGWtTzVNU9 KValJFAFwrNEYlQzNaG3mkj0XpG5o5M7RIbJkvdwFcrnynIRm4/aXCrawn2rRWjQJA0f 6TmmIukRbTUcK757NRFkRmBgh2jlYQXR6CMTHVgTGUOQQINdBBm/mSpX8wHDZPo9Td14 kzpA== X-Gm-Message-State: AOAM531LbcJlDt/tRdyyXOiBLA47Pt/7w28HI7di2wL9wVvsHiZ2X6xk T9ezBXII0tjeor7b6WZ/yJUBfw== X-Google-Smtp-Source: ABdhPJwzsWk+wTVmGef9eiOj2Ier/reX3O9aqJlRCxAib2OuAcGpRO114MLGYv/Kg8qGwsyqBsKewQ== X-Received: by 2002:ad4:5dee:: with SMTP id jn14mr6769518qvb.53.1635456905361; Thu, 28 Oct 2021 14:35:05 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-015b-1704-43dd-8832.res6.spectrum.com. [2603:6081:7b01:cbda:15b:1704:43dd:8832]) by smtp.gmail.com with ESMTPSA id w7sm3009651qkp.129.2021.10.28.14.35.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Oct 2021 14:35:04 -0700 (PDT) Date: Thu, 28 Oct 2021 17:35:02 -0400 From: Tom Rini To: Marc Zyngier Cc: Michael Walle , u-boot@lists.denx.de, Vladimir Oltean , Hou Zhiqiang , Bharat Gooty , Rayagonda Kokatanur , Simon Glass , Priyanka Jain Subject: Re: [PATCH 2/2] Revert "arch: arm: use dt and UCLASS_SYSCON to get gic lpi details" Message-ID: <20211028213502.GL8284@bill-the-cat> References: <20211027165454.1501398-1-michael@walle.cc> <20211027165454.1501398-3-michael@walle.cc> <87k0hwua9m.wl-maz@kernel.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="MbiMhNjKwMZ0Kn0G" Content-Disposition: inline In-Reply-To: <87k0hwua9m.wl-maz@kernel.org> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --MbiMhNjKwMZ0Kn0G Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Oct 28, 2021 at 10:09:25PM +0100, Marc Zyngier wrote: > On Wed, 27 Oct 2021 17:54:54 +0100, > Michael Walle wrote: > >=20 > > Stop using the device tree as a source for ad-hoc information. > >=20 > > This reverts commit 2ae7adc659f7fca9ea65df4318e5bca2b8274310. > >=20 > > Signed-off-by: Michael Walle > > --- > > arch/arm/Kconfig | 2 - > > arch/arm/cpu/armv8/fsl-layerscape/soc.c | 27 +++++++++- > > arch/arm/include/asm/gic-v3.h | 4 +- > > arch/arm/lib/gic-v3-its.c | 66 +++---------------------- > > 4 files changed, 36 insertions(+), 63 deletions(-) > >=20 > > diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig > > index 02f8306f15..86c1ebde05 100644 > > --- a/arch/arm/Kconfig > > +++ b/arch/arm/Kconfig > > @@ -82,8 +82,6 @@ config GICV3 > > =20 > > config GIC_V3_ITS > > bool "ARM GICV3 ITS" > > - select REGMAP > > - select SYSCON > > select IRQ > > help > > ARM GICV3 Interrupt translation service (ITS). > > diff --git a/arch/arm/cpu/armv8/fsl-layerscape/soc.c b/arch/arm/cpu/arm= v8/fsl-layerscape/soc.c > > index c0e100d21c..a08ed3f544 100644 > > --- a/arch/arm/cpu/armv8/fsl-layerscape/soc.c > > +++ b/arch/arm/cpu/armv8/fsl-layerscape/soc.c >=20 > Why is this FSL specific? Note that this is a fairly direct revert. Based on your comments a follow-up patch to correct things is in order. --=20 Tom --MbiMhNjKwMZ0Kn0G Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmF7F38ACgkQFHw5/5Y0 tyxqpAv/fMHvybMsSLTxVKPm2AE6iSOVt2EOSJSEO13bpBLwfyQ0izL/56WofPKM zzyVGRzqAl/iwl3gMlnKwYlKoNFhQ5P8LYsY07VSuY0Z4lbTQ+i97q2wPLcZG3Xt 2MBP/wSjUlBpY3BXu2ytSma6GLaBaUoTG6Um/fpa96N1COtpXFId7x+8X/9jfJ4i xH3szqZOLWOkstMvUTvkZ+xAUFDqZo+G2jN71c7z/1tumAxISmm3f27T5illqYyf vaSzsxzfvYmclEtEiYM4OdfIgt1YBbQYBkc6EzkKNcIP/RHl0lG+7A5fxmOeBRFd JrBrXn6pc+M73NyGa9RHNqqz1/CEsSdIgsrVXBU2iPzIqqMT4N9URmdbeFnxc4fC 1LeaqRCo+1LLQTSycGmyU8sNS+hJXEEKe9cCtEumHUiOoowchgrK/pBopadOCey1 BoHZaqGMrcW3Tu/aj2SSGKuUaheowsJhxcTteEeVSbH0bGDF7SsJy1rRUZ8VhC8G YRxi5j2R =2nl0 -----END PGP SIGNATURE----- --MbiMhNjKwMZ0Kn0G--