From: "Marek Behún" <marek.behun@nic.cz>
To: Roman Bacik <roman.bacik@broadcom.com>
Cc: U-Boot Mailing List <u-boot@lists.denx.de>,
Bharat Gooty <bharat.gooty@broadcom.com>,
Joe Hershberger <joe.hershberger@ni.com>,
Ramon Fried <rfried.dev@gmail.com>,
pali@kernel.org
Subject: Re: [PATCH v4 1/2] net: brcm: netXtreme driver
Date: Sun, 31 Oct 2021 11:56:19 +0100 [thread overview]
Message-ID: <20211031115619.55ae8b7a@thinkpad> (raw)
In-Reply-To: <CAGQAs7zi_99W97tq=ijpM_7r0vP11pqh_GppeB6uzXQebcb3xw@mail.gmail.com>
On Sat, 30 Oct 2021 08:48:05 -0700
Roman Bacik <roman.bacik@broadcom.com> wrote:
> The mac address can be read from bp only after bnxt_bring_chip is
> called, which is after read_rom_hwaddr is called. Theoretically we can
> call bnxt_bring_chip in bind or in read_rom_hwaddr and then one can
> use this method if desired.
How long does bnxt_bring_chip() take? In milliseconds? If it isn't
extremely long, I think it could be called from read_rom_hwaddr...
>> eth_env_set_enetaddr_by_index()
> We can change and use this method.
Pls do, and drop the env deletion.
Marek
next prev parent reply other threads:[~2021-10-31 10:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-28 23:29 [PATCH v4 1/2] net: brcm: netXtreme driver Roman Bacik
2021-10-28 23:29 ` [PATCH v4 2/2] board: brcm-ns3: Load netXtreme firmware Roman Bacik
2021-10-30 15:00 ` [PATCH v4 1/2] net: brcm: netXtreme driver Marek Behún
2021-10-30 15:48 ` Roman Bacik
2021-10-31 10:56 ` Marek Behún [this message]
2021-11-01 20:14 ` Roman Bacik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211031115619.55ae8b7a@thinkpad \
--to=marek.behun@nic.cz \
--cc=bharat.gooty@broadcom.com \
--cc=joe.hershberger@ni.com \
--cc=pali@kernel.org \
--cc=rfried.dev@gmail.com \
--cc=roman.bacik@broadcom.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox