From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE98BC433EF for ; Sun, 31 Oct 2021 10:56:29 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C11ED60FC1 for ; Sun, 31 Oct 2021 10:56:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org C11ED60FC1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nic.cz Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 14CF082BC0; Sun, 31 Oct 2021 11:56:26 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=nic.cz Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; secure) header.d=nic.cz header.i=@nic.cz header.b="VE8EWgYr"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 1ED3483246; Sun, 31 Oct 2021 11:56:24 +0100 (CET) Received: from mail.nic.cz (mail.nic.cz [217.31.204.67]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id E804A815A8 for ; Sun, 31 Oct 2021 11:56:20 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=nic.cz Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=marek.behun@nic.cz Received: from thinkpad (unknown [172.20.6.87]) by mail.nic.cz (Postfix) with ESMTPSA id 44BA913FB35; Sun, 31 Oct 2021 11:56:20 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=nic.cz; s=default; t=1635677780; bh=Kln5vyaMDbyxnxsfBkD3aI3d32Zw71+HfBqrWDW7LEE=; h=Date:From:To; b=VE8EWgYrUSXaPFHkRQv99e9pZS2vmIhekoqWSWK7YBQJO3z/IYaJjdslpXqvyiamu uIWfaCgV0p3H8pg7vpRmhIoSZJaVn6AAYHHBk1rnH2ftBjIusAexxan2ReNqQbRDxW 8T3acSaa5lj8P5evSASW7OkDT69651G+bvZa5Jcc= Date: Sun, 31 Oct 2021 11:56:19 +0100 From: Marek =?UTF-8?B?QmVow7pu?= To: Roman Bacik Cc: U-Boot Mailing List , Bharat Gooty , Joe Hershberger , Ramon Fried , pali@kernel.org Subject: Re: [PATCH v4 1/2] net: brcm: netXtreme driver Message-ID: <20211031115619.55ae8b7a@thinkpad> In-Reply-To: References: <20211028232929.16607-1-roman.bacik@broadcom.com> <20211030170003.20219284@thinkpad> X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On Sat, 30 Oct 2021 08:48:05 -0700 Roman Bacik wrote: > The mac address can be read from bp only after bnxt_bring_chip is > called, which is after read_rom_hwaddr is called. Theoretically we can > call bnxt_bring_chip in bind or in read_rom_hwaddr and then one can > use this method if desired. How long does bnxt_bring_chip() take? In milliseconds? If it isn't extremely long, I think it could be called from read_rom_hwaddr... >> eth_env_set_enetaddr_by_index() > We can change and use this method. Pls do, and drop the env deletion. Marek