From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5FDE2C433EF for ; Wed, 3 Nov 2021 14:40:16 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A666E60E98 for ; Wed, 3 Nov 2021 14:40:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org A666E60E98 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 315A78363F; Wed, 3 Nov 2021 15:40:12 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="CjM7Gmqb"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id B83C583641; Wed, 3 Nov 2021 15:40:10 +0100 (CET) Received: from mail-qv1-xf2c.google.com (mail-qv1-xf2c.google.com [IPv6:2607:f8b0:4864:20::f2c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id AD4AB8363D for ; Wed, 3 Nov 2021 15:40:02 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qv1-xf2c.google.com with SMTP id gh1so3093331qvb.8 for ; Wed, 03 Nov 2021 07:40:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=IyNzSxMhj534SNMoS4+neuy1vH/BHzA/rbk3CEGN6Fo=; b=CjM7GmqbWPgr2agP7rV7UjY5VyG99ojYlALsJvfZ9MEyPoxy6JTFV5YNiMfYaouAnN KBlsAWMhWT9An4MVVGtsoEXBSAjg77pXVNl9+x1ZOnnzb3gsvjjLvS91TPZH7bVSeXIK 7RLcAGU+HMLokjdpU7MSnFikQORXilsWd9EHc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=IyNzSxMhj534SNMoS4+neuy1vH/BHzA/rbk3CEGN6Fo=; b=Kv2SAkyGIsW6VdrhIoDJ7CZzyzSNIsb0n9KgARQ/EHTUKYX8BFLn3pki6DY/dbpsYA EOwRlXWUh+P/b9IoQj+wNKhj6GIIvCSuKxdCN8DEtOqXuKJnKFgdjz2aD+uxaY+2Hjjm BmfxZ3Bp8qbccLw+77rRo5XhYzl4idlBbtEoZqQNYJSwX+KDHpOEYZSOSTc2Rubz0Jxa b+TC4BjJPzpc1ZGl5mYxfJyZQqqihkJnF+culyeP0HG8v4HDK7S2eXY/9X16X+YaM5C7 +VbfHEmGuJ0o/NS4X9XRSCUYv/J1DwNCgi76uGvcNzHi2vjaIgt+jg6wrSc4GJu9tPey dwIg== X-Gm-Message-State: AOAM532ByuN88YSJ7HkIQrDE62rwU7t4gViq5yMGJKz977YcPFy6i156 I50CxdPKsQ/P6dMBi9tBMRlheA== X-Google-Smtp-Source: ABdhPJx5gjgOOxz+KJ+bG+e0MOpeYpN+NEoNsnpLyebsFew3+rcczv19oTS0muougVdMkUgUcrmmBA== X-Received: by 2002:ad4:5747:: with SMTP id q7mr35985762qvx.19.1635950401425; Wed, 03 Nov 2021 07:40:01 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-e929-65d4-8978-cf6f.res6.spectrum.com. [2603:6081:7b01:cbda:e929:65d4:8978:cf6f]) by smtp.gmail.com with ESMTPSA id bk7sm1718201qkb.72.2021.11.03.07.40.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Nov 2021 07:40:00 -0700 (PDT) Date: Wed, 3 Nov 2021 10:39:58 -0400 From: Tom Rini To: Simon Glass Cc: =?iso-8859-1?Q?Fran=E7ois?= Ozog , Albert Aribaud , Heinrich Schuchardt , Ilias Apalodimas , Mark Kettenis , Peter Maydell , QEMU Developers , Sean Anderson , Tuomas Tynkkynen , U-Boot Mailing List Subject: Re: [PATCH v5 06/26] arm: qemu: Add a devicetree file for qemu_arm64 Message-ID: <20211103143958.GY24579@bill-the-cat> References: <20211026002344.405160-1-sjg@chromium.org> <20211026002344.405160-7-sjg@chromium.org> <20211102165718.GR24579@bill-the-cat> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="bO/C3H35Ok2OdENj" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --bO/C3H35Ok2OdENj Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Nov 02, 2021 at 07:32:54PM -0600, Simon Glass wrote: > Hi Tom, >=20 > On Tue, 2 Nov 2021 at 10:57, Tom Rini wrote: > > > > On Tue, Nov 02, 2021 at 08:59:45AM -0600, Simon Glass wrote: > > > Hi Fran=E7ois, > > > > > > On Mon, 1 Nov 2021 at 11:33, Fran=E7ois Ozog wrote: > > > > > > > > Hi Simon > > > > > > > > Le lun. 1 nov. 2021 =E0 17:58, Simon Glass a =E9= crit : > > > >> > > > >> Hi Peter, > > > >> > > > >> On Mon, 1 Nov 2021 at 04:48, Peter Maydell wrote: > > > >> > > > > >> > On Tue, 26 Oct 2021 at 01:33, Simon Glass wro= te: > > > >> > > > > > >> > > Add this file, generated from qemu, so there is a reference de= vicetree > > > >> > > in the U-Boot tree. > > > >> > > > > > >> > > Signed-off-by: Simon Glass > > > >> > > > > >> > Note that the dtb you get from QEMU is only guaranteed to work i= f: > > > >> > 1) you run it on the exact same QEMU version you generated it w= ith > > > >> > 2) you pass QEMU the exact same command line arguments you used > > > >> > when you generated it > > > >> > > > >> Yes, I certainly understand that. In general this is not safe, but= in > > > >> practice it works well enough for development and CI. > > > > > > > > You recognize that you hijack a product directory with development = hack facility. There is a test directory to keep things clear. There can be= a dev-dts or something similar for Dev time tools. > > > > I have only seen push back on those fake dts files in the dts direc= tory: I guess that unless someone strongly favors a continuation of the dis= cussion, you may consider re-shaping the proposal to address concerns. > > > > > > As stated previously, I would like to have at least a sample DT > > > in-tree for all boards. I cannot see another way to get the Kconfig > > > > What's the point of having a sample when it's not going to always be > > correct or may be actively wrong and we can tell interested developers / > > users how to get the correct DTB/DTS to examine? > > > > > options in line. If we are able to put these files somewhere else in > > > the future and get them out of U-Boot, with perhaps just an overlay > > > for development purposes, I'd be keen to see it. But for now, this is > > > where we are, I believe. > > > > > > In this particular case, this is not just a dev hack. It is also for > > > CI tests which need to use a devicetree. See for example here: > > > > > > https://patchwork.ozlabs.org/project/uboot/patch/20211101011734.16147= 81-15-sjg@chromium.org/ > > > https://patchwork.ozlabs.org/project/uboot/patch/20211101011734.16147= 81-24-sjg@chromium.org/ > > > > This example would probably be better done on vexpress_ca9x4 where we do > > test in CI via QEMU but do not need to modify a device tree that is > > passed on to us, we already control the source of truth DTB in this > > case. >=20 > But that board: >=20 > - uses OF_EMBED, which it should not > - does not use SPL, which I need Check out the other hardware then that we emulate today, and or maybe something off of https://qemu.readthedocs.io/en/latest/system/target-arm.html that we could add. My point is that by picking the QEMU targets for where to test this feature you've gone with "I've introduced this feature so now I need to introduce this other change I've been arguing for too" in an artificial manner as it would only be used like that for testing. --=20 Tom --bO/C3H35Ok2OdENj Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmGCnz4ACgkQFHw5/5Y0 tywungv7BWGQIZSvSKo/F1aSo16f2c8azQyYXDd4pUzPSPs+hSi+p58WgttFOgFz LbKK4ZzpiVnQ5fAJvudB4XK7905NXVBAjDVtOvzhECKOW7jWEfI3Ufg2d5g61fNF bWGZxGt7o7XzoN23/blqVwuAuyVvlYZ8dR1vBcoEBZfPhlhpdA50x6vHmZfUe2z9 5u+xOyAdQT5EGebDi99YFyttwsxXCSQnGju4JEy4RQI9ulWiCgZN22gcjKH55x2l iw3K9w7I1Icu8K511sRtPGmrwv0SLIfkENHLFNjbwqvDxC5ixI49U33Nzn3vAeDg YsU4nklFRKtu9IlPv+ZDrEVmMnYWP8bFEUfv80C9Nwyz4+kn3XNuZMfvQgHiyKcD Y0SH4S1UnPyKQpFvaTYFkA4Mxe9bvu14GX9n2MhdU0QKh/06FavmxKhMGom/MQ66 PhPzRW7KcOKpjMdeWr7CluthmAt6UqMxzYehnDeSMZDE8vXjdftSumNrrC3/IX1F 9aR3vuaL =GDkE -----END PGP SIGNATURE----- --bO/C3H35Ok2OdENj--