Re: [PATCH v2 09/12] env: Change return behaviour of env_set_default_vars()

Simon Glass
2021-11-05T02:04:27Z

On Wed, 3 Nov 2021 at 17:23, Marek Behún <kabel@kernel.org> wrote:
>
> From: Marek Behún <marek.behun@nic.cz>
>
> The env_set_default_vars() function does not document return value and
> behaves differently from other env_* functions.
>
> Change the return value to return 0 on success and -ve on error.
>
> Signed-off-by: Marek Behún <marek.behun@nic.cz>
> ---
> env/common.c | 9 ++++++---
> include/env.h | 1 +
> 2 files changed, 7 insertions(+), 3 deletions(-)

Reviewed-by: Simon Glass <sjg@chromium.org>