From: AKASHI Takahiro <takahiro.akashi@linaro.org>
To: Simon Glass <sjg@chromium.org>
Cc: Heinrich Schuchardt <xypron.glpk@gmx.de>,
Alex Graf <agraf@csgraf.de>,
Ilias Apalodimas <ilias.apalodimas@linaro.org>,
Sughosh Ganu <sughosh.ganu@linaro.org>,
Masami Hiramatsu <masami.hiramatsu@linaro.org>,
U-Boot Mailing List <u-boot@lists.denx.de>
Subject: Re: [PATCH v6 07/12] tools: mkeficapsule: allow for specifying GUID explicitly
Date: Thu, 4 Nov 2021 11:12:32 +0900 [thread overview]
Message-ID: <20211104021232.GC46422@laputa> (raw)
In-Reply-To: <CAPnjgZ0AzvWAEKAXmbec5+L57VKCnAYrnwvs1fHeiSw5FhjhLg@mail.gmail.com>
On Tue, Nov 02, 2021 at 08:58:18AM -0600, Simon Glass wrote:
> Hi Takahiro,
>
> On Mon, 1 Nov 2021 at 18:56, AKASHI Takahiro <takahiro.akashi@linaro.org> wrote:
> >
> > The existing options, "--fit" and "--raw," are only used to put a proper
> > GUID in a capsule header, where GUID identifies a particular FMP (Firmware
> > Management Protocol) driver which then would handle the firmware binary in
> > a capsule. In fact, mkeficapsule does the exact same job in creating
> > a capsule file whatever the firmware binary type is.
> >
> > To prepare for the future extension, the command syntax will be a bit
> > modified to allow users to specify arbitrary GUID for their own FMP driver.
> > OLD:
> > [--fit <image> | --raw <image>] <capsule file>
> > NEW:
> > [--fit | --raw | --guid <guid-string>] <image> <capsule file>
>
> Do these drivers have names?
No, even there is no driver in the upstream tree.
> A guid is not a very friendly thing to
> have to provide.
This feature is expected to be used when a user wants to have his own
custom capsule format, yet using the existing command binary.
It will be very much so when loading a FMP (firmware management
protocol) driver dynamically will be supported in the future.
-Takahiro Akashi
> >
> > Signed-off-by: AKASHI Takahiro <takahiro.akashi@linaro.org>
> > ---
> > doc/develop/uefi/uefi.rst | 4 +-
> > doc/mkeficapsule.1 | 26 +++++++++----
> > tools/mkeficapsule.c | 78 ++++++++++++++++++++++++++++++---------
> > 3 files changed, 81 insertions(+), 27 deletions(-)
> >
>
> Reviewed-by: Simon Glass <sjg@chromium.org>
>
> Regards,
> Simon
next prev parent reply other threads:[~2021-11-04 2:12 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-02 0:55 [PATCH v6 00/12] efi_loader: capsule: improve capsule authentication support AKASHI Takahiro
2021-11-02 0:55 ` [PATCH v6 01/12] efi_loader: capsule: drop __weak from efi_get_public_key_data() AKASHI Takahiro
2021-11-02 0:55 ` [PATCH v6 02/12] tools: mkeficapsule: rework the code a little bit AKASHI Takahiro
2021-11-02 14:57 ` Simon Glass
2021-11-07 6:35 ` Heinrich Schuchardt
2021-11-08 4:18 ` AKASHI Takahiro
2021-11-02 0:55 ` [PATCH v6 03/12] tools: mkeficapsule: add firmwware image signing AKASHI Takahiro
2021-11-07 6:53 ` Heinrich Schuchardt
2021-11-08 4:38 ` AKASHI Takahiro
2021-11-02 0:55 ` [PATCH v6 04/12] tools: mkeficapsule: add man page AKASHI Takahiro
2021-11-02 0:55 ` [PATCH v6 05/12] doc: update UEFI document for usage of mkeficapsule AKASHI Takahiro
2021-11-02 0:55 ` [PATCH v6 06/12] test/py: efi_capsule: add image authentication test AKASHI Takahiro
2021-11-02 14:58 ` Simon Glass
2021-11-02 16:15 ` Ilias Apalodimas
2021-11-02 0:55 ` [PATCH v6 07/12] tools: mkeficapsule: allow for specifying GUID explicitly AKASHI Takahiro
2021-11-02 14:58 ` Simon Glass
2021-11-04 2:12 ` AKASHI Takahiro [this message]
2021-11-04 2:49 ` Simon Glass
2021-11-02 0:55 ` [PATCH v6 08/12] test/py: efi_capsule: align with the syntax change of mkeficapsule AKASHI Takahiro
2021-11-02 14:58 ` Simon Glass
2021-11-02 0:55 ` [PATCH v6 09/12] test/py: efi_capsule: add a test for "--guid" option AKASHI Takahiro
2021-11-02 0:55 ` [PATCH v6 10/12] test/py: efi_capsule: check the results in case of CAPSULE_AUTHENTICATE AKASHI Takahiro
2021-11-02 14:58 ` Simon Glass
2021-11-02 0:55 ` [PATCH v6 11/12] (RFC) tools: add fdtsig.sh AKASHI Takahiro
2021-11-02 0:55 ` [PATCH v6 12/12] (RFC) efi_loader, dts: add public keys for capsules to device tree AKASHI Takahiro
2021-11-02 14:58 ` Simon Glass
2021-11-04 2:17 ` AKASHI Takahiro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211104021232.GC46422@laputa \
--to=takahiro.akashi@linaro.org \
--cc=agraf@csgraf.de \
--cc=ilias.apalodimas@linaro.org \
--cc=masami.hiramatsu@linaro.org \
--cc=sjg@chromium.org \
--cc=sughosh.ganu@linaro.org \
--cc=u-boot@lists.denx.de \
--cc=xypron.glpk@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox