From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5DA3C433EF for ; Thu, 4 Nov 2021 02:12:48 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 021CA60F39 for ; Thu, 4 Nov 2021 02:12:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 021CA60F39 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 5888383645; Thu, 4 Nov 2021 03:12:43 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="XXo921tg"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id A65328364D; Thu, 4 Nov 2021 03:12:41 +0100 (CET) Received: from mail-pf1-x431.google.com (mail-pf1-x431.google.com [IPv6:2607:f8b0:4864:20::431]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 1104783632 for ; Thu, 4 Nov 2021 03:12:38 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=takahiro.akashi@linaro.org Received: by mail-pf1-x431.google.com with SMTP id 127so4347764pfu.1 for ; Wed, 03 Nov 2021 19:12:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:in-reply-to; bh=gy8C5SdQB51iwtY87GQDdTp0vbLy9s0ho+oSCrjvwU8=; b=XXo921tgVitKKUQMNo/j5DC3EhyLgCi9RB+XnJSnI1Zl0bB9ZWh7ihfHEDXyCsz9uf sWtaO4+QBJ/tKw6AejD6ERFEed6Iklmm+uhGxg7inrJjVKxrNTbWEIIB7+NsKGCwFtd/ qbdBgy3YACwqDb8z8n01/UqALjgfY4/D3jKq3PbWt6bIXIDvXCDcyNT9u7zoDapNT5el Orj1aVjO5DBJaRUUDuf9H7etHIR4M24J0N4zfl2HdhhHoO7j0W0Pz3y4XKrLhG95NgeR ECxdWmgJjyunTkiUmJTCl7K1SV0l4duWrOTZ+xFhRCC2+GXEMs95LlqdAIHTEn++2nLq 9LbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to; bh=gy8C5SdQB51iwtY87GQDdTp0vbLy9s0ho+oSCrjvwU8=; b=EkQ5paaG1ZugAcWiR0xdB1L3yLSW452bYe2APdYvaIkXbcASpFec/WFcZCc1vdkJMQ wi62s8jAR3QsmTa3GLoHxvtgUm6qXCaodYsBmv3fpDW7oNJmAy57o+XGTI6DXT+LWLbH OrUUnl9+JG5HTqSuY/L9dD99zIZYOwcQsGGAmwvszQbKJNBoZ8kR1caxZ3fRccm1vXfo 06yd9/KKnnc5BDafi651nUqXGcffXGBJ7gvnZrOf/Zo5OLMRIhhTx2Ti1H+jkIfsk481 GblVjpBvCHc542Fo/yKK93lzGUkUuuWyCJjUSwktWC0x2NA9ITBTL28EYS7Y+p/fBKp9 YQEA== X-Gm-Message-State: AOAM531uAfgh0g2Rukhm/p0YcquPM3RrA4EDSoDrcQ+ejnZWFsdVdHP8 cpqaUdwBCHzh10huleOBZyTklYO3hGFXlQ== X-Google-Smtp-Source: ABdhPJyjrvhwaQG2fuI1kLSl2pip1AKwGqVnw3ZuJyPVNZN95j6KlqUAm5RhCRDq5FqGBRPzqyaOeQ== X-Received: by 2002:a65:5688:: with SMTP id v8mr21232325pgs.304.1635991956436; Wed, 03 Nov 2021 19:12:36 -0700 (PDT) Received: from laputa ([2400:4050:c3e1:100:9171:d985:c6fb:194d]) by smtp.gmail.com with ESMTPSA id z19sm3603255pfe.20.2021.11.03.19.12.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Nov 2021 19:12:36 -0700 (PDT) Date: Thu, 4 Nov 2021 11:12:32 +0900 From: AKASHI Takahiro To: Simon Glass Cc: Heinrich Schuchardt , Alex Graf , Ilias Apalodimas , Sughosh Ganu , Masami Hiramatsu , U-Boot Mailing List Subject: Re: [PATCH v6 07/12] tools: mkeficapsule: allow for specifying GUID explicitly Message-ID: <20211104021232.GC46422@laputa> Mail-Followup-To: AKASHI Takahiro , Simon Glass , Heinrich Schuchardt , Alex Graf , Ilias Apalodimas , Sughosh Ganu , Masami Hiramatsu , U-Boot Mailing List References: <20211102005512.96019-1-takahiro.akashi@linaro.org> <20211102005512.96019-8-takahiro.akashi@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On Tue, Nov 02, 2021 at 08:58:18AM -0600, Simon Glass wrote: > Hi Takahiro, > > On Mon, 1 Nov 2021 at 18:56, AKASHI Takahiro wrote: > > > > The existing options, "--fit" and "--raw," are only used to put a proper > > GUID in a capsule header, where GUID identifies a particular FMP (Firmware > > Management Protocol) driver which then would handle the firmware binary in > > a capsule. In fact, mkeficapsule does the exact same job in creating > > a capsule file whatever the firmware binary type is. > > > > To prepare for the future extension, the command syntax will be a bit > > modified to allow users to specify arbitrary GUID for their own FMP driver. > > OLD: > > [--fit | --raw ] > > NEW: > > [--fit | --raw | --guid ] > > Do these drivers have names? No, even there is no driver in the upstream tree. > A guid is not a very friendly thing to > have to provide. This feature is expected to be used when a user wants to have his own custom capsule format, yet using the existing command binary. It will be very much so when loading a FMP (firmware management protocol) driver dynamically will be supported in the future. -Takahiro Akashi > > > > Signed-off-by: AKASHI Takahiro > > --- > > doc/develop/uefi/uefi.rst | 4 +- > > doc/mkeficapsule.1 | 26 +++++++++---- > > tools/mkeficapsule.c | 78 ++++++++++++++++++++++++++++++--------- > > 3 files changed, 81 insertions(+), 27 deletions(-) > > > > Reviewed-by: Simon Glass > > Regards, > Simon