From: Heiko Thiery <heiko.thiery@gmail.com>
To: u-boot@lists.denx.de
Cc: Stefano Babic <sbabic@denx.de>,
Fabio Estevam <festevam@gmail.com>,
Michael Walle <michael@walle.cc>, Simon Glass <sjg@chromium.org>,
Heiko Thiery <heiko.thiery@gmail.com>
Subject: [RFC 2/2] binman: catch RunException for mkimage runtime failure
Date: Thu, 4 Nov 2021 19:52:34 +0100 [thread overview]
Message-ID: <20211104185231.2927-3-heiko.thiery@gmail.com> (raw)
In-Reply-To: <20211104185231.2927-1-heiko.thiery@gmail.com>
In case mkimage exits with a return code other than zero do not stop.
Print an error message and go on.
Signed-off-by: Heiko Thiery <heiko.thiery@gmail.com>
---
tools/binman/etype/mkimage.py | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/tools/binman/etype/mkimage.py b/tools/binman/etype/mkimage.py
index e49977522e..24fbe79172 100644
--- a/tools/binman/etype/mkimage.py
+++ b/tools/binman/etype/mkimage.py
@@ -10,6 +10,7 @@ from collections import OrderedDict
from binman.entry import Entry
from dtoc import fdt_util
from patman import tools
+from patman import tout
class Entry_mkimage(Entry):
"""Binary produced by mkimage
@@ -51,7 +52,12 @@ class Entry_mkimage(Entry):
input_fname = tools.GetOutputFilename('mkimage.%s' % uniq)
tools.WriteFile(input_fname, data)
output_fname = tools.GetOutputFilename('mkimage-out.%s' % uniq)
- tools.Run('mkimage', '-d', input_fname, *self._args, output_fname)
+
+ try:
+ tools.Run('mkimage', '-d', input_fname, *self._args, output_fname)
+ except Exception as e:
+ tout.Error("mkimage failed: %s" % e)
+
self.SetContents(tools.ReadFile(output_fname))
return True
--
2.30.2
next prev parent reply other threads:[~2021-11-04 18:53 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-04 18:52 [RFC 0/2] Do not stop with an error when mkimage fails Heiko Thiery
2021-11-04 18:52 ` [RFC 1/2] patman: introduce RunException Heiko Thiery
2021-11-05 2:02 ` Simon Glass
2021-11-04 18:52 ` Heiko Thiery [this message]
2021-11-05 2:02 ` [RFC 2/2] binman: catch RunException for mkimage runtime failure Simon Glass
2021-11-05 7:49 ` Heiko Thiery
2021-11-05 16:12 ` Simon Glass
2021-11-04 19:12 ` [RFC 0/2] Do not stop with an error when mkimage fails Wolfgang Denk
2021-11-04 19:31 ` Heiko Thiery
2021-11-07 14:48 ` Wolfgang Denk
2021-11-09 19:21 ` Heiko Thiery
2021-11-09 19:42 ` Tom Rini
2021-11-10 0:18 ` Rasmus Villemoes
2021-11-10 0:26 ` Rasmus Villemoes
2021-11-10 1:37 ` Tom Rini
2021-11-10 8:28 ` Michael Walle
2021-11-10 16:31 ` Simon Glass
2021-11-11 12:29 ` Wolfgang Denk
2021-11-10 0:58 ` Simon Glass
2021-11-11 12:27 ` Wolfgang Denk
2021-11-11 15:04 ` Tom Rini
2021-11-11 12:24 ` Wolfgang Denk
2021-11-11 13:54 ` Heiko Thiery
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211104185231.2927-3-heiko.thiery@gmail.com \
--to=heiko.thiery@gmail.com \
--cc=festevam@gmail.com \
--cc=michael@walle.cc \
--cc=sbabic@denx.de \
--cc=sjg@chromium.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox