Re: [PATCH v2 11/12] arm: mvebu: Espressobin: Use new API for setting default env at runtime

Simon Glass
2021-11-05T02:07:57Z

On Wed, 3 Nov 2021 at 17:23, Marek Behún <kabel@kernel.org> wrote:
>
> From: Marek Behún <marek.behun@nic.cz>
>
> ESPRESSObin's board code uses an ad-hoc solution for ensuring that
> ethaddrs are not overwritten by `env default -a` command and that the
> `fdtfile` is set to correct value when `env default -a` is called.
>
> This ad-hoc solution is overwriting the default_environment[] buffer in
> board_late_init().
>
> Since now we have a specific API for overwriting default environment,
> convert this ad-hoc code to this new API.
>
> Signed-off-by: Marek Behún <marek.behun@nic.cz>
> ---
> board/Marvell/mvebu_armada-37xx/board.c | 135 +++++++++++++-------
> configs/mvebu_espressobin-88f3720_defconfig | 1 +
> include/configs/mvebu_armada-37xx.h | 17 +--
> 3 files changed, 90 insertions(+), 63 deletions(-)

Reviewed-by: Simon Glass <sjg@chromium.org>