From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Simon Glass <sjg@chromium.org>,
Ovidiu Panait <ovidiu.panait@windriver.com>,
u-boot@lists.denx.de
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Subject: [PATCH v1 1/2] image: Fix typo in boot_get_kbd()
Date: Fri, 5 Nov 2021 23:09:51 +0300 [thread overview]
Message-ID: <20211105200952.47866-1-andriy.shevchenko@linux.intel.com> (raw)
After the commit 4ed37abc49c2 ("image: Remove ifdefs around
image_setup_linux() el at"):
common/image-board.c: In function ‘boot_get_kbd’:
common/image-board.c:902:17: error: expected ‘)’ before ‘do_bdinfo’
902 | do_bdinfo(NULL, 0, 0, NULL);
| ^~~~~~~~~
common/image-board.c:901:12: note: to match this ‘(’
901 | if (IS_ENABLED(CONFIG_CMD_BDI)
| ^
common/image-board.c:906:1: error: expected expression before ‘}’ token
906 | }
| ^
common/image-board.c:906:1: warning: control reaches end of non-void function [-Wreturn-type]
906 | }
| ^
Fix obvious typo.
Fixes: 4ed37abc49c2 ("image: Remove ifdefs around image_setup_linux() el at")
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Revert "image: Partially revert too aggressive ifdeferry removal"
This reverts commit 84631af9d0454ff8252c1aebb1e9c232b8077692.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
common/image-board.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/common/image-board.c b/common/image-board.c
index e7660352e96a..ddf30c67302e 100644
--- a/common/image-board.c
+++ b/common/image-board.c
@@ -898,7 +898,7 @@ int boot_get_kbd(struct lmb *lmb, struct bd_info **kbd)
debug("## kernel board info at 0x%08lx\n", (ulong)*kbd);
#if defined(DEBUG)
- if (IS_ENABLED(CONFIG_CMD_BDI)
+ if (IS_ENABLED(CONFIG_CMD_BDI))
do_bdinfo(NULL, 0, 0, NULL);
#endif
--
2.33.0
next reply other threads:[~2021-11-05 20:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-05 20:09 Andy Shevchenko [this message]
2021-11-05 20:09 ` [PATCH v1 2/2] image: Explicitly declare do_bdinfo() Andy Shevchenko
2021-11-06 3:16 ` Simon Glass
2021-11-06 7:58 ` Andy Shevchenko
2021-11-07 16:43 ` Simon Glass
2021-11-08 8:37 ` Andy Shevchenko
2021-11-08 15:58 ` Simon Glass
2021-11-06 3:16 ` [PATCH v1 1/2] image: Fix typo in boot_get_kbd() Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211105200952.47866-1-andriy.shevchenko@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=ovidiu.panait@windriver.com \
--cc=sjg@chromium.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox