From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1E58C433F5 for ; Fri, 5 Nov 2021 20:10:10 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9C4F960F45 for ; Fri, 5 Nov 2021 20:10:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 9C4F960F45 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id BECCE83736; Fri, 5 Nov 2021 21:10:06 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=linux.intel.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id 8A48F83726; Fri, 5 Nov 2021 21:10:03 +0100 (CET) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 219EC83726 for ; Fri, 5 Nov 2021 21:09:57 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=linux.intel.com Authentication-Results: phobos.denx.de; spf=none smtp.mailfrom=andriy.shevchenko@linux.intel.com X-IronPort-AV: E=McAfee;i="6200,9189,10159"; a="255627675" X-IronPort-AV: E=Sophos;i="5.87,212,1631602800"; d="scan'208";a="255627675" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Nov 2021 13:09:56 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,212,1631602800"; d="scan'208";a="639916447" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga001.fm.intel.com with ESMTP; 05 Nov 2021 13:09:55 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id 42E0511E; Fri, 5 Nov 2021 22:09:56 +0200 (EET) From: Andy Shevchenko To: Simon Glass , Ovidiu Panait , u-boot@lists.denx.de Cc: Andy Shevchenko Subject: [PATCH v1 1/2] image: Fix typo in boot_get_kbd() Date: Fri, 5 Nov 2021 23:09:51 +0300 Message-Id: <20211105200952.47866-1-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.33.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean After the commit 4ed37abc49c2 ("image: Remove ifdefs around image_setup_linux() el at"): common/image-board.c: In function ‘boot_get_kbd’: common/image-board.c:902:17: error: expected ‘)’ before ‘do_bdinfo’ 902 | do_bdinfo(NULL, 0, 0, NULL); | ^~~~~~~~~ common/image-board.c:901:12: note: to match this ‘(’ 901 | if (IS_ENABLED(CONFIG_CMD_BDI) | ^ common/image-board.c:906:1: error: expected expression before ‘}’ token 906 | } | ^ common/image-board.c:906:1: warning: control reaches end of non-void function [-Wreturn-type] 906 | } | ^ Fix obvious typo. Fixes: 4ed37abc49c2 ("image: Remove ifdefs around image_setup_linux() el at") Signed-off-by: Andy Shevchenko Revert "image: Partially revert too aggressive ifdeferry removal" This reverts commit 84631af9d0454ff8252c1aebb1e9c232b8077692. Signed-off-by: Andy Shevchenko --- common/image-board.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/common/image-board.c b/common/image-board.c index e7660352e96a..ddf30c67302e 100644 --- a/common/image-board.c +++ b/common/image-board.c @@ -898,7 +898,7 @@ int boot_get_kbd(struct lmb *lmb, struct bd_info **kbd) debug("## kernel board info at 0x%08lx\n", (ulong)*kbd); #if defined(DEBUG) - if (IS_ENABLED(CONFIG_CMD_BDI) + if (IS_ENABLED(CONFIG_CMD_BDI)) do_bdinfo(NULL, 0, 0, NULL); #endif -- 2.33.0