From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55F38C433EF for ; Mon, 8 Nov 2021 05:29:56 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5F32F61074 for ; Mon, 8 Nov 2021 05:29:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 5F32F61074 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 9273B8382C; Mon, 8 Nov 2021 06:29:52 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="AUorVD6F"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 4F5E38382E; Mon, 8 Nov 2021 06:29:51 +0100 (CET) Received: from mail-pf1-x431.google.com (mail-pf1-x431.google.com [IPv6:2607:f8b0:4864:20::431]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 10B3883825 for ; Mon, 8 Nov 2021 06:29:47 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=takahiro.akashi@linaro.org Received: by mail-pf1-x431.google.com with SMTP id m26so14922183pff.3 for ; Sun, 07 Nov 2021 21:29:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:in-reply-to; bh=3ipjHHuaFGIkP/uUFVyvERVftG/rvDnFjIF64buajN8=; b=AUorVD6FnZ9YvcE+PVfEV/EUafzp9Mheg09Ga92+bkjJPnUWaqXzejs8m07XQNp1yV iIeVKUedkZQ8dZgEI7f7TgpLZqCtHTh4delawa80pUJ2iqFqRN6mGPTbGGEdwYEHxJTn gAOhDKWZ4tfN6ym42mUhor3dxy+W3VEnZ5WcRJTpc38LrYaOVmOJzuWyjM0j0oOAx7QA ZovvdEw+VfT6VcAszG035XDF5XgIsQFqTg9spy3nwRfCVqvx3xhnfAAgUE+JvhrfZwhg n06LUk320rQYqcpQk+BURpFzncXiO2sKqtUPdDwjGUADns9WC82ZEdt48TnTlP9FuRht T9cA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to; bh=3ipjHHuaFGIkP/uUFVyvERVftG/rvDnFjIF64buajN8=; b=SFUQTKkTRp1V9oyQeWp3wKBFk0VXvHaFGY9uQIOaQbt9x6SMxnxWvFpxf6b2SpBSfH Ud3M5MA9uZnVDNvN+I/N6TZ/tiZBVwV5uNtaV2WYQx/e1yfoTt2LiWUujsA/tLPwFilf 4n+QpspeH+V1l0faHsKmp24LLDBXnpk9CAn4RK3Lgh7bvMLEjnQ+3NUS6n48aJbpooMJ AMDxybMPcPsLs80AAWvtHYfCI+3p1sAAx6JBtBOy+6mtHTHyq6T8Ia1nMerOkRgHzSma EdGW2vsDlNw21Re2c88pp3lwA97j6HnjlIqgCp2DjOGY48hpL/btJSixxaAxIEkncpVO S7bg== X-Gm-Message-State: AOAM532Ca2HkB8d5u8WIM+cqzh3VdzLSuf+Uc/d3mUpS9e1meILwbflL uBOQqeveV1rY0wIha1d5QARxSw== X-Google-Smtp-Source: ABdhPJz2dhc+nQItMTBk3KgPb+y/isWvGCfog9Q6VWlNmNmw16lupEBSQRgsFzZV0ykpuWB8gpcISg== X-Received: by 2002:a63:2702:: with SMTP id n2mr23813368pgn.319.1636349385218; Sun, 07 Nov 2021 21:29:45 -0800 (PST) Received: from laputa ([2400:4050:c3e1:100:98bf:5be1:75ff:1c8a]) by smtp.gmail.com with ESMTPSA id h13sm5643488pfv.130.2021.11.07.21.29.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 07 Nov 2021 21:29:44 -0800 (PST) Date: Mon, 8 Nov 2021 14:29:40 +0900 From: AKASHI Takahiro To: Simon Glass Cc: Heinrich Schuchardt , Ilias Apalodimas , Tom Rini , Christian Melki , Bin Meng , Alexander Graf , U-Boot Mailing List Subject: Re: [PATCH v4 09/34] efi: Add EFI uclass for media Message-ID: <20211108052940.GF16401@laputa> Mail-Followup-To: AKASHI Takahiro , Simon Glass , Heinrich Schuchardt , Ilias Apalodimas , Tom Rini , Christian Melki , Bin Meng , Alexander Graf , U-Boot Mailing List References: <20211104030936.2446706-1-sjg@chromium.org> <20211103210920.v4.9.I50ca59e389adf282bbff50eecc593f010a89c0f7@changeid> <9634500b-604a-a79e-3785-5d49ea21d84b@gmx.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On Sun, Nov 07, 2021 at 09:43:22AM -0700, Simon Glass wrote: > Hi Heinrich, > > On Sun, 7 Nov 2021 at 01:21, Heinrich Schuchardt wrote: > > > > > > > > On 11/4/21 04:09, Simon Glass wrote: > > > At present UCLASS_EFI is used to represent an EFI filesystem among other > > > things. The description of this uclass is "EFI managed devices" which is > > > pretty vague. The only driver that uses this uclass is in fact not a real > > > U-Boot driver, since its operations do not include a struct udevice. > > > > > > Rather than mess with this, create a new UCLASS_EFI_MEDIA uclass to handle > > > EFI media such as disks. Make this the uclass to use for EFI media so that > > > it can be used with 'part list', for example. > > > > > > The existing implementation using UCLASS_EFI remains as is, for > > > discussion. > > > > > > Signed-off-by: Simon Glass > > > --- > > > > > > (no changes since v2) > > > > > > Changes in v2: > > > - Add MAINTAINERS entry > > > - Show the correct interface type with 'part list' > > > - Update the commit message to explain things better > > > > > > MAINTAINERS | 3 +++ > > > arch/sandbox/dts/test.dts | 4 ++++ > > > disk/part.c | 5 ++++- > > > drivers/block/Kconfig | 23 +++++++++++++++++++++++ > > > drivers/block/Makefile | 3 +++ > > > drivers/block/blk-uclass.c | 2 +- > > > drivers/block/efi-media-uclass.c | 15 +++++++++++++++ > > > drivers/block/sb_efi_media.c | 20 ++++++++++++++++++++ > > > include/dm/uclass-id.h | 1 + > > > test/dm/Makefile | 1 + > > > test/dm/efi_media.c | 24 ++++++++++++++++++++++++ > > > 11 files changed, 99 insertions(+), 2 deletions(-) > > > create mode 100644 drivers/block/efi-media-uclass.c > > > create mode 100644 drivers/block/sb_efi_media.c > > > create mode 100644 test/dm/efi_media.c > > > > > > diff --git a/MAINTAINERS b/MAINTAINERS > > > index 00ff572d4d2..3e8f10c72fa 100644 > > > --- a/MAINTAINERS > > > +++ b/MAINTAINERS > > > @@ -712,8 +712,11 @@ W: https://u-boot.readthedocs.io/en/latest/develop/uefi/u-boot_on_efi.html > > > F: board/efi/efi-x86_app > > > F: configs/efi-x86_app* > > > F: doc/develop/uefi/u-boot_on_efi.rst > > > +F: drivers/block/efi-media-uclass.c > > > +F: drivers/block/sb_efi_media.c > > > F: lib/efi/efi_app.c > > > F: scripts/build-efi.sh > > > +F: test/dm/efi_media.c > > > > > > EFI PAYLOAD > > > M: Heinrich Schuchardt > > > diff --git a/arch/sandbox/dts/test.dts b/arch/sandbox/dts/test.dts > > > index 8cd688e8d26..2cea4a43c87 100644 > > > --- a/arch/sandbox/dts/test.dts > > > +++ b/arch/sandbox/dts/test.dts > > > @@ -498,6 +498,10 @@ > > > compatible = "sandbox,clk-ccf"; > > > }; > > > > > > + efi-media { > > > + compatible = "sandbox,efi-media"; > > > + }; > > > + > > > eth@10002000 { > > > compatible = "sandbox,eth"; > > > reg = <0x10002000 0x1000>; > > > diff --git a/disk/part.c b/disk/part.c > > > index a6a8f7052bd..2560f6a50bc 100644 > > > --- a/disk/part.c > > > +++ b/disk/part.c > > > @@ -296,8 +296,11 @@ static void print_part_header(const char *type, struct blk_desc *dev_desc) > > > case IF_TYPE_VIRTIO: > > > puts("VirtIO"); > > > break; > > > + case IF_TYPE_EFI: > > > + puts("EFI"); > > > + break; > > > default: > > > - puts ("UNKNOWN"); > > > + puts("UNKNOWN"); > > > break; > > > } > > > printf (" device %d -- Partition Type: %s\n\n", > > > diff --git a/drivers/block/Kconfig b/drivers/block/Kconfig > > > index 56a4eec05ac..755fdccb574 100644 > > > --- a/drivers/block/Kconfig > > > +++ b/drivers/block/Kconfig > > > @@ -61,6 +61,29 @@ config TPL_BLOCK_CACHE > > > help > > > This option enables the disk-block cache in TPL > > > > > > +config EFI_MEDIA > > > + bool "Support EFI media drivers" > > > + default y if EFI || SANDBOX > > > + help > > > + Enable this to support media devices on top of UEFI. This enables > > > + just the uclass so you also need a specific driver to make this do > > > + anything. > > > + > > > + For sandbox there is a test driver. > > > + > > > +if EFI_MEDIA > > > + > > > +config EFI_MEDIA_SANDBOX > > > + bool "Sandbox EFI media driver" > > > + depends on SANDBOX > > > + default y > > > + help > > > + Enables a simple sandbox media driver, used for testing just the > > > + EFI_MEDIA uclass. It does not do anything useful, since sandbox does > > > + not actually support running on top of UEFI. > > > + > > > +endif # EFI_MEDIA > > > + > > > config IDE > > > bool "Support IDE controllers" > > > select HAVE_BLOCK_DEVICE > > > diff --git a/drivers/block/Makefile b/drivers/block/Makefile > > > index 94ab5c6f906..3778633da1d 100644 > > > --- a/drivers/block/Makefile > > > +++ b/drivers/block/Makefile > > > @@ -14,3 +14,6 @@ obj-$(CONFIG_IDE) += ide.o > > > endif > > > obj-$(CONFIG_SANDBOX) += sandbox.o > > > obj-$(CONFIG_$(SPL_TPL_)BLOCK_CACHE) += blkcache.o > > > + > > > +obj-$(CONFIG_EFI_MEDIA) += efi-media-uclass.o > > > +obj-$(CONFIG_EFI_MEDIA_SANDBOX) += sb_efi_media.o > > > diff --git a/drivers/block/blk-uclass.c b/drivers/block/blk-uclass.c > > > index 83682dcc181..2db7ce5de20 100644 > > > --- a/drivers/block/blk-uclass.c > > > +++ b/drivers/block/blk-uclass.c > > > @@ -44,7 +44,7 @@ static enum uclass_id if_type_uclass_id[IF_TYPE_COUNT] = { > > > [IF_TYPE_SATA] = UCLASS_AHCI, > > > [IF_TYPE_HOST] = UCLASS_ROOT, > > > [IF_TYPE_NVME] = UCLASS_NVME, > > > - [IF_TYPE_EFI] = UCLASS_EFI, > > > + [IF_TYPE_EFI] = UCLASS_EFI_MEDIA, > > > > Don't break existing code. Create a new if_type here. > > My understanding is that this is not actually used at present. The > tests appear to pass without trouble. > > What problem are you seeing? I can agree with Simon's claim that the notion of UCLASS_EFI sounds vague. In my understanding, it is expected to represent any UEFI driver/application who will convert "UEFI protocol" to "U-Boot device", the only example right now is "efi_block" device. One of issues that I can see is that any instance of UCLASS_EFI doesn't appear in DM tree. I have made an experimental patch which makes UCLASS_EFI a pseudo U-Boot device. DM tree would look like: root |-- 'EFI block driver' (CLASS_EFI for block_io_protocol) |-- 'efi_blk' (CLASS_BLK with TYPE_EFI) This way, the meaning of UCLASS_EFI should be much clearer? # In fact, the actual implementer of BLOCK_IO_PROTOCOL is # a loaded UEFI application, though. -Takahiro Akashi > Regards, > Simon