From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B539C433EF for ; Mon, 8 Nov 2021 15:50:07 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6F33461288 for ; Mon, 8 Nov 2021 15:50:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 6F33461288 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 1B2BD83879; Mon, 8 Nov 2021 16:50:04 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="Ew79O3wA"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id C622A83879; Mon, 8 Nov 2021 16:50:01 +0100 (CET) Received: from mail-qv1-xf30.google.com (mail-qv1-xf30.google.com [IPv6:2607:f8b0:4864:20::f30]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 49ADE83875 for ; Mon, 8 Nov 2021 16:49:58 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qv1-xf30.google.com with SMTP id s9so12118045qvk.12 for ; Mon, 08 Nov 2021 07:49:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=BK9o2zIGJk+LBbktN9Wro/lKyH6NJqL/TK5bgCscCpk=; b=Ew79O3wAbDvcXt2tMYT/mJrmxzTtsBJnPa3VPpUHZXnpl69v1tnP/CBpIIHrXdhmLi zHrQxBkOArxXdcxHcB40zUgZschJp3MZfQn/3Vvf6LHPCsqgQPP0ZOKtNMPB64HuE+tT EX83kcfnnMHSbR73lx1gLEojacq2ffmSZAeqE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=BK9o2zIGJk+LBbktN9Wro/lKyH6NJqL/TK5bgCscCpk=; b=taLpRRT/nFSdR3ZXqkfwQvnua119EPmVGRsyaVeGc9KGbOjAeUYPF7uarzgFk3k0Ax kF2MNKV5Ra+L7CdTeqVSVWuNJHhPBeRq0oXORklOAHCuuib2MNKSRf+dwZtPqvPF0Gto ZoNMlsvWKGnkIChgyqlVtYL8vV6RTIeTASpdZ+26/LAWX+3ziLPHybAAvLgMt/U4GKTT RcFGKzLo8+slqxWQwxEq5wI5kIyIZpSdSydFbHR6x+TVzesabwQMJvARbQKaQm10KicS ain5aHwVDlveWNUqaCBsOTjwbtLLaYm/HKgDrSDGzjOTAE1pKWEgOAtEELKDYcWv/Lyq IA9g== X-Gm-Message-State: AOAM5305azwvZS0Nbxad2obzQRTQEQWoq8CC93Pqt3lzsxa9UidCa74D VMKhL09Dy4ReyjsC2/56+pGe0Q== X-Google-Smtp-Source: ABdhPJxG+AwAfIAlS7Qsd/elQUFOPxloPA3/T9l1KBiZF1lpHJpejWKxYANwnJcm9gYZTlZ3qCUwBQ== X-Received: by 2002:a05:6214:2523:: with SMTP id gg3mr149869qvb.1.1636386597106; Mon, 08 Nov 2021 07:49:57 -0800 (PST) Received: from bill-the-cat (2603-6081-7b01-cbda-65cb-752a-b567-5ae4.res6.spectrum.com. [2603:6081:7b01:cbda:65cb:752a:b567:5ae4]) by smtp.gmail.com with ESMTPSA id o190sm9871154qka.16.2021.11.08.07.49.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Nov 2021 07:49:56 -0800 (PST) Date: Mon, 8 Nov 2021 10:49:54 -0500 From: Tom Rini To: Sinthu Raja Cc: u-boot@lists.denx.de, Praneeth Bajjuri , Sinthu Raja Subject: Re: [PATCH V2 04/17] board: ti: j721e: Guard functions with right #ifdef to avoid build warnings Message-ID: <20211108154954.GC24579@bill-the-cat> References: <20211102140558.32460-1-sinthu.raja@ti.com> <20211102140558.32460-5-sinthu.raja@ti.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="LBCjp+rz+jSuXC4X" Content-Disposition: inline In-Reply-To: <20211102140558.32460-5-sinthu.raja@ti.com> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --LBCjp+rz+jSuXC4X Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Nov 02, 2021 at 07:35:45PM +0530, Sinthu Raja wrote: > From: Sinthu Raja >=20 > board_late_init(), setup_board_eeprom_env() and setup_serial() is > called only under CONFIG_BOARD_LATE_INIT, so guard these functions > with the same. >=20 > Signed-off-by: Sinthu Raja > --- >=20 > No chnages in V2. >=20 > board/ti/j721e/evm.c | 4 ++++ > 1 file changed, 4 insertions(+) We should probably re-order the code so that everything is under a single #ifdef. --=20 Tom --LBCjp+rz+jSuXC4X Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmGJRyIACgkQFHw5/5Y0 tyxMiwv/UcWuSk8wGZ5l17XHPDlqm4AQZUAekorliKE/iisnA6nuO3Z337k/neob /XG8ITpPfqhOugLZkGvcoKKpyc4xdO8PC7pbsHOBFdJ1FeWS3cDEMyl5lWXpNN6I RcYUMwdt7tPKoyX9UvZR4lRNVHFvfT5CPwBHtIBf2VX+bp5+5Hpz00giMntiTkfz mNhbZf+TRsPrKUGr9U0XdsJG+OZMiU7KBxF/a9XVCioxILHmCQCgq8Is2XToergI 94VDOqs/3ZOpzEUqtqT4gDGLADwhyTA1O5SESJ5C8KUA52LgnqjKiyQ4WS0f1CMN 8kmYPGxVXdhpc1O6+6N02KpT4zyDUph5xNFWDeuGQpcDtju4KpNGZUB0X3pNswk4 oYr3LA60mOFPYbE+v+Eah28RBHjG0D3JmC4Al7DpJxss8LcbmdVcerwvT6ZTQyH9 28uBli5GPnTGiYprww5bs0THSlGJOXgQc5+P7PKNMiRaYlnUueltNVD9IRZw3qpO J3hn3CHD =Vudx -----END PGP SIGNATURE----- --LBCjp+rz+jSuXC4X--