Re: [PATCH V2 04/17] board: ti: j721e: Guard functions with right #ifdef to avoid build warnings

Tom Rini
2021-11-08T15:50:07Z

[-- Attachment #1: Type: text/plain, Size: 526 bytes --]

On Tue, Nov 02, 2021 at 07:35:45PM +0530, Sinthu Raja wrote:

> From: Sinthu Raja <sinthu.raja@ti.com>
>
> board_late_init(), setup_board_eeprom_env() and setup_serial() is
> called only under CONFIG_BOARD_LATE_INIT, so guard these functions
> with the same.
>
> Signed-off-by: Sinthu Raja <sinthu.raja@ti.com>
> ---
>
> No chnages in V2.
>
> board/ti/j721e/evm.c | 4 ++++
> 1 file changed, 4 insertions(+)

We should probably re-order the code so that everything is under a
single #ifdef.

--
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]