Re: [PATCH V2 09/17] arm: j721e: Add support for selecting DT based on EEPROM

Tom Rini
2021-11-12T14:46:19Z

[-- Attachment #1: Type: text/plain, Size: 1676 bytes --]

On Fri, Nov 12, 2021 at 07:02:49PM +0530, Sinthu Raja M wrote:
> Hi Tom,
>
> On Mon, Nov 8, 2021 at 9:23 PM Tom Rini <trini@konsulko.com> wrote:
> >
> > On Tue, Nov 02, 2021 at 07:35:50PM +0530, Sinthu Raja wrote:
> >
> > > From: Sinthu Raja <sinthu.raja@ti.com>
> > >
> > > Enable support for selecting DTB from FIT within SPL based on the
> > > board name read from EEPROM. This will help to use single defconfig
> > > for both EVM and SK.
> > >
> > > Also print FDT model name and board name read from EEPROM on SPL debug
> > > console. This is useful to verify that right dtb is loaded in each boot
> > > stage.
> > >
> > > Signed-off-by: Sinthu Raja <sinthu.raja@ti.com>
> > > ---
> > >
> > > No changes in V2.
> > >
> > > arch/arm/mach-k3/j721e_init.c | 62 +++++++++++++++++++++++++++++++++++
> > > 1 file changed, 62 insertions(+)
> >
> > The EEPROM scheme is not K3-generic, but rather TI reference platform
> > specific, so this needs to be abstracted to exist and be called from
> > under board/ti/j721e/.. thanks.
>
> I guess the commit description is a little misleading. It just calls
> the board_detect function which is existed under the board/ti/j721e.
> Printing of board info is not required here which can be removed.

Right, but board/ti/j721e/ code is not relevant to non-TI reference
platforms. The code under arch/arm/mach-k3/ needs to be SoC centric,
and the TI reference platforms and their shared EEPROM stuff needs to
be under board/ti/. It also needs to be as clear as possible how to
remove it as custom platforms don't usually copy this EEPROM scheme and
this adds confusion on their part.

--
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]