From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD880C433EF for ; Tue, 9 Nov 2021 12:03:08 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3B71160F58 for ; Tue, 9 Nov 2021 12:03:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 3B71160F58 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 501728391E; Tue, 9 Nov 2021 13:03:06 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=linux.intel.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id DE7C68391E; Tue, 9 Nov 2021 13:03:03 +0100 (CET) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 131F283632 for ; Tue, 9 Nov 2021 13:02:59 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=linux.intel.com Authentication-Results: phobos.denx.de; spf=none smtp.mailfrom=andriy.shevchenko@linux.intel.com X-IronPort-AV: E=McAfee;i="6200,9189,10162"; a="295867954" X-IronPort-AV: E=Sophos;i="5.87,220,1631602800"; d="scan'208";a="295867954" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Nov 2021 04:02:58 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,220,1631602800"; d="scan'208";a="503478779" Received: from black.fi.intel.com ([10.237.72.28]) by orsmga008.jf.intel.com with ESMTP; 09 Nov 2021 04:02:56 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id 9D8FDC5; Tue, 9 Nov 2021 14:02:58 +0200 (EET) From: Andy Shevchenko To: Andy Shevchenko , Simon Glass , u-boot@lists.denx.de Cc: Bin Meng Subject: [PATCH v1 2/2] x86: scu: Add a few debug messages to the driver Date: Tue, 9 Nov 2021 15:02:55 +0300 Message-Id: <20211109120255.77679-2-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20211109120255.77679-1-andriy.shevchenko@linux.intel.com> References: <20211109120255.77679-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean For some devices that have slightly different firmware implementation it's good to see what's going on when communicating with the SCU. Add a few debug messages for that purpose. Signed-off-by: Andy Shevchenko --- arch/x86/lib/scu.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/arch/x86/lib/scu.c b/arch/x86/lib/scu.c index 90ef239bcd3d..c7274e064647 100644 --- a/arch/x86/lib/scu.c +++ b/arch/x86/lib/scu.c @@ -11,6 +11,7 @@ */ #include #include +#include #include #include #include @@ -48,6 +49,7 @@ struct scu { */ static void scu_ipc_send_command(struct ipc_regs *regs, u32 cmd) { + debug("%s(): 0x%08x\n", __func__, cmd); writel(cmd, ®s->cmd); } @@ -92,12 +94,18 @@ static int scu_ipc_cmd(struct ipc_regs *regs, u32 cmd, u32 sub, for (i = 0; i < inlen; i++) writel(*in++, ®s->wbuf[i]); + debug_hex_dump("SCU in", DUMP_PREFIX_OFFSET, 16, 4, in, inlen * 4, false); + scu_ipc_send_command(regs, (inlen << 16) | (sub << 12) | cmd); err = scu_ipc_check_status(regs); if (!err) { + u32 *buf = out; + for (i = 0; i < outlen; i++) *out++ = readl(®s->rbuf[i]); + + debug_hex_dump("SCU out", DUMP_PREFIX_OFFSET, 16, 4, buf, outlen * 4, false); } return err; -- 2.33.0