From: Tom Rini <trini@konsulko.com>
To: Rasmus Villemoes <rasmus.villemoes@prevas.dk>
Cc: Heiko Thiery <heiko.thiery@gmail.com>, Wolfgang Denk <wd@denx.de>,
u-boot@lists.denx.de, Stefano Babic <sbabic@denx.de>,
Fabio Estevam <festevam@gmail.com>,
Michael Walle <michael@walle.cc>, Simon Glass <sjg@chromium.org>
Subject: Re: [RFC 0/2] Do not stop with an error when mkimage fails
Date: Tue, 9 Nov 2021 20:37:20 -0500 [thread overview]
Message-ID: <20211110013720.GD24579@bill-the-cat> (raw)
In-Reply-To: <3253160d-b2e1-2101-5cd4-b8549b5acbae@prevas.dk>
[-- Attachment #1: Type: text/plain, Size: 1510 bytes --]
On Wed, Nov 10, 2021 at 01:26:12AM +0100, Rasmus Villemoes wrote:
> On 10/11/2021 01.18, Rasmus Villemoes wrote:
> > On 09/11/2021 20.42, Tom Rini wrote:
> >> On Tue, Nov 09, 2021 at 08:21:07PM +0100, Heiko Thiery wrote:
> >>> Hi Wolfgang,
> >>>
> >
> >>> I know this is not a perfect solution but I don't know how to get my
> >>> board merged without doing this kind of workaround for the U-Boot CI.
> >>
> >> Unfortunately in these days of needing multiple inputs to create a
> >> functional image and also needing to have CI be able to be at all
> >> useful, what we do in many many many cases is yell loudly to the user
> >> that the resulting file here will NOT work and why. So yes, some "yell
> >> it won't work but not return non-zero exit status" is the norm.
> >>
> >> I would be very much open however to some way to handle this
> >> differently. Some environment variable our tools check for and then
> >> yell-but-succeed? Some other idea? I'm just thinking out loud here.
> >
> > Yes, I believe the build system must be taught some env var (or other
> > means) for opting in to this behavior.
>
> Oh, and it should of course only paper over missing binary blobs, not
> arbitrary errors from mkimage or other tools. The easiest way to do that
> is probably to create some dummy blob(s) [only when CREATE_BROKEN_IMAGES
> is set of course] before calling the tool that will consume the blobs.
Some patches along those lines would be most welcome :)
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
next prev parent reply other threads:[~2021-11-10 1:37 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-04 18:52 [RFC 0/2] Do not stop with an error when mkimage fails Heiko Thiery
2021-11-04 18:52 ` [RFC 1/2] patman: introduce RunException Heiko Thiery
2021-11-05 2:02 ` Simon Glass
2021-11-04 18:52 ` [RFC 2/2] binman: catch RunException for mkimage runtime failure Heiko Thiery
2021-11-05 2:02 ` Simon Glass
2021-11-05 7:49 ` Heiko Thiery
2021-11-05 16:12 ` Simon Glass
2021-11-04 19:12 ` [RFC 0/2] Do not stop with an error when mkimage fails Wolfgang Denk
2021-11-04 19:31 ` Heiko Thiery
2021-11-07 14:48 ` Wolfgang Denk
2021-11-09 19:21 ` Heiko Thiery
2021-11-09 19:42 ` Tom Rini
2021-11-10 0:18 ` Rasmus Villemoes
2021-11-10 0:26 ` Rasmus Villemoes
2021-11-10 1:37 ` Tom Rini [this message]
2021-11-10 8:28 ` Michael Walle
2021-11-10 16:31 ` Simon Glass
2021-11-11 12:29 ` Wolfgang Denk
2021-11-10 0:58 ` Simon Glass
2021-11-11 12:27 ` Wolfgang Denk
2021-11-11 15:04 ` Tom Rini
2021-11-11 12:24 ` Wolfgang Denk
2021-11-11 13:54 ` Heiko Thiery
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211110013720.GD24579@bill-the-cat \
--to=trini@konsulko.com \
--cc=festevam@gmail.com \
--cc=heiko.thiery@gmail.com \
--cc=michael@walle.cc \
--cc=rasmus.villemoes@prevas.dk \
--cc=sbabic@denx.de \
--cc=sjg@chromium.org \
--cc=u-boot@lists.denx.de \
--cc=wd@denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox