From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3A16C433F5 for ; Wed, 10 Nov 2021 01:37:32 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B51C1610A6 for ; Wed, 10 Nov 2021 01:37:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org B51C1610A6 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 9F4B683948; Wed, 10 Nov 2021 02:37:29 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="gxeGF+4G"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 0E8868395F; Wed, 10 Nov 2021 02:37:28 +0100 (CET) Received: from mail-qv1-xf2d.google.com (mail-qv1-xf2d.google.com [IPv6:2607:f8b0:4864:20::f2d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 9D838836E0 for ; Wed, 10 Nov 2021 02:37:24 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qv1-xf2d.google.com with SMTP id u16so817071qvk.4 for ; Tue, 09 Nov 2021 17:37:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=UlnBbmU44poaxbk5pK9nGblmIqRxpo9wwHBlChasUVk=; b=gxeGF+4GGZBkFe0xAK5nmEZr4HiJMoYLVB2/x9UIdwXURpxzdkKVXIbWM40+LcYIUV UZrQmjKRkbBgA4wFcSTgINVoffpiKeqd5rWeFIaog85KpDGZtsTM3fpzPEAZd9bgUWX4 yHiAvzXbPvs9vipQs/rh6YzqpDxxZ5g3p7r4s= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=UlnBbmU44poaxbk5pK9nGblmIqRxpo9wwHBlChasUVk=; b=Vla8UUcuTCu7Oi7aLiShusliojbQiEHoUPGyLheEpgChPQcRT8wH8gpXC5E0Te6wCE yrq/OOGQzAx8Dekd8pHihkcxS0+o50c26YGsMcfTekuMMExoe6ZaECiuIE4dxMk9DgJV Tp7EM4mFfMzMM6clWGnaBja3y/a2MbelfTgZGOTsS0pQYOimUuCbgEa4m9U8JZoKOWUy 3Y6TcCJNZpAClreHG4agVDpXzzW1SQJXR5MeX1dD6rQkQQ0SlRu8IDhJAMPuMin4OLqS 2nMT7zLR3I5vc1goKpZCtpA5m8qbBRnGTESPK8upX38o8iu9dEhC3dnaJCNWDv9eh8ar /8Bw== X-Gm-Message-State: AOAM530cpCRNVvtLjmIyEAXM7/r1cXK6bgvSUvZeuvv+mG8XO9EkPWya m7AH6Tj/YSjeCX1PDvjH6oF1wQ== X-Google-Smtp-Source: ABdhPJzahKYUFjQb3hVJCcM9UZPyuVDHneOCJsH6AE6XGn8jMeba+8RHbj2H+MU6K0pQriZh2TjmMg== X-Received: by 2002:ad4:5b8f:: with SMTP id 15mr12225347qvp.60.1636508243195; Tue, 09 Nov 2021 17:37:23 -0800 (PST) Received: from bill-the-cat (2603-6081-7b01-cbda-74ad-b320-81ce-4688.res6.spectrum.com. [2603:6081:7b01:cbda:74ad:b320:81ce:4688]) by smtp.gmail.com with ESMTPSA id p16sm12996696qtx.92.2021.11.09.17.37.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Nov 2021 17:37:22 -0800 (PST) Date: Tue, 9 Nov 2021 20:37:20 -0500 From: Tom Rini To: Rasmus Villemoes Cc: Heiko Thiery , Wolfgang Denk , u-boot@lists.denx.de, Stefano Babic , Fabio Estevam , Michael Walle , Simon Glass Subject: Re: [RFC 0/2] Do not stop with an error when mkimage fails Message-ID: <20211110013720.GD24579@bill-the-cat> References: <20211104185231.2927-1-heiko.thiery@gmail.com> <729199.1636053161@gemini.denx.de> <963318.1636296486@gemini.denx.de> <20211109194224.GB24579@bill-the-cat> <11cebfaf-8fc4-f80d-ed0f-bd8810a43514@prevas.dk> <3253160d-b2e1-2101-5cd4-b8549b5acbae@prevas.dk> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="FrUuTWcY1UW1Vh+U" Content-Disposition: inline In-Reply-To: <3253160d-b2e1-2101-5cd4-b8549b5acbae@prevas.dk> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --FrUuTWcY1UW1Vh+U Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Nov 10, 2021 at 01:26:12AM +0100, Rasmus Villemoes wrote: > On 10/11/2021 01.18, Rasmus Villemoes wrote: > > On 09/11/2021 20.42, Tom Rini wrote: > >> On Tue, Nov 09, 2021 at 08:21:07PM +0100, Heiko Thiery wrote: > >>> Hi Wolfgang, > >>> > >=20 > >>> I know this is not a perfect solution but I don't know how to get my > >>> board merged without doing this kind of workaround for the U-Boot CI. > >> > >> Unfortunately in these days of needing multiple inputs to create a > >> functional image and also needing to have CI be able to be at all > >> useful, what we do in many many many cases is yell loudly to the user > >> that the resulting file here will NOT work and why. So yes, some "yell > >> it won't work but not return non-zero exit status" is the norm. > >> > >> I would be very much open however to some way to handle this > >> differently. Some environment variable our tools check for and then > >> yell-but-succeed? Some other idea? I'm just thinking out loud here. > >=20 > > Yes, I believe the build system must be taught some env var (or other > > means) for opting in to this behavior.=20 >=20 > Oh, and it should of course only paper over missing binary blobs, not > arbitrary errors from mkimage or other tools. The easiest way to do that > is probably to create some dummy blob(s) [only when CREATE_BROKEN_IMAGES > is set of course] before calling the tool that will consume the blobs. Some patches along those lines would be most welcome :) --=20 Tom --FrUuTWcY1UW1Vh+U Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmGLIkoACgkQFHw5/5Y0 tyzv0gv/XR9bUacg0Xa27sq/9Iy9CaQoIZ+GVoQBdwzwXA+nTYXtPIYo6fCszTJM lzfZQTs39sfk6bKv7CJOP6b4KfCrWYG+tUzgVnqftRDUywR43wPSeFHrDKyyK+Al L4RGpwM5aEUrDXyEewOg5sZW3Sg0rmU5m6RkT2W7kQntVFW07kIEQuViBCnyt6BN 6kP87RhQYNB8TGtVsLFR0QoBRguERq0kFqVjetPLCetiuLqCydDOd9q14FYO3cJp Vm1gdEKO4YPncGAuDmrjF1V5enMvPzgXWClO2coHERA+RUEqu84JvWf3a+S7DysC q4IqbiyfWzj6LAw0tuzwjsdmIanUteB/lH7u08hMLGlmfTLJNqtjWOd92j8zi/QI Qi63Iu/gCxBdrwqlXoT2rFmcd+EXdXUqBREP+EdY+GWNAee2W/J6LXdTSV0rtWwQ 8sB1hy6jdv5VoLieksNRWGuOgJ3cvNq2j6UZb6XrlX3VorM/A7z4ULe3VrdEDoJZ IW8ja53a =rrNe -----END PGP SIGNATURE----- --FrUuTWcY1UW1Vh+U--