From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A28C1C433EF for ; Wed, 10 Nov 2021 14:14:26 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1465B610A8 for ; Wed, 10 Nov 2021 14:14:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 1465B610A8 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 2A5F0839B8; Wed, 10 Nov 2021 15:14:24 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="ldgQPRXy"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 4B143839B9; Wed, 10 Nov 2021 15:14:22 +0100 (CET) Received: from mail-qt1-x836.google.com (mail-qt1-x836.google.com [IPv6:2607:f8b0:4864:20::836]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 86C42839A9 for ; Wed, 10 Nov 2021 15:14:18 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x836.google.com with SMTP id l8so2196143qtk.6 for ; Wed, 10 Nov 2021 06:14:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=9u22t7tX6Qdc1ceg/S8ZikOWtV9TF30mgGFm4I4+H4M=; b=ldgQPRXyghaJC9Z6zIaz3eP7jQKEWw7S60kTkkjoEDuzfJaUSmEk3ebNz5+4mN522+ PRyQuPdO00syQ9GqO/0jF8e1FlHbe3pYZNi9OYYYhKWfN6vdthbdt8bWbE5tr7fHSEfP nxxcJjseqpZw9aj/Lo9NcCgrmFTTOb4MdEwr4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=9u22t7tX6Qdc1ceg/S8ZikOWtV9TF30mgGFm4I4+H4M=; b=gOxh55Rm0oAUBWuFr/sxwTqngLNetwXSYu8Co0bnKt0Xw02mo9R5u2nAKUor6MhU8t 2gliRsZzTYG9y94o8Eaa4HyEn6KKtItrpqSMqTSeHAvcNJh1/q0+3G4VlzhfGcjxBmrW kaa8z1pwKVHNEJTIajseoEzezAyNxt7QFvhnidCDtQc/hgqKr/IjMQteM32cviq0w9me kvsl9c69fcLrcNfu0PxPNWJk4LxTr9LvOOvf5vEFuS9sAHznC7DUx3ShVe40K3Kw12i5 Cu5BVVm/1mGzR/Uw/7UFk3mK6EP8WE6tDoAPFanIe3S5MhnZQXNqv+6qU0bV2yAck0+j D8ug== X-Gm-Message-State: AOAM531V9KnI6mgVFY2OHPUqBAQLl/BVM6Vx3LuI5k8jP4KNHrnJ5ec/ fArACI2pHlK70393QJ2jgYMUrlQ3qzKlSg== X-Google-Smtp-Source: ABdhPJxZDPP1Nn3I/hhnt+K3fxpxaA7vFuEAJLVuQ5m1Y18Gig2Hdeux7+VLb/XbBhtp/ygXPIsj+g== X-Received: by 2002:a05:622a:1051:: with SMTP id f17mr17283534qte.65.1636553657087; Wed, 10 Nov 2021 06:14:17 -0800 (PST) Received: from bill-the-cat (2603-6081-7b01-cbda-74ad-b320-81ce-4688.res6.spectrum.com. [2603:6081:7b01:cbda:74ad:b320:81ce:4688]) by smtp.gmail.com with ESMTPSA id h9sm74300qth.75.2021.11.10.06.14.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Nov 2021 06:14:16 -0800 (PST) Date: Wed, 10 Nov 2021 09:14:14 -0500 From: Tom Rini To: =?iso-8859-1?Q?Pierre-Cl=E9ment?= Tosi Cc: u-boot@lists.denx.de, Matthias Weisser Subject: Re: [PATCH] arm: Fix bad memcpy.S str8w macro argument count Message-ID: <20211110141414.GE24579@bill-the-cat> References: <20211110140440.2116503-1-ptosi@google.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="4T9XHU/D8Lz3laf6" Content-Disposition: inline In-Reply-To: <20211110140440.2116503-1-ptosi@google.com> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --4T9XHU/D8Lz3laf6 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Nov 10, 2021 at 03:04:40PM +0100, Pierre-Cl=E9ment Tosi wrote: > Remove the extra (empty) argument passed to str8w, causing the following > error: >=20 > :40:47: error: too many positional arguments > str8w r0, r3, r4, r5, r6, r7, r8, r9, ip, , abort=3D19f > ^ > u-boot/arch/arm/lib/memcpy.S:240:5: note: while in macro instantiation > 17: forward_copy_shift pull=3D16 push=3D16 > ^ >=20 > Note: no functional change intended. >=20 > Fixes: d8834a1323af ("arm: Use optimized memcpy and memset from linux") > Signed-off-by: Pierre-Cl=E9ment Tosi > --- > arch/arm/lib/memcpy.S | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/arch/arm/lib/memcpy.S b/arch/arm/lib/memcpy.S > index f7fb77235c..eee7a219ce 100644 > --- a/arch/arm/lib/memcpy.S > +++ b/arch/arm/lib/memcpy.S > @@ -210,7 +210,7 @@ ENTRY(memcpy) > orr r9, r9, ip, lspush #\push > mov ip, ip, lspull #\pull > orr ip, ip, lr, lspush #\push > - str8w r0, r3, r4, r5, r6, r7, r8, r9, ip, , abort=3D19f > + str8w r0, r3, r4, r5, r6, r7, r8, r9, ip, abort=3D19f > bge 12b > PLD( cmn r2, #96 ) > PLD( bge 13b ) Since this code is both taken from Linux, and likely in need of a re-sync with Linux, has this issue been addressed upstream? Or no longer present? Thanks. --=20 Tom --4T9XHU/D8Lz3laf6 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmGL07AACgkQFHw5/5Y0 tyw1ugwAhhfObqxgid5WsKcnWIRZnnOkQ/nomOeXO0eeL4bj7BYu3WISyXZ/YUaG EzZoEdrnpmKsiL7gcdJ3mlguUvkPZ+j2gPkfoZ+JHlYCsilF4hU/9VREaOzlohhD E2KcwA2n47KAXY4d1gYtwUCrxr5VRJvnqcX+FPhGZ8IHsYtFQk/gh+R+gH7fdhj+ 7HvL8s4ncqmzt79eTHdN4WfOzcSLFrCXkwmG15zKP5MgSy2whLRjvYfA/uaMBrXU UEkmKcg0bP2+BgZtCdk1sx/AD1bJ4hyxAu3TwwQlvHkR4Gghlh3UCMCc0sU4d0st Oo4SOU0mvvv8tAoBDV6er258YNTbEMI4PrHhCCmTOShV8SUNvy6nvAZOmIHpIOKv HMCv6IKB09uQLCbwlz6sAQCPWqso74ufxR/a06H7ctP7bdvm/DS40nzMTJ37mDYv +Z2w1tHHCw3LTX/mkj0oBfD2w89Qv/uA0eX7sSEgYDUqJihMIoSoQYPvagUu/rYd Aw2YZuIO =GgqM -----END PGP SIGNATURE----- --4T9XHU/D8Lz3laf6--