public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Tom Rini <trini@konsulko.com>
To: Patrice CHOTARD <patrice.chotard@foss.st.com>
Cc: Patrick DELAUNAY <patrick.delaunay@foss.st.com>,
	Marek Vasut <marex@denx.de>,
	u-boot@lists.denx.de
Subject: Re: [PATCH] ARM: stm32: Align mtdparts with SPI NOR layout on DHSOM
Date: Wed, 10 Nov 2021 11:02:40 -0500	[thread overview]
Message-ID: <20211110160240.GG24579@bill-the-cat> (raw)
In-Reply-To: <19c837cf-508a-7fc4-34c8-45d38416f384@foss.st.com>

[-- Attachment #1: Type: text/plain, Size: 1116 bytes --]

On Wed, Nov 10, 2021 at 04:56:37PM +0100, Patrice CHOTARD wrote:
> Hi Marek
> 
> On 10/25/21 10:43 AM, Patrick DELAUNAY wrote:
> > Hi,
> > 
> > On 10/24/21 12:46 AM, Marek Vasut wrote:
> >> The DHSOM uses different SPI NOR layout than the ST devkit, stop
> >> pulling in the ST specific runtime mtdparts settings and adjust
> >> the mtdparts accordingly.
> >>
> >> Signed-off-by: Marek Vasut <marex@denx.de>
> >> Cc: Patrice Chotard <patrice.chotard@foss.st.com>
> >> Cc: Patrick Delaunay <patrick.delaunay@foss.st.com>
> >> ---
> >>   board/dhelectronics/dh_stm32mp1/Makefile | 1 -
> >>   configs/stm32mp15_dhcom_basic_defconfig  | 3 ++-
> >>   configs/stm32mp15_dhcor_basic_defconfig  | 2 ++
> >>   3 files changed, 4 insertions(+), 2 deletions(-)
> >>
> > 
> > Reviewed-by: Patrick Delaunay <patrick.delaunay@foss.st.com>
> > 
> Applied on u-boot-stm/master 
> Thanks

Question and not saying don't send me a PR with it.  Why aren't these in
the per-board dts files with the fixed-partition binding?  That's been
long long supported in Linux and U-Boot parses it as well.

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]

  reply	other threads:[~2021-11-10 16:02 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-23 22:46 [PATCH] ARM: stm32: Align mtdparts with SPI NOR layout on DHSOM Marek Vasut
2021-10-25  6:42 ` Patrice CHOTARD
2021-10-25  8:43 ` Patrick DELAUNAY
2021-11-10 15:56   ` Patrice CHOTARD
2021-11-10 16:02     ` Tom Rini [this message]
2021-11-10 17:05       ` Patrice CHOTARD
2021-11-10 17:12         ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211110160240.GG24579@bill-the-cat \
    --to=trini@konsulko.com \
    --cc=marex@denx.de \
    --cc=patrice.chotard@foss.st.com \
    --cc=patrick.delaunay@foss.st.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox