From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3CAEDC433EF for ; Thu, 11 Nov 2021 17:11:26 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9D16761268 for ; Thu, 11 Nov 2021 17:11:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 9D16761268 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 9DA3183A64; Thu, 11 Nov 2021 18:11:18 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id BC88A83A45; Thu, 11 Nov 2021 18:11:09 +0100 (CET) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by phobos.denx.de (Postfix) with ESMTP id 7D32D83A45 for ; Thu, 11 Nov 2021 18:11:04 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=andre.przywara@arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D2C16101E; Thu, 11 Nov 2021 09:11:03 -0800 (PST) Received: from donnerap.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 481263F718; Thu, 11 Nov 2021 09:11:03 -0800 (PST) Date: Thu, 11 Nov 2021 17:11:01 +0000 From: Andre Przywara To: Peter Hoyes Cc: u-boot@lists.denx.de, diego.sueiro@arm.com Subject: Re: [PATCH v2 5/5] vexpress64: Enable VIRTIO_NET network driver Message-ID: <20211111171101.5434274e@donnerap.cambridge.arm.com> In-Reply-To: <20211111092603.774415-6-peter.hoyes@arm.com> References: <20211111092603.774415-1-peter.hoyes@arm.com> <20211111092603.774415-6-peter.hoyes@arm.com> Organization: ARM X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; aarch64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On Thu, 11 Nov 2021 09:26:03 +0000 Peter Hoyes wrote: > From: Peter Hoyes > > The SMSC driver is using the old driver model. > > Init the virtio system in vexpress64.c so that the network device is > discovered. > > Signed-off-by: Peter Hoyes Looks like the same as v1, so repeating my tag: Reviewed-by: Andre Przywara Cheers, Andre > --- > board/armltd/vexpress64/vexpress64.c | 7 +++++++ > include/configs/vexpress_aemv8.h | 4 ++-- > 2 files changed, 9 insertions(+), 2 deletions(-) > > diff --git a/board/armltd/vexpress64/vexpress64.c b/board/armltd/vexpress64/vexpress64.c > index d17b463be5..5e22e89824 100644 > --- a/board/armltd/vexpress64/vexpress64.c > +++ b/board/armltd/vexpress64/vexpress64.c > @@ -18,6 +18,10 @@ > #include > #include "pcie.h" > #include > +#ifdef CONFIG_VIRTIO_NET > +#include > +#include > +#endif > > DECLARE_GLOBAL_DATA_PTR; > > @@ -64,6 +68,9 @@ __weak void vexpress64_pcie_init(void) > int board_init(void) > { > vexpress64_pcie_init(); > +#ifdef CONFIG_VIRTIO_NET > + virtio_init(); > +#endif > return 0; > } > > diff --git a/include/configs/vexpress_aemv8.h b/include/configs/vexpress_aemv8.h > index 7cdfc30649..faa7065086 100644 > --- a/include/configs/vexpress_aemv8.h > +++ b/include/configs/vexpress_aemv8.h > @@ -88,8 +88,8 @@ > #endif > #endif /* !CONFIG_GICV3 */ > > -#ifndef CONFIG_TARGET_VEXPRESS64_JUNO > -/* The Vexpress64 simulators use SMSC91C111 */ > +#if defined(CONFIG_TARGET_VEXPRESS64_BASE_FVP) && !defined(CONFIG_DM_ETH) > +/* The Vexpress64 BASE_FVP simulator uses SMSC91C111 */ > #define CONFIG_SMC91111 1 > #define CONFIG_SMC91111_BASE (V2M_PA_BASE + 0x01A000000) > #endif