From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1ECF9C4332F for ; Fri, 12 Nov 2021 14:46:19 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6F97261076 for ; Fri, 12 Nov 2021 14:46:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 6F97261076 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 7D48B82FE7; Fri, 12 Nov 2021 15:46:15 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="udoNlpcQ"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 746A782FE7; Fri, 12 Nov 2021 15:46:13 +0100 (CET) Received: from mail-qk1-x730.google.com (mail-qk1-x730.google.com [IPv6:2607:f8b0:4864:20::730]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id F208582FDE for ; Fri, 12 Nov 2021 15:46:09 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qk1-x730.google.com with SMTP id bk22so9265190qkb.6 for ; Fri, 12 Nov 2021 06:46:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=P0Su9DdkUsQ9U9rO0gLKW9YMQNZI7JgdxCnPoLPYzfU=; b=udoNlpcQOzjAoHwE2ZzPwcoWrJZidmz9cUPQq1kGtcFTFZ3bySQNndy16e/GsN5fI+ wN+4z/N/VDD60lHOqbMHEMD3GgLjR6wdFL6XNBgCb1sVArmVlzZiM0pEjlrAnGTq/orG qt6B/AUpgRfM2D2uXq5+/aY0t/h9jn/0YvgxM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=P0Su9DdkUsQ9U9rO0gLKW9YMQNZI7JgdxCnPoLPYzfU=; b=BrpEG1eD5wSs1YPIFvzBR7OG9h5JRAtY75VyKKrgUyiqydNW/hfNsz9wUlzqPXmAkj X1lfYCvGXKLuVyzW2ttyBmSw2FrE3vaJdBR+V3oDnXa0vZh1BrHpRFHDX/F+H7vfHBbl jmosln4bKkWauXWVe8taKn1wgk6uS0imj1epmRHDFmHJT+dP5OWOBMKmo7sXKIYwzs27 t0zx0xI/mEG4AsZ8/PqdqTThQ7KGMjnjJvfaoPW7b8zOpGP7c/9wHbQ0sNua7LUQW1KI UWrVFrW7SC8/MGasCJ0ZY44KWGH5AmaAT3DXbU02b9eVz50+NT6NMYVZUA7yTPm6g8m7 2ZIA== X-Gm-Message-State: AOAM533iUpnjd3Edfu9t0q2CNyc379BqiOJXQCUTQAUbWTrtnMRvmhNN 3GrkJ5bylAgizCLF5KmPgsiwKw== X-Google-Smtp-Source: ABdhPJxi+eJAjOkxWBmUbF+38Il3PTTFdYfQKvDhg9psgpnALD8caQAAysXgBD3njwLcpDHj5OGFSA== X-Received: by 2002:a05:620a:4044:: with SMTP id i4mr10387759qko.271.1636728368763; Fri, 12 Nov 2021 06:46:08 -0800 (PST) Received: from bill-the-cat (2603-6081-7b01-cbda-0560-a46c-4644-38cb.res6.spectrum.com. [2603:6081:7b01:cbda:560:a46c:4644:38cb]) by smtp.gmail.com with ESMTPSA id l15sm3304933qtx.77.2021.11.12.06.46.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Nov 2021 06:46:08 -0800 (PST) Date: Fri, 12 Nov 2021 09:46:06 -0500 From: Tom Rini To: Sinthu Raja M Cc: u-boot@lists.denx.de, Praneeth Bajjuri , Sinthu Raja Subject: Re: [PATCH V2 09/17] arm: j721e: Add support for selecting DT based on EEPROM Message-ID: <20211112144606.GY24579@bill-the-cat> References: <20211102140558.32460-1-sinthu.raja@ti.com> <20211102140558.32460-10-sinthu.raja@ti.com> <20211108155318.GF24579@bill-the-cat> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="JONX0CKUi1IH44pR" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.35 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --JONX0CKUi1IH44pR Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Nov 12, 2021 at 07:02:49PM +0530, Sinthu Raja M wrote: > Hi Tom, >=20 > On Mon, Nov 8, 2021 at 9:23 PM Tom Rini wrote: > > > > On Tue, Nov 02, 2021 at 07:35:50PM +0530, Sinthu Raja wrote: > > > > > From: Sinthu Raja > > > > > > Enable support for selecting DTB from FIT within SPL based on the > > > board name read from EEPROM. This will help to use single defconfig > > > for both EVM and SK. > > > > > > Also print FDT model name and board name read from EEPROM on SPL debug > > > console. This is useful to verify that right dtb is loaded in each bo= ot > > > stage. > > > > > > Signed-off-by: Sinthu Raja > > > --- > > > > > > No changes in V2. > > > > > > arch/arm/mach-k3/j721e_init.c | 62 +++++++++++++++++++++++++++++++++= ++ > > > 1 file changed, 62 insertions(+) > > > > The EEPROM scheme is not K3-generic, but rather TI reference platform > > specific, so this needs to be abstracted to exist and be called from > > under board/ti/j721e/.. thanks. > > I guess the commit description is a little misleading. It just calls > the board_detect function which is existed under the board/ti/j721e. > Printing of board info is not required here which can be removed. Right, but board/ti/j721e/ code is not relevant to non-TI reference platforms. The code under arch/arm/mach-k3/ needs to be SoC centric, and the TI reference platforms and their shared EEPROM stuff needs to be under board/ti/. It also needs to be as clear as possible how to remove it as custom platforms don't usually copy this EEPROM scheme and this adds confusion on their part. --=20 Tom --JONX0CKUi1IH44pR Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmGOfi4ACgkQFHw5/5Y0 tywzTQv7B6vN/Wk0GTIZd8FGS+DhN8eUyd+4q7vrjZ22rsUPORhb+xmmC5P/EZlC ZattAL+KUobayPvnfD1odRU2B5wUaiLkr/YfBHrTB+J4JWd+mtjKeUSwRyK/IRVH kWdfbL5AEGHrhOkwrLBawUAuyu4fbMYeDP9Rvje6nshv00NtzUyHeVdWt0YPJttZ Ar0Z/JDOBj7lc/7Doi627G+47KzVahldiEXIzwlxysfxLeRNd/4noRag/5a1LmNx adVMY8PPCs/UizPMuC4kczUFuvLhIQOdH0DXWDG1Vpub8HT//KOaYrWokS7YKAxK R5YeQFwX2rDbVcs3P30u3iq8LMLGayaXk2QxxnHqStH5Ia5/jj7wakGs4uBFywbg MgTHWBDAa81sA0G3ls86l92ZJJHRnvKAUrAy5Y4FNDueWsurv56rCwEtexOw4P47 M10cvcjfBZrCcfh86pe+Ez7tWTqdq02wwM2HT2gYgq7m5XvpV8lP7U07ZIUvKYWe I3lEopJ8 =kQm/ -----END PGP SIGNATURE----- --JONX0CKUi1IH44pR--