From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A25EC43217 for ; Fri, 12 Nov 2021 15:40:56 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 674FE61076 for ; Fri, 12 Nov 2021 15:40:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 674FE61076 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id B526F83026; Fri, 12 Nov 2021 16:40:45 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="IBhZ7pkn"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id AF2D183012; Fri, 12 Nov 2021 16:40:02 +0100 (CET) Received: from mail-qk1-x733.google.com (mail-qk1-x733.google.com [IPv6:2607:f8b0:4864:20::733]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id EFC2E82FFB for ; Fri, 12 Nov 2021 16:39:42 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qk1-x733.google.com with SMTP id g28so5007493qkk.9 for ; Fri, 12 Nov 2021 07:39:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=74/7d2Vvfdl5nho5k+2Iztr7KH4iaGlmieRko8TzVqY=; b=IBhZ7pknLkiofzSyZFT/QVDVkDtbAy1xI2DgvZWHY+axC9g4NlrQYoxgpBQNtl4Nc+ 808bYrNBYW8zuZ8JWyjImOdyHRM/5Tvf52EIml61EGQYoriCCgeuWgQfVvlOClrtkmLC H/qjtr8g+7YHQs/FR/MePzCPuyWDt7m9kp8FA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=74/7d2Vvfdl5nho5k+2Iztr7KH4iaGlmieRko8TzVqY=; b=5AXm0a26gEYUEb7okZ+tXM10ZDVh+JOcO4NK90LJeKV5yKYkklKRQ1Ze7P6Sp7/c7K umy8uO8lZwJleAis7RpgV5BK1Sfy3ZFQt5ZbtKdYwU7byF9glUI6ix8jidlBUGT9SJ0f mRqfGhdKGmj6DzqZXbCZJtuSswJ+DoN9jAYWak+03IWVr11ngmqun5RJ4t6U5nWjeM0F 2FC6AoYNu43cssGHDC2diobhQu8NxdZXa5BWyaTb8bw9YwlL0XgF64sh/diaCH0Wyg4p Ow9skR+OCQ0kw4l6mvKoWzKg5O18h7u9APZcwjqKfHPxsOCnMhzfeGaIWAJZYXSQ0Z0X OYmg== X-Gm-Message-State: AOAM533T4/hly132QLi8mrIPo9JZfmqvk36fCFBi3GB1RsA4RZhq0884 HVCfSDaz0Eu/3FhkbhK1EIu6zwa9isvM6A== X-Google-Smtp-Source: ABdhPJwGqOR/faOAec6K9Oi0MxuiZbrizuLw5sCzDwj18fE31yd8t2P9yfRXgAmtxSHAEY+xMJ8X5g== X-Received: by 2002:a05:620a:f07:: with SMTP id v7mr13110175qkl.289.1636731581827; Fri, 12 Nov 2021 07:39:41 -0800 (PST) Received: from bill-the-cat (2603-6081-7b01-cbda-99df-60fa-a7c9-fbd2.res6.spectrum.com. [2603:6081:7b01:cbda:99df:60fa:a7c9:fbd2]) by smtp.gmail.com with ESMTPSA id bq30sm2903529qkb.6.2021.11.12.07.39.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Nov 2021 07:39:41 -0800 (PST) Date: Fri, 12 Nov 2021 10:39:39 -0500 From: Tom Rini To: Simon Glass Cc: U-Boot Mailing List , Patrice Chotard , Artem Lapkin , Joe Hershberger , Heinrich Schuchardt , Peter Hoyes Subject: Re: [PATCH v3 09/18] pxe: Tidy up code style a little in pxe_utils Message-ID: <20211112153939.GH24579@bill-the-cat> References: <20211014184811.482560-1-sjg@chromium.org> <20211014124803.v3.9.Ib56ccfab71a5b43d9d35c5d9bd88813e6dfd9ffb@changeid> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="Ho71OzWqGSvYQCp6" Content-Disposition: inline In-Reply-To: <20211014124803.v3.9.Ib56ccfab71a5b43d9d35c5d9bd88813e6dfd9ffb@changeid> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.35 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --Ho71OzWqGSvYQCp6 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Oct 14, 2021 at 12:48:02PM -0600, Simon Glass wrote: > There are a few more blank lines than makes sense for readability. Also > free() handles a NULL pointer so drop the pointless checks. >=20 > Signed-off-by: Simon Glass > Reviewed-by: Artem Lapkin > Tested-by: Artem Lapkin > Reviewed-by: Ramon Fried Applied to u-boot/master, thanks! --=20 Tom --Ho71OzWqGSvYQCp6 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmGOirsACgkQFHw5/5Y0 tyzkswv8DO6wg4y8qrCXt8IAUNwRD0TeyTMX5DNDQbWaIgzE4Xrh5WRAOz7IoA2w t/YSL40OrngTCeGIqnV/ZoOsO1+DB61UU0B0aV6DklYIiGkCCwEIK5vr3UB65rzq kKgO7pCe40/Alf3VT08+MFZypWWiN7NBNaKiimfgJ35x+ek0vuOfSmiSAMzejm7A yZzUvDGB1+Cs4bKPbao2a8p2y7IPN3Wvs/paYWep8zG2H092TW39lr+I0s7cN3GA NXSUE5tOHkoNjb+aE98DC1XMyJ2KsBki5Psp4Is7PtvjjqMKC4c3RiZTi5hSJFLq 9uvEptEccRDWT0J/9LUnC/0bdZYooCDJGeW6CNPlF01v3p738TzAN/k7hxtKNCnE 6Ojmv9HwjB1GXIfnSx35FjRx80sWBUX8AuckZJcCRLKClVbDZImZHOKgvRxrgIXs Gd+HPg7FX3Q5wgpQJTU0eNJmt5qyjgMtJrAuvi6D+ilRYwUIsXV+lQ15gLpbfAL1 pKyYC8j6 =m4XA -----END PGP SIGNATURE----- --Ho71OzWqGSvYQCp6--