From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E236C433EF for ; Tue, 16 Nov 2021 03:01:43 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 95ED461A03 for ; Tue, 16 Nov 2021 03:01:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 95ED461A03 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 01FB383668; Tue, 16 Nov 2021 04:01:40 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="vYdJn7mZ"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 71A3C836AC; Tue, 16 Nov 2021 04:01:38 +0100 (CET) Received: from mail-pl1-x633.google.com (mail-pl1-x633.google.com [IPv6:2607:f8b0:4864:20::633]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id ABBBD81C08 for ; Tue, 16 Nov 2021 04:01:34 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=takahiro.akashi@linaro.org Received: by mail-pl1-x633.google.com with SMTP id b13so16198662plg.2 for ; Mon, 15 Nov 2021 19:01:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:in-reply-to; bh=YIQUTLHBmDmkl5uQB9kayJ/IdOWeS3OxXmnU320HeuY=; b=vYdJn7mZiD6UGaToZF14pGLm00YlO/4Xvxq6wPDahYJtGkzu/S/t+csYCtRuKkT+7H UMQEiP2pTf8R8/p/Pxr9Dx5HV/HTDBxduOs0gQMDgz4g5VN+sGZhX3FtvgHpwC3ptZsH jjexNXJsY1EJoIE4YVXaaxwKtxuFcgOewwOjJQq+80lD0jlJCn0679ZKZvq+XCJssgi/ 2ty6bk6fmq4+FCXB82AwOs3FSNrxNQ7WuU1MuW84FQ3a+jEP+pvRWhJUAzxn4MY3rzQ0 iNJy3TcxjG+tmH6Ikys6so3TSfFvzB0EDMkrYG/CglL93ghXqWKNAll6I7pjpFA+D2fk SvNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to; bh=YIQUTLHBmDmkl5uQB9kayJ/IdOWeS3OxXmnU320HeuY=; b=r7F3DYid6xj5w60tgK9lBSVPFZ4yL8eb/qBSPfOjPm65fbTI0c2g4bIpBCw7owTtS8 MJtTmbgKqJ5I7a0SQ0KG+3mGFpM/LqrQTKAlBMtrMZv49rKTjZqkLXTlYJS1WPzBPCXO L/Q0C6cFZ+6zTFmdFmeMiL2fNObgh5M2Vl2UdyGDWnXTy2CDLIC3sx8RiTKxfeQ3g40l WwyPXsADKjqJS86ZMbX4IxdBWdbqLUPNP2+MZBFO0Dj9S/FBOstNsAeDO5ZHgpL7UwiP QE3ktnpvxFl2/3eu6vVAL/nxhQhoU81ETkAvS2WH7QLNBIBLK1bSW8EanTyNKnCmMIgF klxQ== X-Gm-Message-State: AOAM533EL1fIrGgAlEtfNc2drNKS+r0YM7GQ9diwZvtKF0elzUrwMkwA tYDoWkgNqSzXBl5Qtc6uloXnGg== X-Google-Smtp-Source: ABdhPJx9XLeDVErjkn7fbDylw3xrde1o8s3O8A52SeAthH3jZ+VCaXvqIPe8/yHfONs4r00kFMdFAA== X-Received: by 2002:a17:90b:3807:: with SMTP id mq7mr65599938pjb.226.1637031692698; Mon, 15 Nov 2021 19:01:32 -0800 (PST) Received: from laputa ([2400:4050:c3e1:100:d07c:c772:1ab9:a9e0]) by smtp.gmail.com with ESMTPSA id k129sm7310748pgk.72.2021.11.15.19.01.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Nov 2021 19:01:31 -0800 (PST) Date: Tue, 16 Nov 2021 12:01:27 +0900 From: AKASHI Takahiro To: Heinrich Schuchardt Cc: Simon Glass , Ilias Apalodimas , Tom Rini , U-Boot Mailing List , Alex Graf Subject: Re: [RFC 07/22] dm: blk: add UCLASS_PARTITION Message-ID: <20211116030127.GB5047@laputa> Mail-Followup-To: AKASHI Takahiro , Heinrich Schuchardt , Simon Glass , Ilias Apalodimas , Tom Rini , U-Boot Mailing List , Alex Graf References: <20211115014319.GA38596@laputa> <938593ce-c7fb-57a2-0294-3f21354d48a0@gmx.de> <20211115235110.GA5047@laputa> <7bfe1097-bcfb-36b5-18c4-30c067d53951@gmx.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7bfe1097-bcfb-36b5-18c4-30c067d53951@gmx.de> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.35 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On Tue, Nov 16, 2021 at 01:02:55AM +0100, Heinrich Schuchardt wrote: > On 11/16/21 00:51, AKASHI Takahiro wrote: > > > > Is the patch good enough to include in the series? > > > > > > > > If not, you could reply to it with what needs doing. > > ? I have already replied to your patch:) > > Basically, it seems to be fine to me. > > > > > > Regards, > > > > Simon > > > > > > > The patch is not usable as is. It assumes only GPT partioning is used. > > @Heinrich > > I don't get your point. Either my patch or Simon's is not specific > > to GPT at all. > > > > So I'm going to start respinning my patch for a next round of discussion. > > A field name gpt_part_info obviously relates to GPT? No. IICU, the structure, disk_partition, is not particularly GPT-specific as such type of data are used over various partition drivers. In my patch series, I simply reuse "struct disk_part" as a structure holding a partition number and partition information (= disk_partition). -Takahiro Akashi > Up to now this string exists only in cmd/gpt.c. > > Best regards > > Heinrich > > > > > -Takahiro Akashi > > > > > Instead all partition table drivers need to be converted to drivers for > > > the new uclass. > > > > > > Best regards > > > > > > Heinrich >