From: Tom Rini <trini@konsulko.com>
To: Michael Walle <michael@walle.cc>,
Ramon Fried <rfried.dev@gmail.com>, Wolfgang Denk <wd@denx.de>
Cc: Michal Simek <michal.simek@xilinx.com>,
Grygorii Strashko <grygorii.strashko@ti.com>,
git <git@xilinx.com>, Joe Hershberger <joe.hershberger@ni.com>,
Simon Glass <sjg@chromium.org>,
U-Boot Mailing List <u-boot@lists.denx.de>
Subject: Re: [PATCH] net: uclass: Save ethernet MAC address when generated
Date: Tue, 16 Nov 2021 09:18:55 -0500 [thread overview]
Message-ID: <20211116141855.GD24579@bill-the-cat> (raw)
In-Reply-To: <97cbcf456d2fa9572ef0d0c9adc7380b@walle.cc>
[-- Attachment #1: Type: text/plain, Size: 1309 bytes --]
On Thu, Nov 11, 2021 at 10:10:57AM +0100, Michael Walle wrote:
> Hi Ramon,
>
> Am 2021-11-09 14:55, schrieb Michael Walle:
> > Am 2021-11-04 22:00, schrieb Ramon Fried:
> >
> > > What's the verdict ? We're keeping this patch ?
> >
> > There was a good point from Grygorii: linux might deal
> > in its own way with missing ethernet addresses (and warn
> > the user about it because its usually an error).
> >
> > And IMHO that net list can be fixed in a different way.
> >
> > If this patch is accepted, it should be clearly documented
> > in the Kconfig help text. And as I said, it changes behavior.
>
> So this patch now in your pull request. Why are you even asking
> then?
So, to quote lib/Kconfig:
config NET_RANDOM_ETHADDR
bool "Random ethaddr if unset"
help
Selecting this will allow the Ethernet interface to function
even when the ethaddr variable for that interface is unset.
A new MAC address will be generated on every boot and it will
not be added to the environment.
We need either a re-spin or follow-up as we're changing the documented
behavior. And as I mentioned in the other thread related on-going
thread, perhaps "ethmacskip" should play a role in preserving existing
behavior?
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
next prev parent reply other threads:[~2021-11-16 14:19 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-29 11:14 [PATCH] net: uclass: Save ethernet MAC address when generated Michal Simek
2021-11-01 20:25 ` Ramon Fried
2021-11-02 9:00 ` Michael Walle
2021-11-02 10:27 ` Michal Simek
2021-11-03 16:57 ` Tom Rini
2021-11-04 11:18 ` Michal Simek
2021-11-04 11:37 ` Tom Rini
2021-11-04 11:43 ` Michal Simek
2021-11-04 12:59 ` Tom Rini
2021-11-04 13:06 ` Michal Simek
2021-11-04 2:09 ` Grygorii Strashko
2021-11-04 11:16 ` Michal Simek
2021-11-04 12:27 ` Michael Walle
2021-11-04 13:15 ` Michal Simek
2021-11-04 13:40 ` Michael Walle
2021-11-04 21:00 ` Ramon Fried
2021-11-09 13:55 ` Michael Walle
2021-11-11 9:10 ` Michael Walle
2021-11-16 14:18 ` Tom Rini [this message]
2021-11-16 14:56 ` Wolfgang Denk
2021-11-16 18:41 ` Tom Rini
2021-11-17 7:44 ` Wolfgang Denk
2021-11-17 11:50 ` Tom Rini
2021-11-17 12:24 ` Wolfgang Denk
2021-11-17 12:35 ` Tom Rini
2021-11-17 15:56 ` Wolfgang Denk
2021-11-17 16:15 ` Tom Rini
2021-11-18 7:08 ` Wolfgang Denk
2021-11-18 9:46 ` Wolfgang Denk
2021-11-18 14:51 ` Tom Rini
2021-11-18 16:29 ` Tom Rini
2021-11-18 19:04 ` Wolfgang Denk
2021-11-18 19:54 ` Tom Rini
2021-11-19 12:30 ` Michal Simek
2021-11-20 15:56 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211116141855.GD24579@bill-the-cat \
--to=trini@konsulko.com \
--cc=git@xilinx.com \
--cc=grygorii.strashko@ti.com \
--cc=joe.hershberger@ni.com \
--cc=michael@walle.cc \
--cc=michal.simek@xilinx.com \
--cc=rfried.dev@gmail.com \
--cc=sjg@chromium.org \
--cc=u-boot@lists.denx.de \
--cc=wd@denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox