From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE5E3C433F5 for ; Tue, 16 Nov 2021 14:19:09 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 568E661391 for ; Tue, 16 Nov 2021 14:19:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 568E661391 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 10DF38393A; Tue, 16 Nov 2021 15:19:07 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="rVYKaIE9"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id EE9DC83939; Tue, 16 Nov 2021 15:19:04 +0100 (CET) Received: from mail-qk1-x735.google.com (mail-qk1-x735.google.com [IPv6:2607:f8b0:4864:20::735]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id EA152838A8 for ; Tue, 16 Nov 2021 15:18:59 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qk1-x735.google.com with SMTP id a11so13992468qkh.13 for ; Tue, 16 Nov 2021 06:18:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=pr+S2mQURqpGCkbshq9Vd8OSIU/80s8m0Zah6FtJNUE=; b=rVYKaIE9KY6M5SCyO+driuW3doK+pU2rivrxBaHlzd64hufYoY2OU7Pj12DhhvNK8z pFiIHw6f3jJBkOOI96jQmRHNkaQajJ3BFcxDV/6Nz/Tu0p5HxlF+KLYW4DwecJMO0L87 dYh6eDIaC9TQwMFhSrk0h3CWB+Hf75qqZs3Hs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=pr+S2mQURqpGCkbshq9Vd8OSIU/80s8m0Zah6FtJNUE=; b=7N5kX/nTSyB20k8NKiBXPhVt/AHWIlwQwxwSbcldaxHaTuDRi97Ll3HKnFx7fqej7R nG2hr+nUILJ0fCLDtaAjnR8bJtfk7tn5YAwjSP8Ezhy91sZ5IfdxjVV2CMxp32COnLBX YwnD8zaUBcVSM9HKoP+f1hCRSb7vZ7Rjsd68OeH//f+Xt9oUvaWag7zlMxDtFJBGGQi4 9eQJXgIznx27ypV5DRAmIkelyVXU6NqcIdc1KaZYvw6FE7bazED6E13qwyq5Xa2FYv0a ixUdbch+XDHH/yEoKqsfQ2aukBIuoPqJ2y8zSMswBPxJTGfZDcQBzCysSkpVQ/LfZ3yl SbMg== X-Gm-Message-State: AOAM531vV72N5FhdwRqHB0E2OIRnlmPkU5QUyv/hQVhnVbUZ51cFKjsq lpOPWomwHR0DrIyocyM130yvvg== X-Google-Smtp-Source: ABdhPJyuQYPACyl2q7T71nPYLgR8zXpt+kKkfiylO/+FhZRsQ2QsUVMdvlTB9eDf2tnd5FS5aSQD3A== X-Received: by 2002:a05:620a:24c9:: with SMTP id m9mr6090699qkn.317.1637072338827; Tue, 16 Nov 2021 06:18:58 -0800 (PST) Received: from bill-the-cat (2603-6081-7b01-cbda-24a1-dfd8-1438-caaa.res6.spectrum.com. [2603:6081:7b01:cbda:24a1:dfd8:1438:caaa]) by smtp.gmail.com with ESMTPSA id x125sm8267599qkd.8.2021.11.16.06.18.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Nov 2021 06:18:57 -0800 (PST) Date: Tue, 16 Nov 2021 09:18:55 -0500 From: Tom Rini To: Michael Walle , Ramon Fried , Wolfgang Denk Cc: Michal Simek , Grygorii Strashko , git , Joe Hershberger , Simon Glass , U-Boot Mailing List Subject: Re: [PATCH] net: uclass: Save ethernet MAC address when generated Message-ID: <20211116141855.GD24579@bill-the-cat> References: <20211102090015.2395446-1-michael@walle.cc> <1d5f84ab-e481-8779-4b5b-adfbc4ff3bf3@ti.com> <07b688d8-f05f-d11e-5e3e-e5454e1c9af0@xilinx.com> <5fd1c7f2-d37d-3008-06d3-877958aa9757@xilinx.com> <610dcc295f1f9f8eb609269ac5a2e0d8@walle.cc> <97cbcf456d2fa9572ef0d0c9adc7380b@walle.cc> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="kD4f+Wjt0JNlGvv/" Content-Disposition: inline In-Reply-To: <97cbcf456d2fa9572ef0d0c9adc7380b@walle.cc> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.35 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --kD4f+Wjt0JNlGvv/ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Nov 11, 2021 at 10:10:57AM +0100, Michael Walle wrote: > Hi Ramon, >=20 > Am 2021-11-09 14:55, schrieb Michael Walle: > > Am 2021-11-04 22:00, schrieb Ramon Fried: > >=20 > > > What's the verdict ? We're keeping this patch ? > >=20 > > There was a good point from Grygorii: linux might deal > > in its own way with missing ethernet addresses (and warn > > the user about it because its usually an error). > >=20 > > And IMHO that net list can be fixed in a different way. > >=20 > > If this patch is accepted, it should be clearly documented > > in the Kconfig help text. And as I said, it changes behavior. >=20 > So this patch now in your pull request. Why are you even asking > then? So, to quote lib/Kconfig: config NET_RANDOM_ETHADDR bool "Random ethaddr if unset" help Selecting this will allow the Ethernet interface to function even when the ethaddr variable for that interface is unset. A new MAC address will be generated on every boot and it will not be added to the environment. We need either a re-spin or follow-up as we're changing the documented behavior. And as I mentioned in the other thread related on-going thread, perhaps "ethmacskip" should play a role in preserving existing behavior? --=20 Tom --kD4f+Wjt0JNlGvv/ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmGTvc8ACgkQFHw5/5Y0 tyyMMQwAheE3QPQ8bYefz2JIt4HZnBd96S9VE0SsygtpKg/aIBceUqXS93u41izd icqjMFPXxLPlGYFrsL8oDA2lLVfrgwDP5GehzC2/qzgSt4icetfngqpWtNpzqynJ 0/uugwsut7HDVXiYR/qI+sJoZLYr34OQd1Qsv7L2ovo9KLb7gx0Q0Mp7rAb0YQ6y sND625FTc+seBN82RsoFv3lBcQ2GQuAtYs5Sm8pAeuvDWTqzdWDqT9Gr6I2ZtYXT 3zH06QgEyTjiPv3n9RTNKDUw/0N56VG/VT2Y7txaHuF1TCi/HuHzKcJNC+goJlOK pR0BDp8suZSarsXWa3YpPj9KYIOD6pwFDxvFQyAadgGw1eHpJYmwm5TNtiCyxPrG YimD6YkBV2fP21rpcVulp8OXyjkkIOfppPcjq1Fe+sln7xUiE7H24MwZ3Dt0FTfT 06/YKWVWYrIhc9YFGuV2fmfYtSFKOWk6Z5JrMCeByX8zsn3QvlH4N9I2dj/MI3SV J20I86Sm =JDns -----END PGP SIGNATURE----- --kD4f+Wjt0JNlGvv/--