From: Tom Rini <trini@konsulko.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Simon Glass <sjg@chromium.org>,
Ovidiu Panait <ovidiu.panait@windriver.com>,
u-boot@lists.denx.de
Subject: Re: [PATCH v2 2/2] image: Explicitly declare do_bdinfo()
Date: Tue, 16 Nov 2021 14:25:53 -0500 [thread overview]
Message-ID: <20211116192553.GL24579@bill-the-cat> (raw)
In-Reply-To: <20211108180338.85786-2-andriy.shevchenko@linux.intel.com>
[-- Attachment #1: Type: text/plain, Size: 591 bytes --]
On Mon, Nov 08, 2021 at 09:03:38PM +0300, Andy Shevchenko wrote:
> Compiler is not happy:
>
> common/image-board.c: In function ‘boot_get_kbd’:
> common/image-board.c:902:17: warning: implicit declaration of function ‘do_bdinfo’ [-Wimplicit-function-declaration]
> 902 | do_bdinfo(NULL, 0, 0, NULL);
> | ^~~~~~~~~
>
> Move the forward declaration to a header.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Reviewed-by: Simon Glass <sjg@chromium.org>
Applied to u-boot/master, thanks!
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
next prev parent reply other threads:[~2021-11-16 19:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-08 18:03 [PATCH v2 1/2] image: Fix typo in boot_get_kbd() Andy Shevchenko
2021-11-08 18:03 ` [PATCH v2 2/2] image: Explicitly declare do_bdinfo() Andy Shevchenko
2021-11-09 0:09 ` Simon Glass
2021-11-16 19:25 ` Tom Rini [this message]
2021-11-09 0:09 ` [PATCH v2 1/2] image: Fix typo in boot_get_kbd() Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211116192553.GL24579@bill-the-cat \
--to=trini@konsulko.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=ovidiu.panait@windriver.com \
--cc=sjg@chromium.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox