RE: [PATCH 00/10] board: sl28: add sl28cpld support and board cleanups

Priyanka Jain
2022-02-02T06:38:38Z

>-----Original Message-----
>From: Tom Rini <trini@konsulko.com>
>Sent: Monday, January 31, 2022 8:56 PM
>To: Michael Walle <michael@walle.cc>; Priyanka Jain <priyanka.jain@nxp.com>
>Cc: u-boot@lists.denx.de
>Subject: Re: [PATCH 00/10] board: sl28: add sl28cpld support and board
>cleanups
>
>On Mon, Jan 31, 2022 at 08:51:39AM +0100, Michael Walle wrote:
>> Am 2021-11-15 23:45, schrieb Michael Walle:
>> > Add support for the sl28cpld management controller found on this board.
>> > This is especially useful, because of the integrated watchdog in
>> > this controller. It is used to supervise the bootup of the
>> > bootloader and will automatically switch to the failsafe bootloader
>> > if u-boot didn't start.
>> > Up
>> > until now, we had to disable this feature, leaving a gap in the
>> > failsafe boot concept of this board. Now, with this driver in place,
>> > this watchdog can be enabled at reset and u-boot will disable it
>> > late during its startup.
>> >
>> > Additionally, add support for the GPIOs which are connected to this
>> > controller.
>> >
>> > Besides this support, there are various cleanups, like DRAM output
>> > fix, printing the version of the management controller and disabling
>> > the random MAC address generation.
>> >
>> > Implementationwise, the MFD driver is implemented as UCLASS_NOP
>> > which provides basic access functions and will enumerate its child
>> > nodes. The device tree binding is the same as already acked by the linux
>kernel.
>>
>> Ping. This is now 2.5 month old. It doesn't even touch anything
>> outside my own board.
>
>Priyanka?
>
>--
>Tom

I saw the series delegated to me today.
I will review and merge if no comments in my next pull-request.

Regards
Priyanka