From: AKASHI Takahiro <takahiro.akashi@linaro.org>
To: Heinrich Schuchardt <xypron.glpk@gmx.de>
Cc: agraf@csgraf.de, sjg@chromium.org, ilias.apalodimas@linaro.org,
sughosh.ganu@linaro.org, masami.hiramatsu@linaro.org,
mark.kettenis@xs4all.nl, u-boot@lists.denx.de
Subject: Re: [PATCH v7 02/12] tools: build mkeficapsule with tools-only_defconfig
Date: Wed, 17 Nov 2021 10:06:28 +0900 [thread overview]
Message-ID: <20211117010628.GA36373@laputa> (raw)
In-Reply-To: <0f37c08f-cec7-c1b5-d4ff-2f791809c877@gmx.de>
On Tue, Nov 16, 2021 at 02:58:39PM +0100, Heinrich Schuchardt wrote:
> On 11/16/21 13:20, Heinrich Schuchardt wrote:
> > On 11/16/21 05:32, AKASHI Takahiro wrote:
> > > We want to always build mkeficapsule if tools-only_defconfig is used.
> > >
> > > Signed-off-by: AKASHI Takahiro <takahiro.akashi@linaro.org>
> >
> > Reviewed-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> >
> > > ---
> > > configs/tools-only_defconfig | 1 +
> > > 1 file changed, 1 insertion(+)
> > >
> > > diff --git a/configs/tools-only_defconfig b/configs/tools-only_defconfig
> > > index f482c9a1c1b0..5427797dd4c3 100644
> > > --- a/configs/tools-only_defconfig
> > > +++ b/configs/tools-only_defconfig
> > > @@ -31,3 +31,4 @@ CONFIG_I2C_EDID=y
> > > # CONFIG_VIRTIO_MMIO is not set
> > > # CONFIG_VIRTIO_PCI is not set
> > > # CONFIG_VIRTIO_SANDBOX is not set
> > > +CONFIG_TOOLS_MKEFICAPSULE=y
> > >
> >
> You cannot use a symbol that is not yet defined. Please, swap patches 2
> and 3 when resubmitting.
Instead of swapping, I will move the definition of TOOLS_MKEFICAPSULE
from patch#3 to patch#2. That would clarify the intension.
-Takahiro Akashi
> Best regards
>
> Heinrich
>
next prev parent reply other threads:[~2021-11-17 1:06 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-16 4:32 [PATCH v7 00/12] efi_loader: capsule: improve capsule authentication support AKASHI Takahiro
2021-11-16 4:32 ` [PATCH v7 01/12] tools: mkeficapsule: rework the code a little bit AKASHI Takahiro
2021-11-16 12:19 ` Heinrich Schuchardt
2021-11-17 1:20 ` AKASHI Takahiro
2021-11-16 4:32 ` [PATCH v7 02/12] tools: build mkeficapsule with tools-only_defconfig AKASHI Takahiro
2021-11-16 12:20 ` Heinrich Schuchardt
2021-11-16 13:58 ` Heinrich Schuchardt
2021-11-17 1:06 ` AKASHI Takahiro [this message]
2021-11-16 4:32 ` [PATCH v7 03/12] tools: mkeficapsule: add firmwware image signing AKASHI Takahiro
2021-11-25 11:13 ` Ilias Apalodimas
2021-11-16 4:32 ` [PATCH v7 04/12] tools: mkeficapsule: add man page AKASHI Takahiro
2021-11-25 11:13 ` Ilias Apalodimas
2021-11-16 4:32 ` [PATCH v7 05/12] doc: update UEFI document for usage of mkeficapsule AKASHI Takahiro
2021-11-25 11:15 ` Ilias Apalodimas
2021-11-16 4:32 ` [PATCH v7 06/12] test/py: efi_capsule: add image authentication test AKASHI Takahiro
2021-11-16 4:32 ` [PATCH v7 07/12] tools: mkeficapsule: allow for specifying GUID explicitly AKASHI Takahiro
2021-11-16 4:32 ` [PATCH v7 08/12] test/py: efi_capsule: align with the syntax change of mkeficapsule AKASHI Takahiro
2021-11-16 4:32 ` [PATCH v7 09/12] test/py: efi_capsule: add a test for "--guid" option AKASHI Takahiro
2021-11-16 4:32 ` [PATCH v7 10/12] test/py: efi_capsule: check the results in case of CAPSULE_AUTHENTICATE AKASHI Takahiro
2021-11-16 4:32 ` [PATCH v7 11/12] (RFC) tools: add fdtsig.sh AKASHI Takahiro
2021-11-25 0:11 ` Simon Glass
2021-11-16 4:32 ` [PATCH v7 12/12] (RFC) efi_loader, dts: add public keys for capsules to device tree AKASHI Takahiro
2021-11-25 0:11 ` Simon Glass
2021-11-25 2:21 ` AKASHI Takahiro
2021-12-07 15:07 ` Simon Glass
2021-11-25 6:02 ` [PATCH v7 00/12] efi_loader: capsule: improve capsule authentication support AKASHI Takahiro
2021-12-03 7:09 ` AKASHI Takahiro
2021-12-17 2:24 ` AKASHI Takahiro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211117010628.GA36373@laputa \
--to=takahiro.akashi@linaro.org \
--cc=agraf@csgraf.de \
--cc=ilias.apalodimas@linaro.org \
--cc=mark.kettenis@xs4all.nl \
--cc=masami.hiramatsu@linaro.org \
--cc=sjg@chromium.org \
--cc=sughosh.ganu@linaro.org \
--cc=u-boot@lists.denx.de \
--cc=xypron.glpk@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox