From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1108C433F5 for ; Wed, 17 Nov 2021 01:06:45 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D6E6C61465 for ; Wed, 17 Nov 2021 01:06:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org D6E6C61465 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 47EDA82F9D; Wed, 17 Nov 2021 02:06:42 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="NVO4gwDj"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 4712B82F9A; Wed, 17 Nov 2021 02:06:40 +0100 (CET) Received: from mail-pg1-x52c.google.com (mail-pg1-x52c.google.com [IPv6:2607:f8b0:4864:20::52c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id DB74382F5F for ; Wed, 17 Nov 2021 02:06:36 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=takahiro.akashi@linaro.org Received: by mail-pg1-x52c.google.com with SMTP id m15so674929pgu.11 for ; Tue, 16 Nov 2021 17:06:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=Qn0dtQL1Mmmaf7XldnXliEovd1yTjoDCv7FCuSgKLfo=; b=NVO4gwDjTPCOaFG8hVcdiqvB7Ta+KWV6YhF2hjMaQvhmjXyHMKBLyf4+zq8y6NV6Y9 IcqmL4/C/RzfN452xTZJD20gs5PnHSNCczIBCMYjg9cA60dVtdiLzQFy58ndjqamlYWI AxTZYRK+jHAZ3XyUqoZUmXtaFX9/Asa+0mBtuY1b/Jj3u8f+4SQJEEoZe3uMP3I03TNv kUqEFt2B9Nlq/roa0fqfnaK7PrCKcPSB0etzTRBRvLhN3sedYrLntOlZxXroZdJMdh60 o0cR87P8Fta6pFwbi+sjdOzkOaw+N2CSW+W2DsvAR7LXf2vWkeFZxUM8gAlPA6fBxQW3 nU8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :content-transfer-encoding:in-reply-to; bh=Qn0dtQL1Mmmaf7XldnXliEovd1yTjoDCv7FCuSgKLfo=; b=u3V9tJhdyJSCyetjlSKbaHDOmAH1l/A9KuokSlobuUp7SCOHZAK/SlV86DOR6Ao0gx BucsF5jyuvLZRVs4kr4WJ/S4Zwhzt2ygGobFl8bjLp5wdjNNM3kLcdKD6xrGXIO3JxeZ wcmCmaV3uZCy70wKS8HKg4YGxdKWk10hMYZ4w2ct6ZCy7Rgrtn4GNgpoZYcBHRTujw78 A/eYkUhoIdNDAiFtRyIOgVevalCc/zWFcvPb8JY+yCg6OqTqT3a6Dcut+wwDcfJcYZDf /YwV/ObuyL+Ftd81t/KABUJP9SW1aWiuHgAfPiA1mX1L1eOlJ4OcG66KWMxWOUKdS8Qm 2xEw== X-Gm-Message-State: AOAM532RHWK6MqlG0xcFe3sU5fJigAPlD4QzB1zoFF/ms7pBAUrViwIr iGeRAqeBtIMsalsZaqsH4SoLzw== X-Google-Smtp-Source: ABdhPJyLJuS7+r5AwzaGZaCXZXJdQQOgOub9XvcpbJyeJ5G9bCeehmMKdCl9HPGFzA6BoCaCmOo0Jw== X-Received: by 2002:a63:cd0a:: with SMTP id i10mr2451804pgg.429.1637111193665; Tue, 16 Nov 2021 17:06:33 -0800 (PST) Received: from laputa ([2400:4050:c3e1:100:90f8:8cb4:ef2e:56be]) by smtp.gmail.com with ESMTPSA id w65sm2731963pfd.195.2021.11.16.17.06.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Nov 2021 17:06:33 -0800 (PST) Date: Wed, 17 Nov 2021 10:06:28 +0900 From: AKASHI Takahiro To: Heinrich Schuchardt Cc: agraf@csgraf.de, sjg@chromium.org, ilias.apalodimas@linaro.org, sughosh.ganu@linaro.org, masami.hiramatsu@linaro.org, mark.kettenis@xs4all.nl, u-boot@lists.denx.de Subject: Re: [PATCH v7 02/12] tools: build mkeficapsule with tools-only_defconfig Message-ID: <20211117010628.GA36373@laputa> Mail-Followup-To: AKASHI Takahiro , Heinrich Schuchardt , agraf@csgraf.de, sjg@chromium.org, ilias.apalodimas@linaro.org, sughosh.ganu@linaro.org, masami.hiramatsu@linaro.org, mark.kettenis@xs4all.nl, u-boot@lists.denx.de References: <20211116043238.67226-1-takahiro.akashi@linaro.org> <20211116043238.67226-3-takahiro.akashi@linaro.org> <10c0ea45-4a47-7cbf-1090-dce7f6245246@gmx.de> <0f37c08f-cec7-c1b5-d4ff-2f791809c877@gmx.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <0f37c08f-cec7-c1b5-d4ff-2f791809c877@gmx.de> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.35 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On Tue, Nov 16, 2021 at 02:58:39PM +0100, Heinrich Schuchardt wrote: > On 11/16/21 13:20, Heinrich Schuchardt wrote: > > On 11/16/21 05:32, AKASHI Takahiro wrote: > > > We want to always build mkeficapsule if tools-only_defconfig is used. > > > > > > Signed-off-by: AKASHI Takahiro > > > > Reviewed-by: Heinrich Schuchardt > > > > > --- > > >   configs/tools-only_defconfig | 1 + > > >   1 file changed, 1 insertion(+) > > > > > > diff --git a/configs/tools-only_defconfig b/configs/tools-only_defconfig > > > index f482c9a1c1b0..5427797dd4c3 100644 > > > --- a/configs/tools-only_defconfig > > > +++ b/configs/tools-only_defconfig > > > @@ -31,3 +31,4 @@ CONFIG_I2C_EDID=y > > >   # CONFIG_VIRTIO_MMIO is not set > > >   # CONFIG_VIRTIO_PCI is not set > > >   # CONFIG_VIRTIO_SANDBOX is not set > > > +CONFIG_TOOLS_MKEFICAPSULE=y > > > > > > You cannot use a symbol that is not yet defined. Please, swap patches 2 > and 3 when resubmitting. Instead of swapping, I will move the definition of TOOLS_MKEFICAPSULE from patch#3 to patch#2. That would clarify the intension. -Takahiro Akashi > Best regards > > Heinrich >